fix(build): paths aliases in transpiled output (#23)

* fix(build): paths aliases in transpiled output

* chore(sonar): ignoring irrelevant files

Author: jpb06

biome.json

@@ -2,7 +2,7 @@
   "$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
   "organizeImports": { "enabled": true },
   "files": {
-    "ignore": []
+    "ignore": ["./dist"]
   },
   "linter": {
     "enabled": true,
@@ -24,7 +24,25 @@
         "noWith": "error",
         "useLiteralKeys": "error",
         "useOptionalChain": "error",
-        "useRegexLiterals": "error"
+        "useRegexLiterals": "error",
+        "noEmptyTypeParameters": "error",
+        "noExcessiveCognitiveComplexity": {
+          "level": "error",
+          "options": {
+            "maxAllowedComplexity": 25
+          }
+        },
+        "noExcessiveNestedTestSuites": "error",
+        "noForEach": "error",
+        "noThisInStatic": "error",
+        "noUselessEmptyExport": "error",
+        "noUselessFragments": "error",
+        "noUselessLabel": "error",
+        "noUselessThisAlias": "error",
+        "useArrowFunction": "error",
+        "useFlatMap": "error",
+        "useSimpleNumberKeys": "error",
+        "useSimplifiedLogicExpression": "error"
       },
       "correctness": {
         "noConstAssign": "error",
@@ -44,16 +62,40 @@
         "noUnsafeFinally": "error",
         "noUnusedVariables": "error",
         "useArrayLiterals": "error",
-        "useIsNan": "error"
+        "useIsNan": "error",
+        "noInnerDeclarations": "error",
+        "noInvalidNewBuiltin": "error",
+        "noSetterReturn": "error",
+        "noUnnecessaryContinue": "error",
+        "noStringCaseMismatch": "error",
+        "noUnsafeOptionalChaining": "error",
+        "noUnusedImports": "error",
+        "noUnusedPrivateClassMembers": "error",
+        "noVoidTypeReturn": "error",
+        "useExhaustiveDependencies": "error",
+        "useHookAtTopLevel": "error",
+        "useJsxKeyInIterable": "error",
+        "useValidForDirection": "error",
+        "useYield": "error",
+        "noChildrenProp": "error",
+        "noConstructorReturn": "error",
+        "noFlatMapIdentity": "error",
+        "noRenderReturnValue": "error",
+        "noUnusedLabels": "error",
+        "noVoidElementsWithChildren": "error"
+      },
+      "security": {
+        "noGlobalEval": "error",
+        "noDangerouslySetInnerHtml": "error",
+        "noDangerouslySetInnerHtmlWithChildren": "error"
       },
-      "security": { "noGlobalEval": "error" },
       "style": {
         "noCommaOperator": "error",
         "noNamespace": "error",
         "noUselessElse": "error",
         "noImplicitBoolean": "error",
         "noNonNullAssertion": "off",
-        "noVar": "warn",
+        "noVar": "error",
         "useAsConstAssertion": "error",
         "useBlockStatements": "error",
         "useConsistentArrayType": {
@@ -62,7 +104,43 @@
         },
         "useConst": "error",
         "useShorthandFunctionType": "error",
-        "useSingleVarDeclarator": "error"
+        "useSingleVarDeclarator": "error",
+        "noArguments": "error",
+        "noDefaultExport": "error",
+        "noInferrableTypes": "error",
+        "noNamespaceImport": "error",
+        "noNegationElse": "error",
+        "noParameterAssign": "error",
+        "noParameterProperties": "off",
+        "noShoutyConstants": "error",
+        "noUnusedTemplateLiteral": "error",
+        "useCollapsedElseIf": "error",
+        "useDefaultParameterLast": "error",
+        "useEnumInitializers": "error",
+        "useExponentiationOperator": "error",
+        "useExportType": "error",
+        "useFilenamingConvention": {
+          "level": "error",
+          "options": {
+            "requireAscii": true,
+            "filenameCases": ["kebab-case"]
+          }
+        },
+        "useForOf": "error",
+        "useFragmentSyntax": "error",
+        "useImportType": "error",
+        "useLiteralEnumMembers": "error",
+        "useNodejsImportProtocol": "error",
+        "useNumericLiterals": "error",
+        "useSelfClosingElements": "error",
+        "useShorthandArrayType": "error",
+        "useShorthandAssign": "error",
+        "useSingleCaseStatement": "error",
+        "useTemplate": {
+          "level": "warn",
+          "fix": "none"
+        },
+        "useWhile": "error"
       },
       "suspicious": {
         "noAsyncPromiseExecutor": "error",
@@ -94,7 +172,32 @@
         "noUnsafeNegation": "error",
         "useDefaultSwitchClauseLast": "error",
         "useNamespaceKeyword": "error",
-        "useValidTypeof": "error"
+        "useValidTypeof": "error",
+        "noApproximativeNumericConstant": "error",
+        "noArrayIndexKey": "error",
+        "noAssignInExpressions": "error",
+        "noCommentText": "error",
+        "noConfusingLabels": "error",
+        "noConsoleLog": "error",
+        "noConstEnum": "error",
+        "noDuplicateJsxProps": "error",
+        "noDuplicateTestHooks": "error",
+        "noEmptyInterface": "error",
+        "noExportsInTest": "error",
+        "noFocusedTests": "error",
+        "noGlobalIsFinite": "error",
+        "noGlobalIsNan": "error",
+        "noImplicitAnyLet": "error",
+        "noLabelVar": "error",
+        "noMisrefactoredShorthandAssign": "error",
+        "noRedundantUseStrict": "error",
+        "noSkippedTests": "error",
+        "noSparseArray": "error",
+        "noSuspiciousSemicolonInJsx": "error",
+        "noThenProperty": "error",
+        "useAwait": "error",
+        "useGetterReturn": "error",
+        "useIsArray": "error"
       }
     },
     "ignore": [
@@ -112,56 +215,5 @@
       "semicolons": "always",
       "indentStyle": "space"
     }
-  },
-  "overrides": [
-    {
-      "include": ["**/*.ts", "**/*.tsx", "**/*.mts", "**/*.cts"],
-      "linter": {
-        "rules": {
-          "correctness": {
-            "noConstAssign": "off",
-            "noGlobalObjectCalls": "off",
-            "noInvalidConstructorSuper": "off",
-            "noInvalidNewBuiltin": "off",
-            "noNewSymbol": "off",
-            "noSetterReturn": "off",
-            "noUndeclaredVariables": "off",
-            "noUnreachable": "off",
-            "noUnreachableSuper": "off"
-          },
-          "style": {
-            "noArguments": "error",
-            "noVar": "error",
-            "useConst": "error"
-          },
-          "suspicious": {
-            "noDuplicateClassMembers": "off",
-            "noDuplicateObjectKeys": "off",
-            "noDuplicateParameters": "off",
-            "noFunctionAssign": "off",
-            "noImportAssign": "off",
-            "noRedeclare": "off",
-            "noUnsafeNegation": "off",
-            "useGetterReturn": "off",
-            "useAwait": "error"
-          }
-        }
-      }
-    },
-    {
-      "include": ["**/*.ts", "**/*.mts"],
-      "linter": {
-        "rules": {
-          "complexity": { "noUselessTernary": "error" },
-          "nursery": {},
-          "suspicious": {
-            "noDoubleEquals": "error",
-            "useIsArray": "error",
-            "noFocusedTests": "error",
-            "noSkippedTests": "error"
-          }
-        }
-      }
-    }
-  ]
+  }
 }

bun.lockb

@@ -12,47 +12,24 @@
   ],
   "main": "./cjs/index.js",
   "module": "./esm/index.js",
+  "types": "./dts/index.ts",
   "type": "module",
   "exports": {
     ".": {
       "require": {
         "default": "./cjs/index.js",
-        "types": "./dts/cjs/index.d.ts"
+        "types": "./dts/index.d.ts"
       },
       "import": {
         "default": "./esm/index.js",
-        "types": "./dts/esm/index.d.ts"
+        "types": "./dts/index.d.ts"
       }
     }
   },
   "engines": {
     "node": "20.x"
   },
-  "dependencies": {
-    "@octokit/core": "^6.1.2",
-    "dotenv-flow": "^4.1.0",
-    "effect": "^3.8.4",
-    "picocolors": "^1.1.0",
-    "ts-pattern": "^5.4.0"
-  },
-  "devDependencies": {
-    "@biomejs/biome": "^1.9.2",
-    "@types/bun": "latest",
-    "@types/node": "^22.7.4",
-    "@vitest/coverage-v8": "^2.1.1",
-    "copyfiles": "^2.4.1",
-    "del-cli": "^6.0.0",
-    "effect-errors": "^1.7.12",
-    "readme-package-icons": "^1.1.15",
-    "ts-patch": "^3.2.1",
-    "typescript": "5.6.3",
-    "typescript-transform-paths": "^3.5.1",
-    "vite-tsconfig-paths": "^5.0.1",
-    "vitest": "^2.1.1",
-    "vitest-mock-extended": "^2.0.2"
-  },
   "scripts": {
-    "prepare": "ts-patch install -s",
     "update-deps": "bunx npm-check-updates --root --format group -i",
     "copy-package": "copyfiles package.json ./dist/",
     "copy-readme": "copyfiles README.md ./dist/",
@@ -61,15 +38,38 @@
     "build-cjs": "tsc --project tsconfig.cjs.json",
     "postbuild-cjs": "echo '{\"type\": \"commonjs\"}' > dist/cjs/package.json",
     "postbuild-esm": "echo '{\"type\": \"module\"}' > dist/esm/package.json",
-    "postbuild": "bun run copy-package && bun run copy-readme",
+    "postbuild": "bun run copy-package && bun run copy-readme && bun resolve-ts-paths-esm",
     "type-check": "tsc --noEmit",
     "format": "biome format --write ./src",
     "format-ci": "biome format ./src",
     "lint": "biome lint ./src",
+    "lint-fix": "biome lint --write ./src",
     "test": "vitest",
     "test-ci": "vitest --coverage --run",
     "test-dev": "vitest --coverage",
     "test-coverage": "vitest run --coverage",
     "sync-icons": "bun generateReadmeIcons -h 50"
+  },
+  "dependencies": {
+    "@octokit/core": "^6.1.2",
+    "dotenv-flow": "^4.1.0",
+    "effect": "^3.9.2",
+    "picocolors": "^1.1.1",
+    "ts-pattern": "^5.5.0"
+  },
+  "devDependencies": {
+    "@biomejs/biome": "^1.9.4",
+    "@types/bun": "latest",
+    "@types/node": "^22.7.7",
+    "@vitest/coverage-v8": "^2.1.3",
+    "copyfiles": "^2.4.1",
+    "del-cli": "^6.0.0",
+    "effect-errors": "^1.7.18",
+    "readme-package-icons": "^1.1.16",
+    "ts-paths-resolver": "^1.1.6",
+    "typescript": "5.6.3",
+    "vite-tsconfig-paths": "^5.0.1",
+    "vitest": "^2.1.3",
+    "vitest-mock-extended": "^2.0.2"
   }
 }

package.json

@@ -5,5 +5,5 @@ sonar.projectName=effect-github-stats
 sonar.sources=.
 
 sonar.javascript.lcov.reportPaths=./coverage/lcov.info
-sonar.exclusions=src/tests/**,src/**/*.test.ts,src/index.ts,src/test.ts,src/**/*.type.ts,src/types/**
+sonar.exclusions=src/tests/**,src/**/*.test.ts,src/index.ts,src/test.ts,src/**/*.type.ts,src/types/**,src/layer/octokit.layer.ts,src/layer/effects/tap-layer.effect.ts
 sonar.verbose=false

sonar-project.properties

@@ -1,7 +1,8 @@
 import { OctokitLayerLive } from './layer/github/octokit.layer-live.js';
-import { OctokitLayer, RepoArgs } from './layer/octokit.layer.js';
+import type { RepoArgs } from './layer/octokit.layer.js';
+import { OctokitLayer } from './layer/octokit.layer.js';
 
-export { OctokitLayerLive, OctokitLayer };
+export { OctokitLayer, OctokitLayerLive };
 export type { RepoArgs };
 
 export * from './types/effect.types.js';

src/index.ts

@@ -5,7 +5,7 @@ import { GithubApiError } from '@errors';
 import { mockData, octokitRequestResponseHeaders } from '@tests/mock-data';
 import { mockConsole, octokitMock } from '@tests/mocks';
 
-import { GetPullRequestReviewsArgs } from './get-pull-request-reviews.js';
+import type { GetPullRequestReviewsArgs } from './get-pull-request-reviews.js';
 
 vi.mock('@octokit/core');
 mockConsole({

src/layer/effects/tapLayer.effect.ts src/layer/effects/tap-layer.effect.tssrc/layer/effects/tapLayer.effect.ts renamed to src/layer/effects/tap-layer.effect.ts

@@ -1,6 +1,6 @@
 import { Effect } from 'effect';
 
-import { EffectResultSuccess } from '@types';
+import type { EffectResultSuccess } from '@types';
 import { getAllPages } from '../generic/get-all-pages.effect.js';
 import { getPullRequestReviewsPage } from '../paging/get-pull-request-reviews-page.js';
 

src/layer/github/implementation/aggregators/get-pull-request-reviews.test.ts

@@ -5,7 +5,7 @@ import { GithubApiError } from '@errors';
 import { mockData, octokitRequestResponseHeaders } from '@tests/mock-data';
 import { mockConsole, octokitMock } from '@tests/mocks';
 
-import { GetRepoIssuesArgs } from './get-repo-issues.js';
+import type { GetRepoIssuesArgs } from './get-repo-issues.js';
 
 vi.mock('@octokit/core');
 mockConsole({

src/layer/github/implementation/aggregators/get-pull-request-reviews.ts

@@ -1,6 +1,6 @@
 import { Effect } from 'effect';
 
-import { EffectResultSuccess } from '@types';
+import type { EffectResultSuccess } from '@types';
 
 import { getAllPages } from '../generic/get-all-pages.effect.js';
 import { getRepoIssuesPage } from '../paging/get-repo-issues-page.js';