add additional tests, remove deprecated check for list value

Author: jpdillingham

src/Utility.CommandLine.Arguments/Arguments.cs

@@ -430,16 +430,7 @@ public static void Populate(Type type, Arguments arguments, bool clearExistingVa
                     }
                     else if (propertyType.IsArray || (propertyType.IsGenericType && propertyType.GetGenericTypeDefinition() == typeof(List<>)))
                     {
-                        // if the property is an array or list, convert the value to an array or list of the matching type. start
-                        // by converting atomic values to a list containing a single value, just to simplify processing.
-                        if (valueIsList)
-                        {
-                            convertedValue = value;
-                        }
-                        else
-                        {
-                            convertedValue = new List<object>(new object[] { value });
-                        }
+                        convertedValue = value;
 
                         // next, create a list with the same type as the target property
                         Type valueType;

tests/Utility.CommandLine.Arguments.Tests/ArgumentsTests.cs

@@ -888,6 +888,76 @@ public void Value_Is_Replaced_Given_Multiple_Long()
             Assert.Equal("2", dict["bb"]);
         }
 
+        [Fact]
+        public void Value_Is_Replaced_Given_Multiple_Long_No_Type()
+        {
+            var list = new List<KeyValuePair<string, string>>();
+            list.Add(new KeyValuePair<string, string>("bb", "1"));
+            list.Add(new KeyValuePair<string, string>("bb", "2"));
+
+            var a = Arguments.Parse("--bb 1 --bb 2");
+            var dict = a.ArgumentDictionary;
+
+            Assert.Single(dict);
+            Assert.Equal("2", dict["bb"]);
+
+            Assert.Equal(2, a.ArgumentList.Count);
+            Assert.True(a.ArgumentList.Where(r => r.Key == "bb" && r.Value == "1").Any());
+            Assert.True(a.ArgumentList.Where(r => r.Key == "bb" && r.Value == "2").Any());
+        }
+
+        [Fact]
+        public void ArgumentList_Retains_Replaced_Arguments()
+        {
+            var list = new List<KeyValuePair<string, string>>();
+            list.Add(new KeyValuePair<string, string>("bb", "1"));
+            list.Add(new KeyValuePair<string, string>("bb", "2"));
+
+            var a = Arguments.Parse("--bb 1 --bb 2");
+
+            Assert.Equal(2, a.ArgumentList.Count);
+            Assert.True(a.ArgumentList.Where(r => r.Key == "bb" && r.Value == "1").Any());
+            Assert.True(a.ArgumentList.Where(r => r.Key == "bb" && r.Value == "2").Any());
+        }
+
+        [Fact]
+        public void Arguments_Returns_ArgumentList_Elements_Via_Indexer()
+        {
+            var list = new List<KeyValuePair<string, string>>();
+            list.Add(new KeyValuePair<string, string>("bb", "1"));
+            list.Add(new KeyValuePair<string, string>("bb", "2"));
+
+            var a = Arguments.Parse("--bb 1 --bb 2");
+
+            Assert.Equal("1", a[0]);
+            Assert.Equal("2", a[1]);
+        }
+
+        [Fact]
+        public void Arguments_Sets_TargetType_Given_Type()
+        {
+            var list = new List<KeyValuePair<string, string>>();
+            list.Add(new KeyValuePair<string, string>("bb", "1"));
+            list.Add(new KeyValuePair<string, string>("bb", "2"));
+
+            var a = Arguments.Parse("--bb 1 --bb 2", GetType());
+
+            Assert.NotNull(a.TargetType);
+            Assert.Equal(GetType(), a.TargetType);
+        }
+
+        [Fact]
+        public void Arguments_Does_Not_Set_TargetType_Given_No_Type()
+        {
+            var list = new List<KeyValuePair<string, string>>();
+            list.Add(new KeyValuePair<string, string>("bb", "1"));
+            list.Add(new KeyValuePair<string, string>("bb", "2"));
+
+            var a = Arguments.Parse("--bb 1 --bb 2");
+
+            Assert.Null(a.TargetType);
+        }
+
         [Fact]
         public void Value_Is_Replaced_Given_Mixed_Args_Long_First()
         {