Revert "[NFC] Change the return type of getTraversalScope to ArrayRef"

This reverts commit 9189d84.

ASan catches that someone actually DOES modify the collection somewhere
it looks.

Author: erichkeane

clang/include/clang/AST/ASTContext.h

@@ -723,7 +723,7 @@ class ASTContext : public RefCountedBase<ASTContext> {
   // (However they are still accessible via TranslationUnitDecl->decls())
   //
   // Changing the scope clears the parent cache, which is expensive to rebuild.
-  ArrayRef<Decl *> getTraversalScope() const { return TraversalScope; }
+  std::vector<Decl *> getTraversalScope() const { return TraversalScope; }
   void setTraversalScope(const std::vector<Decl *> &);
 
   /// Forwards to get node parents from the ParentMapContext. New callers should