RFC: Counting of non-countable objects, close #354.

Author: dim-s

jphp-core/tests/org/develnext/jphp/core/compiler/jvm/ArraysTest.java

@@ -93,6 +93,11 @@ public void testArrayReturn() {
         Assert.assertEquals(1, memory.toValue(ArrayMemory.class).size());
     }
 
+    @Test
+    public void testCountInvalid() {
+        check("arrays/count_invalid.phpt");
+    }
+
     @Test
     public void testBugs() {
         check("arrays/bug148.php");

jphp-core/tests/org/develnext/jphp/core/compiler/jvm/GeneratorsTest.java

@@ -209,6 +209,11 @@ public void testNestedCallsWithDie() {
         Assert.assertTrue(false);
     }
 
+    @Test
+    public void testCountError() {
+        check("generators/count_error.phpt");
+    }
+
     @Test
     public void testBug262() {
         check("generators/bug262.php");

jphp-core/tests/resources/arrays/count_invalid.phpt

@@ -0,0 +1,41 @@
+--TEST--
+Only arrays and countable objects can be counted
+--FILE--
+<?php
+$v = null;
+$result = count($v);
+var_dump($result);
+
+$v = "string";
+$result = count($v);
+var_dump($result);
+
+$v = 123;
+$result = count($v);
+var_dump($result);
+
+$v = true;
+$result = count($v);
+var_dump($result);
+
+$v = false;
+$result = count($v);
+var_dump($result);
+
+$result = count((object) []);
+var_dump($result);
+
+?>
+--EXPECTF--
+Warning: count(): Parameter must be an array or an object that implements Countable in %s on line %d at pos %d
+int(0)
+Warning: count(): Parameter must be an array or an object that implements Countable in %s on line %d at pos %d
+int(1)
+Warning: count(): Parameter must be an array or an object that implements Countable in %s on line %d at pos %d
+int(1)
+Warning: count(): Parameter must be an array or an object that implements Countable in %s on line %d at pos %d
+int(1)
+Warning: count(): Parameter must be an array or an object that implements Countable in %s on line %d at pos %d
+int(1)
+Warning: count(): Parameter must be an array or an object that implements Countable in %s on line %d at pos %d
+int(1)

jphp-core/tests/resources/generators/count_error.phpt

@@ -0,0 +1,18 @@
+--TEST--
+Generators can't be counted
+--FILE--
+<?php
+
+function gen() { yield; }
+
+$gen = gen();
+
+try {
+    count($gen);
+} catch (Exception $e) {
+    echo $e;
+}
+
+?>
+--EXPECTF--
+Warning: count(): Parameter must be an array or an object that implements Countable in %s on line %d at pos %d

jphp-runtime/src/php/runtime/ext/core/ArrayFunctions.java

@@ -17,6 +17,8 @@
 
 public class ArrayFunctions extends FunctionsContainer {
 
+    public static final String COUNT_WARN_MSG = "count(): Parameter must be an array or an object that implements Countable";
+
     private static int recursive_count(Environment env, TraceInfo trace, ArrayMemory array, Set<Integer> used){
         ForeachIterator iterator = array.foreachIterator(false, false);
         int size = array.size();
@@ -50,15 +52,16 @@ public static Memory is_countable(Environment env, TraceInfo traceInfo, Memory v
         return Memory.FALSE;
     }
 
-    @Runtime.Immutable
     public static Memory count(Environment env, TraceInfo trace, Memory var, int mode){
         switch (var.type){
             case ARRAY:
                 if (mode == 1){
                     return LongMemory.valueOf(recursive_count(env, trace, var.toValue(ArrayMemory.class), null));
                 } else
                     return LongMemory.valueOf(var.toValue(ArrayMemory.class).size());
-            case NULL: return Memory.CONST_INT_0;
+            case NULL:
+                env.warning(trace, COUNT_WARN_MSG);
+                return Memory.CONST_INT_0;
             case OBJECT:
                 ObjectMemory objectMemory = var.toValue(ObjectMemory.class);
                 if (objectMemory.value instanceof Countable){
@@ -68,9 +71,11 @@ public static Memory count(Environment env, TraceInfo trace, Memory var, int mod
                         env.forwardThrow(throwable);
                     }
                 } else {
+                    env.warning(trace, COUNT_WARN_MSG);
                     return Memory.CONST_INT_1;
                 }
             default:
+                env.warning(trace, COUNT_WARN_MSG);
                 return Memory.CONST_INT_1;
         }
     }