Merge pull request #267 from aws/jpinkney-aws/foo

fix(ci): test

Author: jpinkney-aws

.github/workflows/lintcommit.js

@@ -88,7 +88,7 @@ function validateTitle(title) {
     } else if (subject.length === 0) {
         return 'empty subject'
     } else if (subject.length > 100) {
-        return 'invalid subject (must be <=100 chars)'
+        return 'invalid subject2 (must be <=100 chars)'
     }
 
     return undefined

.github/workflows/notification.yml

@@ -4,8 +4,6 @@
 name: Notifications
 
 on:
-    push:
-        branches: [master, staging]
     pull_request_target:
         branches: [master, feature/*, staging]
         # Default = opened + synchronize + reopened.
@@ -19,14 +17,15 @@ on:
 
 # Cancel old jobs when a pull request is updated.
 concurrency:
-    group: ${{ github.head_ref || github.run_id }}
+    group: ${{ github.workflow }}-${{ github.ref }}
     cancel-in-progress: true
 
 jobs:
     lint-commits:
         runs-on: ubuntu-latest
         permissions:
             pull-requests: write
+            issues: read
         steps:
             - uses: actions/checkout@v4
               with:

.github/workflows/notify.js

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-const { parsePRTitle, hasPath, dedupComment } = require('./utils')
+const { parsePRTitle, hasPath } = require('./utils')
 
 const testFilesMessage =
     'This pull request modifies files in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.'
@@ -21,7 +21,6 @@ module.exports = async ({ github, context }) => {
     const owner = context.repo.owner
     const repo = context.repo.repo
     const author = context.payload.pull_request.head.repo.owner.login
-    const pullRequestId = context.payload.pull_request.number
 
     const response = await github.rest.repos.compareCommitsWithBasehead({
         owner,
@@ -38,19 +37,13 @@ module.exports = async ({ github, context }) => {
         return
     }
 
-    // Check for prior comments on the PR
-    const comments = await github.rest.issues.listComments({
-        owner,
-        repo,
-        issue_number: pullRequestId,
-    })
-
     if (shouldAddTestFileMessage) {
-        await dedupComment({ github, comments, owner, repo, pullRequestId, message: testFilesMessage })
+        // We can't really block on this one, since its valid to make a change in src/ without adding tests :(        console.error(testFilesMessage)
     }
 
     if (shouldAddChangelogMessage) {
-        await dedupComment({ github, comments, owner, repo, pullRequestId, message: changelogMessage })
+        console.error(changelogMessage)
+        process.exit(1)
     }
 }
 

.github/workflows/utils.js

@@ -25,22 +25,6 @@ function parsePRTitle(title) {
     }
 }
 
-/**
- * Create a comment on a PR if one does not already exist
- */
-async function dedupComment({ github, pullRequestId, owner, repo, comments, message }) {
-    if (comments.data.some((comment) => comment.body.includes(message))) {
-        return
-    }
-
-    await github.rest.issues.createComment({
-        issue_number: pullRequestId,
-        owner,
-        repo,
-        body: message,
-    })
-}
-
 /*
  * Check if path is included in at least one of the filename paths
  */
@@ -50,6 +34,5 @@ function hasPath(filenames, path) {
 
 module.exports = {
     parsePRTitle,
-    dedupComment,
     hasPath,
 }