Skip to content

Don't read git config in build.rs #695

@colemickens

Description

@colemickens

Describe the bug

I find it very inappropriate that psst-core's build.rs is... reading the git configuration.

We have to patch this in nixpkgs, and I'm glad that we do. It would be great to not have to carry a patch and manually rebase it constantly because of the choices to try to embed this information in the binary, in this way.

To Reproduce

see: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/ps/psst/make-build-reproducible.patch

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • OS:
  • Version:

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions