Skip to content

Commit 32c2952

Browse files
committed
fix(javadoc): phase 1 — fix all errors, add missing descriptions and type params
Errors fixed (100 → 0): - Replace <font>/<tt> HTML4 tags with {@code} or plain text (BSHLogListener, JCEHandler, ISOBinaryField, ISOField, CharTag, CharTagMap, SimpleConfiguration) - Remove bare <email> angle brackets from @author tags (11 files) - Fix stray </p> after </ul> (TPS, ExceptionHandlerAware, LSpace, CryptographicServiceMessage, FSDMsg, RotateLogListener) - Replace <p/> self-closing with <p> (TaggedFieldPackagerBase, GenericPackager, TaggedSequencePackager, SMAdapter, ISOMsg, ISOUtil) - Escape raw XML tags in prose with {@code} or <pre>{@code}</pre> (RealmLogFilter, RemoveNewLinesMapper, QFactory, SelectDestination, VErrorParser, BSHLogListener table) - Fix bare & entities → &amp; (IFE_CHAR, IF_ECHAR, IF_NOP, FilterLogListener, KeyScheme, ModeOfUse, SMAdapter, TLVList) - Fix @see 'url' format → @see <a href=...> (ISOCurrency) - Wrap orphan <li> items in <ul> (ISOUtil, SMAdapter, ARPCMethod, JCESecurityModule) - Fix trailing ; on @throws/@exception class names (ISOSource, BaseChannel, ISOServer, QMUX and others) - Split comma-separated @exception into individual tags (ASCIIChannel, CSChannel, GICCChannel, GZIPChannel) - Fix <H1>/<H3> heading sequence → <h2> (FSDMsg, CMFChannel) - Fix broken @ tags with space (KeySerialNumber) - Fix @exception for undeclared checked exceptions (IF_NOP, Metrics) - Fix email in @author: Leonard Thomas in BaseChannel - Fix missing semicolon on &gt entity (ISOMeterFactory) - Add table caption (BSHLogListener, SMAdapter) - Fix invalid </br> → <br> (ISOMsgMetrics) - Fix {@link} reference not found (CMFChannel → BaseChannel#accept) - Fix <br/> self-closing (GenericPackager, others) Warnings fixed (partial): - Add @param <K>/<V>/<T> to 15 generic classes (Space, LocalSpace, SpaceListener, SpaceInterceptor, TSpace, LSpace, JESpace, JDBMSpace, MDBSpace, TagSequence, TagValue, TagValueBase, EMVTag, BaseSMAdapter, SMAdapter) - Add missing main description to ~70 classes/interfaces (util, space, q2, ui, iso, tlv, emv, transaction packages) Remaining: 100 warnings (no main description x56, @exception/@throws descriptions, missing @throws IOException, misc @param/@return gaps)
1 parent 667151b commit 32c2952

File tree

136 files changed

+360
-248
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

136 files changed

+360
-248
lines changed

.sdkmanrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
java=25.0.1-amzn
2-
gradle=9.2.1
2+
gradle=9.4.0
33

gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.0-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

jpos/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ extraJavaModuleInfo {
1212
automaticModule ('org.apache-extras.beanshell:bsh', 'bsh')
1313
automaticModule ('com.sleepycat:je', 'com.sleepycat.je')
1414
automaticModule ('jdbm:jdbm', 'org.jdbm')
15+
automaticModule ('org.mapdb:mapdb', 'org.mapdb')
1516
}
1617

1718
dependencies {
@@ -32,6 +33,7 @@ dependencies {
3233

3334
implementation libs.yaml;
3435
implementation libs.jdbm
36+
implementation libs.mapdb
3537
implementation libs.sleepycatje
3638
implementation libs.hdrhistogram
3739

jpos/src/main/java/org/jpos/bsh/BSHLogListener.java

Lines changed: 22 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -38,55 +38,37 @@
3838
* can define scripts whose name depends on the event being processed, and the
3939
* realm of the object that generated it.
4040
* This way you can set a configuration like this:
41+
* <pre>{@code
4142
* <log-listener class="org.jpos.bsh.BSHLoglistener">
4243
* <property name="source" value="general.bsh"/>
43-
* <property name="source" value="tag_$tag.bsh"/> <!--this is to handle
44-
* specific tags-->
45-
* <property name="source" value="realm_$realm.bsh"/> <!-- to handle specific
46-
* realms-->
47-
* <property name="source" value="tag_$tag_realm_$realm.bsh"/> <!-- to handle
48-
* specific tags from specific realms-->
44+
* <property name="source" value="tag_$tag.bsh"/>
45+
* <property name="source" value="realm_$realm.bsh"/>
46+
* <property name="source" value="tag_$tag_realm_$realm.bsh"/>
4947
* </log-listener>
50-
* <!-- the following lines are for html doc-->
51-
* <br>
52-
* <pre>
53-
* <font color="#008080">&lt;</font><font color="#008080">log-listener</font><font color="#008080"> </font><font color="#2e8b57"><b>class</b></font>=<font color="#ff00ff">&quot;org.jpos.bsh.BSHLoglistener&quot;</font><font color="#008080">&gt;</font>
54-
* <font color="#008080">&lt;</font><font color="#008080">property</font><font color="#008080"> </font><font color="#2e8b57"><b>name</b></font>=<font color="#ff00ff">&quot;source&quot;</font><font color="#008080"> </font><font color="#2e8b57"><b>value</b></font>=<font color="#ff00ff">&quot;general.bsh&quot;</font><font color="#008080">/&gt;</font>
55-
* <font color="#008080">&lt;</font><font color="#008080">property</font><font color="#008080"> </font><font color="#2e8b57"><b>name</b></font>=<font color="#ff00ff">&quot;source&quot;</font><font color="#008080"> </font><font color="#2e8b57"><b>value</b></font>=<font color="#ff00ff">&quot;tag_$tag.bsh&quot;</font><font color="#008080">/&gt;</font> <font color="#0000ff">&lt;!</font><font color="#0000ff">--this is to handle specific tags--</font><font color="#0000ff">&gt;</font>
56-
* <font color="#008080">&lt;</font><font color="#008080">property</font><font color="#008080"> </font><font color="#2e8b57"><b>name</b></font>=<font color="#ff00ff">&quot;source&quot;</font><font color="#008080"> </font><font color="#2e8b57"><b>value</b></font>=<font color="#ff00ff">&quot;realm_$realm.bsh&quot;</font><font color="#008080">/&gt;</font> <font color="#0000ff">&lt;!</font><font color="#0000ff">-- to handle specific realms--</font><font color="#0000ff">&gt;</font>
57-
* <font color="#008080">&lt;</font><font color="#008080">property</font><font color="#008080"> </font><font color="#2e8b57"><b>name</b></font>=<font color="#ff00ff">&quot;source&quot;</font><font color="#008080"> </font><font color="#2e8b57"><b>value</b></font>=<font color="#ff00ff">&quot;tag_$tag_realm_$realm.bsh&quot;</font><font color="#008080">/&gt;</font> <font color="#0000ff">&lt;!</font><font color="#0000ff">-- to handle specific tags from specific realms--</font><font color="#0000ff">&gt;</font>
58-
* <font color="#008080">&lt;/log-listener&gt;</font>
59-
* </pre>
60-
* <!-- end of lines for html doc-->
48+
* }</pre>
6149
* If a source with the given name is not found, or it canbe read, it is not processed, so this lets
6250
* you change what is processed in real time, if you put a file called
6351
* tag_SystemMonitor_realm_monitor.bsh it will be executed whenever the system
6452
* monitor is run.<BR>
6553
* If you want to filter an event so that the remaining log listeners don't see
6654
* it, you have to set event = null in your script.<br>
67-
* <table border=1 color="black">
68-
* <caption>Other Configuration Options: </caption>
69-
* <th><td> Name </td><td>Type </td><td>Description</td></th>
70-
* <tr><td> filter-by-default </td><td>boolean </td><td>
71-
* If true, filter the events if no script is processed, this way you can put a
72-
* Log Listener that filters every thing unless you put some script file, even if
73-
* it is empty, you also can dynamically change what kind of message are filtered
74-
* by placing empty files with names like tag_SystemMonitor_realm_monitor.bsh in
75-
* the previous example, if you "touch" a file with this name these events will
76-
* begin to be processed.</TD></TR>
77-
* <TR><TD> preload-scripts </TD><TD>boolean </TD><TD>If true scripts a
78-
* loaded once, and kept in memory, being realoaded only if they are touched. This
79-
* is good when you have lots of RAM memory but ou have troubles with
80-
* speed</TD></TR>
81-
* <TR><TD> save-name-space </TD><TD>boolean </TD><TD>If true the namespace
82-
* of the script instance will be saved so that in the next event you can access
83-
* them from the script, by default it's off, this property is overriden if the
84-
* script exposes a boolean variable named saveNameSpace</TD></TR>
85-
* <TR><TD> reload </TD><TD>long </TD><TD>this property is used
86-
* if the preload-script property is true, is the time in milliseconds between
87-
* updates in the script, during this time BSHLogListener will not check if the
88-
* script source was modified or deleted on disk </TD></TR>
89-
* </TABLE>
55+
* <table>
56+
* <caption>Other Configuration Options</caption>
57+
* <thead><tr><th>Name</th><th>Type</th><th>Description</th></tr></thead>
58+
* <tbody>
59+
* <tr><td>{@code filter-by-default}</td><td>boolean</td><td>
60+
* If true, filter the events if no script is processed, so you can dynamically
61+
* control what is logged by placing or removing script files.</td></tr>
62+
* <tr><td>{@code preload-scripts}</td><td>boolean</td><td>
63+
* If true, scripts are loaded once and kept in memory, reloaded only when touched.</td></tr>
64+
* <tr><td>{@code save-name-space}</td><td>boolean</td><td>
65+
* If true, the BeanShell namespace is preserved between events (default: false).
66+
* Overridden by a {@code saveNameSpace} variable in the script.</td></tr>
67+
* <tr><td>{@code reload}</td><td>long</td><td>
68+
* When {@code preload-scripts} is true, the interval in milliseconds between
69+
* script modification checks.</td></tr>
70+
* </tbody>
71+
* </table>
9072
*/
9173
public class BSHLogListener implements org.jpos.util.LogListener, org.jpos.core.Configurable {
9274
/**Holds the configuration for this object*/

jpos/src/main/java/org/jpos/core/SimpleConfiguration.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public SimpleConfiguration (String filename)
4747
}
4848

4949
/**
50-
* Returns the value of the configuration property named <tt>name</tt>, or the default value <tt>def</tt>.
50+
* Returns the value of the configuration property named {@code name}, or the default value {@code def}.
5151
*
5252
* If the property value has the format <code>${xxx}</code> then its value is taken from a system property
5353
* if it exists, or an environment variable. System property takes priority over environment variable.
@@ -57,8 +57,8 @@ public SimpleConfiguration (String filename)
5757
*
5858
* @param name The configuration property key name.
5959
* @param def The default value.
60-
* @return The value stored under <tt>name</tt>,
61-
* or <tt>def</tt> if there's no configuration property under the given <tt>name</tt>.
60+
* @return The value stored under {@code name},
61+
* or {@code def} if there's no configuration property under the given {@code name}.
6262
*/
6363
public String get (String name, String def) {
6464
Object obj = props.get (name);

jpos/src/main/java/org/jpos/core/handlers/exception/ExceptionHandlerAware.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,12 @@
2525
/**
2626
* Interface that modifies an implementing class to add an exception handling pipeline.
2727
*
28-
* <p>
29-
* The main pipeline consists of multiple sub-pipelines:
30-
* <ul>
31-
* <li>A pipeline for which handlers are called regardless of the type of exception handled. Stored under a null key.</li>
32-
* <li>A pipeline per targeted exception type.</li>
33-
* </ul>
34-
* The targeted pipeline always executes before the default pipeline.
35-
* </p>
28+
* The main pipeline consists of multiple sub-pipelines:
29+
* <ul>
30+
* <li>A pipeline for which handlers are called regardless of the type of exception handled. Stored under a null key.</li>
31+
* <li>A pipeline per targeted exception type.</li>
32+
* </ul>
33+
* The targeted pipeline always executes before the default pipeline.
3634
* <p>
3735
* In the event that both of the pipelines are empty, the default behavior is to rethrow the initial exception.
3836
* </p>

jpos/src/main/java/org/jpos/emv/BinaryEMVTag.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424

2525
/**
26+
* An EMV tag whose value is represented as raw binary data.
2627
* @author Vishnu Pillai
2728
*/
2829
public class BinaryEMVTag extends EMVTag<byte[]> {

jpos/src/main/java/org/jpos/emv/EMVStandardTagType.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828

2929
/**
30+
* Enumeration of standard EMV tag types as defined in EMV specifications.
3031
* @author Vishnu Pillai
3132
*/
3233
public enum EMVStandardTagType implements EMVTagType {

jpos/src/main/java/org/jpos/emv/EMVTag.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626

2727

2828
/**
29+
* Abstract base for EMV (Europay/Mastercard/Visa) tag-value pairs.
2930
* @author Vishnu Pillai
31+
32+
* @param <T> the tag value type
3033
*/
3134
public abstract class EMVTag<T> implements TagValue<T>, Serializable {
3235

jpos/src/main/java/org/jpos/emv/EMVTagSequence.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.jpos.tlv.TagSequenceBase;
2323

2424
/**
25+
* An ordered sequence of EMV tag-value elements.
2526
* @author Vishnu Pillai
2627
*/
2728
public class EMVTagSequence extends TagSequenceBase {

0 commit comments

Comments
 (0)