Merge pull request #82 from jprichardson/writefile

Don't write if there is a serialisation error & no callback passed

Author: jprichardson

index.js

@@ -94,7 +94,9 @@ function writeFile (file, obj, options, callback) {
   try {
     str = JSON.stringify(obj, options ? options.replacer : null, spaces) + '\n'
   } catch (err) {
-    if (callback) return callback(err, null)
+    // Need to return whether a callback was passed or not
+    if (callback) callback(err, null)
+    return
   }
 
   fs.writeFile(file, str, options, callback)

test/write-file.test.js

@@ -118,4 +118,22 @@ describe('+ writeFile()', function () {
       })
     })
   })
+
+  // Prevent https://github.com/jprichardson/node-jsonfile/issues/81 from happening
+  describe("> when callback isn't passed & can't serialize", function () {
+    it('should not write an empty file', function (done) {
+      this.slow(1100)
+      var file = path.join(TEST_DIR, 'somefile.json')
+      var obj1 = { name: 'JP' }
+      var obj2 = { person: obj1 }
+      obj1.circular = obj2
+
+      jf.writeFile(file, obj1)
+
+      setTimeout(function () {
+        assert(!fs.existsSync(file))
+        done()
+      }, 1000)
+    })
+  })
 })