Skip to content

Commit 183f0e0

Browse files
committed
Upgrade mocha & standard
Use strict asserts in tests
1 parent 86f924b commit 183f0e0

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
"graceful-fs": "^4.1.6"
2424
},
2525
"devDependencies": {
26-
"mocha": "2.x",
26+
"mocha": "^5.2.0",
2727
"rimraf": "^2.4.0",
28-
"standard": "^10.0.3"
28+
"standard": "^12.0.1"
2929
},
3030
"main": "index.js",
3131
"files": [

test/read-file-sync.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('+ readFileSync()', function () {
2828

2929
try {
3030
var obj2 = jf.readFileSync(file)
31-
assert.equal(obj2.name, obj.name)
31+
assert.strictEqual(obj2.name, obj.name)
3232
} catch (err) {
3333
assert(err)
3434
}
@@ -142,7 +142,7 @@ describe('+ readFileSync()', function () {
142142
var obj = { name: 'JP' }
143143
fs.writeFileSync(file, '\uFEFF' + JSON.stringify(obj))
144144
var data = jf.readFileSync(file)
145-
assert.deepEqual(obj, data)
145+
assert.deepStrictEqual(obj, data)
146146
})
147147
})
148148
})

test/read-file.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('+ readFile()', function () {
2828

2929
jf.readFile(file, function (err, obj2) {
3030
assert.ifError(err)
31-
assert.equal(obj2.name, obj.name)
31+
assert.strictEqual(obj2.name, obj.name)
3232
done()
3333
})
3434
})
@@ -40,7 +40,7 @@ describe('+ readFile()', function () {
4040

4141
jf.readFile(file)
4242
.then((data) => {
43-
assert.equal(data.name, obj.name)
43+
assert.strictEqual(data.name, obj.name)
4444
done()
4545
})
4646
.catch(err => {
@@ -291,15 +291,15 @@ describe('+ readFile()', function () {
291291
it('should properly parse', function (done) {
292292
jf.readFile(file, function (err, data) {
293293
assert.ifError(err)
294-
assert.deepEqual(obj, data)
294+
assert.deepStrictEqual(obj, data)
295295
done()
296296
})
297297
})
298298

299299
it('should resolve the promise with parsed JSON', function (done) {
300300
jf.readFile(file)
301301
.then(data => {
302-
assert.deepEqual(data, obj)
302+
assert.deepStrictEqual(data, obj)
303303
done()
304304
})
305305
.catch(err => {

test/write-file-sync.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ describe('+ writeFileSync()', function () {
2929

3030
var data = fs.readFileSync(file, 'utf8')
3131
var obj2 = JSON.parse(data)
32-
assert.equal(obj2.name, obj.name)
33-
assert.equal(data[data.length - 1], '\n')
34-
assert.equal(data, '{"name":"JP"}\n')
32+
assert.strictEqual(obj2.name, obj.name)
33+
assert.strictEqual(data[data.length - 1], '\n')
34+
assert.strictEqual(data, '{"name":"JP"}\n')
3535
})
3636

3737
describe('> when JSON replacer is set', function () {

test/write-file.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ describe('+ writeFile()', function () {
3030
fs.readFile(file, 'utf8', function (err, data) {
3131
assert.ifError(err)
3232
var obj2 = JSON.parse(data)
33-
assert.equal(obj2.name, obj.name)
33+
assert.strictEqual(obj2.name, obj.name)
3434

3535
// verify EOL
36-
assert.equal(data[data.length - 1], '\n')
36+
assert.strictEqual(data[data.length - 1], '\n')
3737
done()
3838
})
3939
})
@@ -48,10 +48,10 @@ describe('+ writeFile()', function () {
4848
fs.readFile(file, 'utf8', function (err, data) {
4949
assert.ifError(err)
5050
var obj2 = JSON.parse(data)
51-
assert.equal(obj2.name, obj.name)
51+
assert.strictEqual(obj2.name, obj.name)
5252

5353
// verify EOL
54-
assert.equal(data[data.length - 1], '\n')
54+
assert.strictEqual(data[data.length - 1], '\n')
5555
done()
5656
})
5757
})

0 commit comments

Comments
 (0)