full test coverage

Author: jpstroop

TODO.md

@@ -2,10 +2,12 @@
 
 ## TODO
 
-- [ ] Finish method naming and typing documentation.
-
 - [ ] Complete coverage
 
+- [ ] Get rid of deprecation warnings from test coverage
+
+- [ ] Finish method naming and typing documentation.
+
 - [ ] Confront MyPy. See https://stackoverflow.com/a/51294709 for json help
 
 - [ ] When typing resource, wrap the actual response type around the JSONType,,
@@ -19,23 +21,12 @@
 
 - [ ] Set up CI!
 
-- [ ] validate Calories From Fat:
-  `fitbit_client.exceptions.ValidationException: Calories From Fat must be a valid non-negative number. Currently it is "146.79".`
-  It needs to be a positive int!
-
-- [ ] Should mocks have type annotations?
-
-- [ ] consolidate fixures where possible
-
 - [ ] Consider a "replace_food_log" helper that does a delete + an add in one.
   (there might be several of these that make sense--just take an ID and then the
   signature of the "create" method)
 
 - Docs! https://www.sphinx-doc.org/en/master/#get-started (put on github pages?)
 
-- [ ] bring back the aliases! in client.py also put the resource initializations
-  in the mixin
-
 - [ ] Why does this log twice:
 
 ```log
@@ -69,35 +60,18 @@
   https://dev.fitbit.com/build/reference/web-api/developer-guide/best-practices/
   in README--they still apply!
 
-- [ ] Form to chang scopes are part of OAuth flow? Maybe get rid of the cut and
+- [ ] Form to change scopes are part of OAuth flow? Maybe get rid of the cut and
   paste method altogether? It's less to test...
 
-- [ ] Response validation? Accidentally doing a GET instead of a POST on, e.g.
-  `food.json` will yield a response, but not the one you want!
-
 - [ ] Make the food download_food_logs (rename to `get_food_logs`) and food log
   to CSV part of one helper package. It should expand the foods to have their
-  complete nutrition (a separate call for each unique food)
-
-- [ ] Accept "yesterday" keyword for dates?
-
-- [ ] `raise NotImplementedError` for
-  [intraday methods](https://dev.fitbit.com/build/reference/web-api/intraday/)
-
-  - Impelement them and comment them out with a note that they are theoretical
-    unused/untested
-  - Note that they are in Resource classses AND have their own module
-
-- [ ] Figure out throttling when making multiple requests.
-
-  - Can we make this more elegant than just putting in explict `sleep(.3)`
-    statements as needed?
-  - Can we handle it and retry a few times before erroring out?
+  complete nutrition (a separate call for each unique food) (put this in a
+  `tools` package??)
 
 - [ ] PyPI deployment
 
-- [ ] Extension: ?PRIVATE filters on methods that return PUBLIC and PRIVATE
-  stuff (API doesn't seem to have this)
+- [ ] Extension: PRIVATE filters on methods that return PUBLIC and PRIVATE stuff
+  (API doesn't seem to have this). Maybe a sidecar database?
 
 - [ ] Enum for units? (it'll be big, maybe just common ones?)
 

fitbit_client/auth/callback_server.py

@@ -180,12 +180,13 @@ def start(self) -> None:
                     error_type="system",
                 )
 
-        except SystemException:
-            raise
         except Exception as e:
-            error_msg = f"Failed to start callback server: {str(e)}"
-            self.logger.error(error_msg)
-            raise SystemException(message=error_msg, status_code=500, error_type="system")
+            # Only catch non-SystemException exceptions here
+            if not isinstance(e, SystemException):
+                error_msg = f"Failed to start callback server: {str(e)}"
+                self.logger.error(error_msg)
+                raise SystemException(message=error_msg, status_code=500, error_type="system")
+            raise
 
     def wait_for_callback(self, timeout: int = 300) -> Optional[str]:
         """Wait for OAuth callback

fitbit_client/auth/oauth.py

@@ -62,7 +62,7 @@ def __init__(
         token_cache_path: str,
         use_callback_server: bool = True,
     ) -> None:
-        self.logger = getLogger("fitbit_client.oauth")  # Add this line
+        self.logger = getLogger("fitbit_client.oauth")
         self.client_id = client_id
         self.client_secret = client_secret
         self.redirect_uri = redirect_uri

fitbit_client/utils/helpers.py

@@ -24,6 +24,9 @@ def to_camel_case(snake_str: str, cap_first: bool = False) -> str:
         snake_str: a snake_case string
         cap_first: if True, returns CamelCase, otherwise camelCase (default is False)
     """
+    if not snake_str:  # handle empty string case
+        return ""
+
     camel_string = "".join(l.capitalize() for l in snake_str.lower().split("_"))
     if cap_first:
         return camel_string
@@ -33,13 +36,13 @@ def to_camel_case(snake_str: str, cap_first: bool = False) -> str:
 
 def print_json(obj: JSONType, f: TextIO = stdout):
     """
-    Prett print JSON-serializable objects.
+    Pretty print JSON-serializable objects.
 
     Args:
         obj: Any JSON serializable object
         f: A file-like object to which the object should be serialized. Default: stdout
     """
-    print(dumps(obj, ensure_ascii=False, indent=2), file=f)
+    print(dumps(obj, ensure_ascii=False, indent=2), file=f, flush=True)
 
 
 def date_range(start_date: str, end_date: str) -> Iterator[str]:
@@ -67,5 +70,5 @@ def date_range(start_date: str, end_date: str) -> Iterator[str]:
         while start <= end:
             yield start.isoformat()
             start += timedelta(days=1)
-    else:  # Handles start == end
+    else:  # start == end
         yield start.isoformat()

fitbit_client/utils/pagination_validation.py

@@ -16,7 +16,6 @@
 
 
 def validate_pagination_params(
-    *,
     before_field: str = "before_date",
     after_field: str = "after_date",
     sort_field: str = "sort",