full test coverage

Author: jpstroop

fitbit_client/auth/callback_server.py

@@ -180,12 +180,13 @@ def start(self) -> None:
                     error_type="system",
                 )
 
-        except SystemException:
-            raise
         except Exception as e:
-            error_msg = f"Failed to start callback server: {str(e)}"
-            self.logger.error(error_msg)
-            raise SystemException(message=error_msg, status_code=500, error_type="system")
+            # Only catch non-SystemException exceptions here
+            if not isinstance(e, SystemException):
+                error_msg = f"Failed to start callback server: {str(e)}"
+                self.logger.error(error_msg)
+                raise SystemException(message=error_msg, status_code=500, error_type="system")
+            raise
 
     def wait_for_callback(self, timeout: int = 300) -> Optional[str]:
         """Wait for OAuth callback

fitbit_client/auth/oauth.py

@@ -62,7 +62,7 @@ def __init__(
         token_cache_path: str,
         use_callback_server: bool = True,
     ) -> None:
-        self.logger = getLogger("fitbit_client.oauth")  # Add this line
+        self.logger = getLogger("fitbit_client.oauth")
         self.client_id = client_id
         self.client_secret = client_secret
         self.redirect_uri = redirect_uri

fitbit_client/utils/helpers.py

@@ -24,6 +24,9 @@ def to_camel_case(snake_str: str, cap_first: bool = False) -> str:
         snake_str: a snake_case string
         cap_first: if True, returns CamelCase, otherwise camelCase (default is False)
     """
+    if not snake_str:  # handle empty string case
+        return ""
+
     camel_string = "".join(l.capitalize() for l in snake_str.lower().split("_"))
     if cap_first:
         return camel_string
@@ -33,13 +36,13 @@ def to_camel_case(snake_str: str, cap_first: bool = False) -> str:
 
 def print_json(obj: JSONType, f: TextIO = stdout):
     """
-    Prett print JSON-serializable objects.
+    Pretty print JSON-serializable objects.
 
     Args:
         obj: Any JSON serializable object
         f: A file-like object to which the object should be serialized. Default: stdout
     """
-    print(dumps(obj, ensure_ascii=False, indent=2), file=f)
+    print(dumps(obj, ensure_ascii=False, indent=2), file=f, flush=True)
 
 
 def date_range(start_date: str, end_date: str) -> Iterator[str]:
@@ -67,5 +70,5 @@ def date_range(start_date: str, end_date: str) -> Iterator[str]:
         while start <= end:
             yield start.isoformat()
             start += timedelta(days=1)
-    else:  # Handles start == end
+    else:  # start == end
         yield start.isoformat()

fitbit_client/utils/pagination_validation.py

@@ -16,7 +16,6 @@
 
 
 def validate_pagination_params(
-    *,
     before_field: str = "before_date",
     after_field: str = "after_date",
     sort_field: str = "sort",