add warn_unreachable to mypy

Author: jpstroop

fitbit_client/resources/nutrition.py

@@ -61,7 +61,7 @@ def create_food(
         calories: int,
         description: str,
         form_type: FoodFormType,
-        nutritional_values: Dict[NutritionalValue, float],
+        nutritional_values: Dict[NutritionalValue | str, float | int],
         user_id: str = "-",
         debug: bool = False,
     ) -> JSONDict:
@@ -98,11 +98,10 @@ def create_food(
             and NutritionalValue.CALORIES_FROM_FAT in nutritional_values
             and not isinstance(nutritional_values[NutritionalValue.CALORIES_FROM_FAT], int)
         ):
-            raise ValidationException(
+            raise ClientValidationException(
                 message="Calories from fat must be an integer",
-                status_code=400,
-                error_type="validation",
-                field_name="caloriesFromFat",
+                error_type="client_validation",
+                field_name="CALORIES_FROM_FAT",
             )
         # Handle both enum and string nutritional values
         for key, value in nutritional_values.items():

pyproject.toml

@@ -110,35 +110,28 @@ strict_optional = true
 warn_redundant_casts = true
 warn_unused_ignores = true
 warn_no_return = true
-# warn_unreachable = true
+warn_unreachable = true
 # disallow_any_generics = true
 disallow_subclassing_any = true
 disallow_untyped_calls = true
-
-# Show details about error locations
-# show_column_numbers = true
+# output formatting
 show_error_codes = true
 pretty = true
 error_summary = true
 show_error_context = true
-# show_traceback = true
-
 
-# Necessary for most libraries
 [[tool.mypy.overrides]]
 module = [
     "requests.*",
     "requests_oauthlib.*",
-    "pytest.*",
-    "pyOpenSSL.*"
 ]
 ignore_missing_imports = true
 
 
 [tool.pdm.scripts]
 autoflake = { cmd = "autoflake . -r --remove-unused-variables --remove-all-unused-imports --ignore-pass-after-docstring --exclude ./.venv/*,./_scripts/*" }
 headers = { cmd = "python lint/add_file_headers.py" }
-typecheck = { cmd = "mypy --show-error-codes --pretty --no-incremental fitbit_client" }
+mypy = { cmd = "mypy --pretty --no-incremental --warn-unused-configs fitbit_client" }
 black = { cmd = "black ." }
 isort = { cmd = "isort ." }
 mdformat = { cmd = "mdformat ." }

tests/resources/nutrition/test_create_food.py

@@ -6,6 +6,7 @@
 from pytest import raises
 
 # Local imports
+from fitbit_client.exceptions import ClientValidationException
 from fitbit_client.exceptions import ValidationException
 from fitbit_client.resources.constants import FoodFormType
 from fitbit_client.resources.constants import NutritionalValue
@@ -82,7 +83,7 @@ def test_create_food_with_string_nutritional_values(nutrition_resource, mock_res
 
 def test_create_food_calories_from_fat_must_be_integer(nutrition_resource):
     """Test that calories_from_fat must be an integer"""
-    with raises(ValidationException) as exc_info:
+    with raises(ClientValidationException) as exc_info:
         nutrition_resource.create_food(
             name="Test Food",
             default_food_measurement_unit_id=147,
@@ -98,7 +99,6 @@ def test_create_food_calories_from_fat_must_be_integer(nutrition_resource):
         )  # Float instead of integer
 
     # Verify exception details
-    assert exc_info.value.status_code == 400
-    assert exc_info.value.error_type == "validation"
-    assert exc_info.value.field_name == "caloriesFromFat"
+    assert exc_info.value.error_type == "client_validation"
+    assert exc_info.value.field_name == "CALORIES_FROM_FAT"
     assert "Calories from fat must be an integer" in str(exc_info.value)