Refactoring: normalize result.fromResponse() method.

Author: Javen

src/cn/jpush/api/common/BaseResult.java

@@ -28,6 +28,28 @@ public boolean isResultOK() {
         return RESPONSE_OK == responseWrapper.responseCode;
     }
 
+    public static <T extends BaseResult> T fromResponse(
+            ResponseWrapper responseWrapper, Class<T> clazz) {
+        T result = null;
+        
+        if (responseWrapper.isServerResponse()) {
+            result = _gson.fromJson(responseWrapper.responseContent, clazz);
+        } else {
+            try {
+                result = clazz.newInstance();
+            } catch (InstantiationException e) {
+                e.printStackTrace();
+            } catch (IllegalAccessException e) {
+                e.printStackTrace();
+            }
+        }
+        
+        result.setResponseWrapper(responseWrapper);
+        
+        return result;
+    }
+
+    
     @Override
     public int getRateLimitQuota() {
         if (null != responseWrapper) {

src/cn/jpush/api/report/ReportClient.java

@@ -5,6 +5,7 @@
 
 import cn.jpush.api.common.APIConnectionException;
 import cn.jpush.api.common.APIRequestException;
+import cn.jpush.api.common.BaseResult;
 import cn.jpush.api.common.HttpProxy;
 import cn.jpush.api.common.IHttpClient;
 import cn.jpush.api.common.NativeHttpClient;
@@ -75,9 +76,9 @@ public UsersResult getUsers(TimeUnit timeUnit, String start, int duration)
                 + "&start=" + startEncoded + "&duration=" + duration;
         ResponseWrapper response = _httpClient.sendGet(url);
 
-        return UsersResult.fromResponse(response);
+        return BaseResult.fromResponse(response, UsersResult.class);
     }
-        
+    
 
     private final static Pattern MSGID_PATTERNS = Pattern.compile("[^0-9, ]");
 

src/cn/jpush/api/report/UsersResult.java

@@ -4,7 +4,6 @@
 import java.util.List;
 
 import cn.jpush.api.common.BaseResult;
-import cn.jpush.api.common.ResponseWrapper;
 import cn.jpush.api.common.TimeUnit;
 
 import com.google.gson.annotations.Expose;
@@ -36,16 +35,6 @@ public static class Ios {
         @Expose public int active;
     }
 
-	public static UsersResult fromResponse(ResponseWrapper responseWrapper) {
-        UsersResult result = new UsersResult();
-        if (responseWrapper.isServerResponse()) {
-            result = _gson.fromJson(responseWrapper.responseContent, UsersResult.class);
-        }
-        
-        result.setResponseWrapper(responseWrapper);
-        return result;
-	}
-	
 }