MTV-3713: Enhance plan VM table and plan level validations (kubev2v#2123)

Resolves: MTV-3713 | Clarify migration concerns

Signed-off-by: Sharon Gratch <[email protected]>

Author: sgratch

locales/en/plugin__forklift-console-plugin.json

@@ -1,6 +1,5 @@
 {
   " tasks": " tasks",
-  " To troubleshoot, check the <3>Virtual machines tab</3>.": " To troubleshoot, check the <3>Virtual machines tab</3>.",
   ".DiskIndex: initial volume index of the disk": ".DiskIndex: initial volume index of the disk",
   ".FileName: name of the file in the source provider (vmWare only, require guest agent)": ".FileName: name of the file in the source provider (vmWare only, require guest agent)",
   ".NetworkIndex: sequential index of the network interface (0-based)": ".NetworkIndex: sequential index of the network interface (0-based)",
@@ -222,6 +221,8 @@
   "Concern label": "Concern label",
   "Concern type": "Concern type",
   "Concerns": "Concerns",
+  "Concerns (severity)": "Concerns (severity)",
+  "Concerns (type)": "Concerns (type)",
   "Condition": "Condition",
   "Conditions": "Conditions",
   "Conditions not found": "Conditions not found",
@@ -257,6 +258,7 @@
   "Credentials": "Credentials",
   "Critical": "Critical",
   "Critical concerns": "Critical concerns",
+  "critical concerns impacting your migration plan": "critical concerns impacting your migration plan",
   "Critical issues detected in your selected VMs will cause the migration to fail. Resolve these issues or remove the VMs from the plan before starting the migration.": "Critical issues detected in your selected VMs will cause the migration to fail. Resolve these issues or remove the VMs from the plan before starting the migration.",
   "Custom name template": "Custom name template",
   "Cutover": "Cutover",
@@ -395,6 +397,8 @@
   "Filter": "Filter",
   "Filter by {{activeFilterLabel}}": "Filter by {{activeFilterLabel}}",
   "Filter by cluster": "Filter by cluster",
+  "Filter by concerns (severity)": "Filter by concerns (severity)",
+  "Filter by concerns (type)": "Filter by concerns (type)",
   "Filter by critical concerns": "Filter by critical concerns",
   "Filter by description": "Filter by description",
   "Filter by endpoint": "Filter by endpoint",
@@ -472,6 +476,7 @@
   "If you want to keep the VM's static IP address after it has been migrated, check the \"Preserve static IPs\" box. By default, this is set to preserve the IPs. If you want the VM to get a new IP address via DHCP in the target environment, keep this box unchecked.": "If you want to keep the VM's static IP address after it has been migrated, check the \"Preserve static IPs\" box. By default, this is set to preserve the IPs. If you want the VM to get a new IP address via DHCP in the target environment, keep this box unchecked.",
   "Ignore network": "Ignore network",
   "Image": "Image",
+  "Impacted resources": "Impacted resources",
   "In": "In",
   "In live migration, the source virtual machine continues to run until the migration is complete.": "In live migration, the source virtual machine continues to run until the migration is complete.",
   "In warm migration, the VM disks are copied incrementally using changed block tracking (CBT) snapshots.\n          The snapshots are created at one-hour intervals by default.\n          You can change the snapshot interval by updating the forklift-controller deployment.": "In warm migration, the VM disks are copied incrementally using changed block tracking (CBT) snapshots.\n          The snapshots are created at one-hour intervals by default.\n          You can change the snapshot interval by updating the forklift-controller deployment.",
@@ -555,10 +560,12 @@
   "Migrating virtualization workloads is a multi-step process. <2>Learn more</2>.": "Migrating virtualization workloads is a multi-step process. <2>Learn more</2>.",
   "Migrating your virtual machines": "Migrating your virtual machines",
   "Migration": "Migration",
+  "Migration can not start until these critical concerns are resolved.": "Migration can not start until these critical concerns are resolved.",
   "Migration for Virtualization": "Migration for Virtualization",
   "Migration history": "Migration history",
   "Migration network maps are used to map network interfaces between source and target virtualization providers. At least one source and one target provider must be available in order to create a migration network map. <2>Learn more</2>.": "Migration network maps are used to map network interfaces between source and target virtualization providers. At least one source and one target provider must be available in order to create a migration network map. <2>Learn more</2>.",
   "Migration network maps are used to map networks between source and target providers.": "Migration network maps are used to map networks between source and target providers.",
+  "Migration plan concerns": "Migration plan concerns",
   "Migration plan state information and progress": "Migration plan state information and progress",
   "Migration plans": "Migration plans",
   "Migration plans are used to document the moving of virtualization workloads from source providers to target providers.": "Migration plans are used to document the moving of virtualization workloads from source providers to target providers.",
@@ -904,6 +911,7 @@
   "Sets the memory limits allocated to the main container in the controller pod. The default value is 800Mi.": "Sets the memory limits allocated to the main container in the controller pod. The default value is 800Mi.",
   "Settings": "Settings",
   "Settings are applied across all projects on the Migration Toolkit for Virtualization operator.": "Settings are applied across all projects on the Migration Toolkit for Virtualization operator.",
+  "Severity": "Severity",
   "SHA-1 fingerprint": "SHA-1 fingerprint",
   "Shared disks": "Shared disks",
   "Short snapshot polling interval": "Short snapshot polling interval",
@@ -957,7 +965,6 @@
   "Support": "Support",
   "Switch those VMs to cold migration or enable CBT in VMware before running the plan; otherwise the migration will fail.": "Switch those VMs to cold migration or enable CBT in VMware before running the plan; otherwise the migration will fail.",
   "Target and source": "Target and source",
-  "Target name": "Target name",
   "Target network": "Target network",
   "Target network is required for mapping {{index}}.": "Target network is required for mapping {{index}}.",
   "Target power state": "Target power state",
@@ -992,9 +999,7 @@
   "the plan is configured with different hooks for different virtual machines": "the plan is configured with different hooks for different virtual machines",
   "the plan is configured with more then one hook per step": "the plan is configured with more then one hook per step",
   "The plan is currently in progress": "The plan is currently in progress",
-  "The plan is not ready": "The plan is not ready",
   "The plan LUKS decryption keys were manually configured": "The plan LUKS decryption keys were manually configured",
-  "The plan migration might not work as expected": "The plan migration might not work as expected",
   "The plan rootDisk keys was manually configured": "The plan rootDisk keys was manually configured",
   "The pod logs are only available after \"image conversion\". If available, you can view them by expanding the “Migration Resources” section, looking under the “Pod” subheading, and clicking “View logs”.": "The pod logs are only available after \"image conversion\". If available, you can view them by expanding the “Migration Resources” section, looking under the “Pod” subheading, and clicking “View logs”.",
   "The process is designed to reduce the service interruption to a few minutes, or even just seconds, during the final \"cutover\" phase.": "The process is designed to reduce the service interruption to a few minutes, or even just seconds, during the final \"cutover\" phase.",
@@ -1034,7 +1039,6 @@
   "Tips and tricks": "Tips and tricks",
   "To do a warm migration, you must set up VDDK for the selected VMware provider. If VDDK is not set up before starting the migration plan, the migration will fail.": "To do a warm migration, you must set up VDDK for the selected VMware provider. If VDDK is not set up before starting the migration plan, the migration will fail.",
   "To resume, the cutover must be scheduled. When the cutover starts the {{vmCount}} VM{{isPlural}} included in this plan will shut down.": "To resume, the cutover must be scheduled. When the cutover starts the {{vmCount}} VM{{isPlural}} included in this plan will shut down.",
-  "To troubleshoot, check and edit your plan <2>mappings</2>.": "To troubleshoot, check and edit your plan <2>mappings</2>.",
   "To troubleshoot, check the Forklift controller pod logs.": "To troubleshoot, check the Forklift controller pod logs.",
   "To troubleshoot, view the network map details page\n          and check the Forklift controller pod logs.": "To troubleshoot, view the network map details page\n          and check the Forklift controller pod logs.",
   "To troubleshoot, view the provider status available in the provider details page\n          and check the Forklift controller pod logs.": "To troubleshoot, view the provider status available in the provider details page\n          and check the Forklift controller pod logs.",
@@ -1120,7 +1124,9 @@
   "View {{showAll}}{{vmCount}} VM{{isPlural}} in progress": "View {{showAll}}{{vmCount}} VM{{isPlural}} in progress",
   "View {{showAll}}canceled VM{{isPlural}}": "View {{showAll}}canceled VM{{isPlural}}",
   "View {{showAll}}VM{{isPlural}} that cannot start migration": "View {{showAll}}VM{{isPlural}} that cannot start migration",
+  "View all critical concerns": "View all critical concerns",
   "View all plans": "View all plans",
+  "View critical concerns currently impacting your migration plan. All critical concerns must be addressed before the plan can be started.": "View critical concerns currently impacting your migration plan. All critical concerns must be addressed before the plan can be started.",
   "View logs": "View logs",
   "View network map details": "View network map details",
   "View provider details": "View provider details",

src/components/Concerns/VirtualMachineConcernsCell.tsx

@@ -4,33 +4,53 @@ import { TableEmptyCell } from 'src/modules/Providers/utils/components/TableCell
 import type { VmData } from 'src/modules/Providers/views/details/tabs/VirtualMachines/components/VMCellProps';
 import { PROVIDER_TYPES } from 'src/providers/utils/constants';
 
-import type { Concern } from '@kubev2v/types';
+import type { Concern, V1beta1PlanStatusConditions } from '@kubev2v/types';
 import { Split, SplitItem } from '@patternfly/react-core';
 import { isEmpty } from '@utils/helpers';
 
 import ConcernPopover from './components/ConcernsPopover';
-import { groupConcernsByCategory } from './utils/category';
+import {
+  getCategoryLabel,
+  groupConcernsByCategory,
+  groupConditionsByCategory,
+} from './utils/category';
 import { orderedConcernCategories } from './utils/constants';
 
-const VirtualMachineConcernsCell: FC<{ vmData: VmData }> = ({ vmData }) => {
+type VirtualMachineConcernsCellProps = {
+  vmData: VmData;
+  conditions?: V1beta1PlanStatusConditions[];
+};
+
+const VirtualMachineConcernsCell: FC<VirtualMachineConcernsCellProps> = ({
+  conditions,
+  vmData,
+}) => {
   const concerns: Concern[] =
     vmData?.vm?.providerType === PROVIDER_TYPES.openshift ? [] : vmData?.vm?.concerns;
-  if (!concerns || isEmpty(concerns)) {
+  if (isEmpty(concerns) && isEmpty(conditions)) {
     return <TableEmptyCell />;
   }
 
   const groupedConcerns = groupConcernsByCategory(concerns);
+  const groupedConditions = groupConditionsByCategory(conditions);
 
   return (
     <TableCell>
       <Split hasGutter>
         {orderedConcernCategories.map((category) => {
           const hasConcernCategory = concerns?.find((concern) => concern.category === category);
+          const hasConditionCategory = conditions?.find(
+            (condition) => getCategoryLabel(condition.category) === category,
+          );
 
-          if (hasConcernCategory) {
+          if (hasConcernCategory || hasConditionCategory) {
             return (
               <SplitItem key={category}>
-                <ConcernPopover category={category} concerns={groupedConcerns[category] || []} />
+                <ConcernPopover
+                  category={category}
+                  concerns={groupedConcerns[category] || []}
+                  conditions={groupedConditions[category] || []}
+                />
               </SplitItem>
             );
           }

src/components/Concerns/components/ConcernsList.tsx

@@ -1,17 +1,25 @@
 import type { FC } from 'react';
 
-import type { Concern } from '@kubev2v/types';
+import type { Concern, V1beta1PlanStatusConditions } from '@kubev2v/types';
 import { Stack, StackItem } from '@patternfly/react-core';
 
 import { getCategoryIcon } from '../utils/category';
 
-const ConcernList: FC<{ concerns: Concern[] }> = ({ concerns }) => (
+const ConcernList: FC<{ concerns: Concern[]; conditions: V1beta1PlanStatusConditions[] }> = ({
+  concerns,
+  conditions,
+}) => (
   <Stack>
     {concerns.map((concern) => (
       <StackItem key={concern.category}>
         {getCategoryIcon(concern.category)} {concern.label}
       </StackItem>
     ))}
+    {conditions.map((condition) => (
+      <StackItem key={condition.category}>
+        {getCategoryIcon(condition.category)} {condition.message}
+      </StackItem>
+    ))}
   </Stack>
 );
 

src/components/Concerns/components/ConcernsPopover.tsx

@@ -1,6 +1,6 @@
 import type { FC } from 'react';
 
-import type { Concern } from '@kubev2v/types';
+import type { Concern, V1beta1PlanStatusConditions } from '@kubev2v/types';
 import { Button, ButtonVariant, Label, Popover } from '@patternfly/react-core';
 import { isEmpty } from '@utils/helpers';
 import { useForkliftTranslation } from '@utils/i18n';
@@ -12,21 +12,24 @@ import ConcernList from './ConcernsList';
 const ConcernPopover: FC<{
   category: string;
   concerns: Concern[];
-}> = ({ category, concerns }) => {
+  conditions: V1beta1PlanStatusConditions[];
+}> = ({ category, concerns, conditions }) => {
   const { t } = useForkliftTranslation();
 
-  if (isEmpty(concerns)) return null;
+  if (isEmpty(concerns) && isEmpty(conditions)) return null;
+
+  const totalLength = concerns.length + conditions.length;
 
   return (
     <Popover
       aria-label={`${category} popover`}
       headerContent={getCategoryTitle(category)}
-      bodyContent={<ConcernList concerns={concerns} />}
-      footerContent={t('Total: {{length}}', { length: concerns.length })}
+      bodyContent={<ConcernList concerns={concerns} conditions={conditions} />}
+      footerContent={t('Total: {{length}}', { length: totalLength })}
       data-testid="concerns-popover"
     >
       <Button isInline variant={ButtonVariant.link}>
-        <Label status={getCategoryStatus(category)}>{concerns.length}</Label>
+        <Label status={getCategoryStatus(category)}>{totalLength}</Label>
       </Button>
     </Popover>
   );

src/components/Concerns/components/ConcernsTable.tsx

@@ -1,31 +1,42 @@
 import type { ReactNode } from 'react';
 
-import type { Concern } from '@kubev2v/types';
+import type { Concern, V1beta1PlanStatusConditions } from '@kubev2v/types';
 import type { LabelProps } from '@patternfly/react-core';
 import {
   ExclamationCircleIcon,
   ExclamationTriangleIcon,
   InfoCircleIcon,
 } from '@patternfly/react-icons';
+import { isEmpty } from '@utils/helpers';
 import { t } from '@utils/i18n';
 
 import { type ConcernCategory, ConcernCategoryOptions } from './constants';
 
+const CATEGORY_LABELS: Record<ConcernCategory, string> = {
+  [ConcernCategoryOptions.Critical]: 'Critical',
+  [ConcernCategoryOptions.Information]: 'Information',
+  [ConcernCategoryOptions.Warn]: 'Warning',
+  [ConcernCategoryOptions.Warning]: 'Warning',
+};
+
 const CATEGORY_TITLES: Record<ConcernCategory, string> = {
   [ConcernCategoryOptions.Critical]: t('Critical concerns'),
   [ConcernCategoryOptions.Information]: t('Information concerns'),
+  [ConcernCategoryOptions.Warn]: t('Warning concerns'),
   [ConcernCategoryOptions.Warning]: t('Warning concerns'),
 };
 
 const CATEGORY_ICONS: Record<ConcernCategory, ReactNode> = {
   [ConcernCategoryOptions.Critical]: <ExclamationCircleIcon color="#C9190B" />,
   [ConcernCategoryOptions.Information]: <InfoCircleIcon color="#2B9AF3" />,
+  [ConcernCategoryOptions.Warn]: <ExclamationTriangleIcon color="#F0AB00" />,
   [ConcernCategoryOptions.Warning]: <ExclamationTriangleIcon color="#F0AB00" />,
 };
 
 const CATEGORY_STATUS: Record<ConcernCategory, LabelProps['status'] | undefined> = {
   [ConcernCategoryOptions.Critical]: 'danger',
   [ConcernCategoryOptions.Information]: 'info',
+  [ConcernCategoryOptions.Warn]: 'warning',
   [ConcernCategoryOptions.Warning]: 'warning',
 };
 
@@ -44,15 +55,40 @@ export const getCategoryStatus = (category: string): LabelProps['status'] | unde
   return isConcernCategory(category) ? CATEGORY_STATUS[category] : undefined;
 };
 
+export const getCategoryLabel = (category: string): string => {
+  return CATEGORY_LABELS[category as ConcernCategory];
+};
+
 export const groupConcernsByCategory = (
   concerns: Concern[] = [],
 ): Record<ConcernCategory, Concern[]> => {
   return concerns.reduce<Record<string, Concern[]>>(
     (acc, concern) => {
-      if (!acc[concern.category]) {
-        acc[concern.category] = [];
+      if (isEmpty(concern)) return acc;
+      if (isEmpty(acc[concern?.category])) {
+        acc[concern?.category] = [];
+      }
+      acc[concern?.category].push(concern);
+      return acc;
+    },
+    {
+      [ConcernCategoryOptions.Critical]: [],
+      [ConcernCategoryOptions.Information]: [],
+      [ConcernCategoryOptions.Warning]: [],
+    },
+  );
+};
+
+export const groupConditionsByCategory = (
+  conditions: V1beta1PlanStatusConditions[] = [],
+): Record<ConcernCategory, V1beta1PlanStatusConditions[]> => {
+  return conditions.reduce<Record<string, V1beta1PlanStatusConditions[]>>(
+    (acc, condition) => {
+      if (isEmpty(getCategoryLabel(condition?.category))) return acc;
+      if (isEmpty(acc[getCategoryLabel(condition?.category)])) {
+        acc[condition?.category] = [];
       }
-      acc[concern.category].push(concern);
+      acc[getCategoryLabel(condition?.category)].push(condition);
       return acc;
     },
     {