The modifyInstance() function is returning back to the caller when the the instance is not in UP status. So the cache is never updated to the OUT_OF_SERVICE status. This should fix that problem. (#148)

Author: kiranmanda

.gitignore

@@ -29,3 +29,6 @@ node_modules
 lib/
 
 .DS_Store
+
+#IDE
+.idea

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eureka-js-client",
-  "version": "4.4.1",
+  "version": "4.4.2",
   "description": "A JavaScript implementation the Netflix OSS service registry, Eureka.",
   "main": "lib/index.js",
   "scripts": {

src/EurekaClient.js

@@ -484,7 +484,6 @@ export default class Eureka extends EventEmitter {
   }
 
   modifyInstance(cache, instance) {
-    if (!this.validateInstance(instance)) return;
     const vipAddresses = this.splitVipAddress(instance.vipAddress);
     const appName = instance.app.toUpperCase();
     vipAddresses.forEach((vipAddress) => {

test/EurekaClient.test.js

@@ -1178,6 +1178,27 @@ describe('Eureka client', () => {
       expect(client.cache.app.THEAPP[0]).to.have.property('newProp');
     });
 
+    it('should modify instances even when status is not UP', () => {
+      const appDelta = [
+        {
+          instance: [
+            { hostName: '127.0.0.1', port: { $: 1000 }, app: 'THEAPP', vipAddress: 'thevip', status: 'DOWN', actionType: 'MODIFIED', newProp: 'foo' },
+          ],
+        },
+      ];
+      const original = { hostName: '127.0.0.1', port: { $: 1000 }, app: 'THEAPP', vipAddress: 'thevip', status: 'UP', actionType: 'MODIFIED' };
+      client.cache = {
+        app: { THEAPP: [original] },
+        vip: { thevip: [original] },
+      };
+
+      client.handleDelta(client.cache, appDelta);
+      expect(client.cache.vip.thevip).to.have.length(1);
+      expect(client.cache.app.THEAPP).to.have.length(1);
+      expect(client.cache.vip.thevip[0]).to.have.property('newProp');
+      expect(client.cache.app.THEAPP[0]).to.have.property('newProp');
+    });
+
     it('should add if instance doesnt exist when modifying', () => {
       const appDelta = [
         {