Landing a fix for a case where the animation timer wasn't getting stopped (thanks Arrix). Fixes bug jquery#4001.

jeresig · jeresig · commit 7f1eb1c14fdf · 2009-02-13T16:15:23.000Z
diff --git a/src/fx.js b/src/fx.js
@@ -285,7 +285,7 @@ jQuery.fx.prototype = {
 
 		t.elem = this.elem;
 
-		if ( t() && jQuery.timers.push(t) == 1 ) {
+		if ( t() && jQuery.timers.push(t) && !timerId ) {
 			timerId = setInterval(function(){
 				var timers = jQuery.timers;
 
@@ -295,6 +295,7 @@ jQuery.fx.prototype = {
 
 				if ( !timers.length ) {
 					clearInterval( timerId );
+					timerId = undefined;
 				}
 			}, 13);
 		}

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ jQuery.fx.prototype = {`
`285`	`285`
`286`	`286`	`t.elem = this.elem;`
`287`	`287`
`288`		`- if ( t() && jQuery.timers.push(t) == 1 ) {`
	`288`	`+ if ( t() && jQuery.timers.push(t) && !timerId ) {`
`289`	`289`	`timerId = setInterval(function(){`
`290`	`290`	`var timers = jQuery.timers;`
`291`	`291`
`@@ -295,6 +295,7 @@ jQuery.fx.prototype = {`
`295`	`295`
`296`	`296`	`if ( !timers.length ) {`
`297`	`297`	`clearInterval( timerId );`
	`298`	`+ timerId = undefined;`
`298`	`299`	`}`
`299`	`300`	`}, 13);`
`300`	`301`	`}`