Move complexity check to ESLint

Author: ljqx

.eslintrc.json

@@ -12,7 +12,9 @@
     "parserOptions": {
         "sourceType": "script"
     },
+    "plugins": ["esprima-internal"],
     "rules": {
+        "esprima-internal/esprima-complexity": "error",
         "no-case-declarations": "off",
         "no-constant-condition": ["error", { "checkLoops": false }]
     },

eslint/index.js

@@ -0,0 +1,55 @@
+/**
+ * @fileoverview Counts the cyclomatic complexity of each function of the script. See http://en.wikipedia.org/wiki/Cyclomatic_complexity.
+ * Counts the number of if, conditional, for, while, try, but not logical, switch/case,
+ */
+
+"use strict";
+
+const MAX = 24;
+
+module.exports = {
+    rules: {
+        "esprima-complexity": {
+            create(context) {
+                const fns = [];
+
+                function startFunction() {
+                    fns.push(1);
+                }
+
+                function endFunction(node) {
+                    const name = node.id ? node.id.name : `:${node.loc.start.line}`;
+                    const complexity = fns.pop();
+
+                    if (complexity > MAX) {
+                        context.report(node, `${name} has a Cyclomatic complexity of ${complexity}, treshold of ${MAX} is exceeded!`);
+                    }
+                }
+
+                function increaseComplexity() {
+                    if (fns.length) {
+                        fns[fns.length - 1]++;
+                    }
+                }
+
+                return {
+                    FunctionDeclaration: startFunction,
+                    FunctionExpression: startFunction,
+                    ArrowFunctionExpression: startFunction,
+                    "FunctionDeclaration:exit": endFunction,
+                    "FunctionExpression:exit": endFunction,
+                    "ArrowFunctionExpression:exit": endFunction,
+
+                    CatchClause: increaseComplexity,
+                    ConditionalExpression: increaseComplexity,
+                    ForStatement: increaseComplexity,
+                    ForInStatement: increaseComplexity,
+                    ForOfStatement: increaseComplexity,
+                    IfStatement: increaseComplexity,
+                    WhileStatement: increaseComplexity,
+                    DoWhileStatement: increaseComplexity
+                };
+            }
+        }
+    }
+};

eslint/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "eslint-plugin-esprima-internal",
+  "version": "0.0.1",
+  "main": "index.js"
+}

package-lock.json

@@ -38,8 +38,8 @@
     "@typescript-eslint/eslint-plugin": "^2.14.0",
     "@typescript-eslint/parser": "^2.14.0",
     "codecov.io": "~0.1.6",
-    "escomplex-js": "1.2.0",
     "eslint": "^6.8.0",
+    "eslint-plugin-esprima-internal": "file:eslint",
     "everything.js": "~1.0.3",
     "glob": "~7.1.0",
     "istanbul": "~0.4.0",
@@ -68,8 +68,7 @@
     "lint-code": "eslint src/*.ts",
     "code-style": "tsfmt --verify src/*.ts && tsfmt --verify test/*.js",
     "format-code": "tsfmt -r src/*.ts && tsfmt -r test/*.js",
-    "complexity": "node test/check-complexity.js",
-    "static-analysis": "npm run check-version && npm run lint-code && npm run code-style && npm run complexity",
+    "static-analysis": "npm run check-version && npm run lint-code && npm run code-style",
     "hostile-env-tests": "node test/hostile-environment-tests.js",
     "unit-tests": "node test/unit-tests.js",
     "api-tests": "mocha -R dot test/api-tests.js",