Skip to content

Commit 4b207e8

Browse files
staabmjzaefferer
authored andcommitted
Build: Fix building releases on Windows
Single quotes don't work on the Windows command line. See http://stackoverflow.com/a/24181667/2671 for details. Fixes #89 Closes #90
1 parent 8d6c0e8 commit 4b207e8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

lib/cdn.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ module.exports = function( Release ) {
6161
console.log( "Adding files..." );
6262
Release.chdir( targetCdn );
6363
Release.exec( "git add ." , "Error adding files." );
64-
Release.exec( "git commit -m '" + commitMessage + "'" , "Error commiting files." );
64+
Release.exec( "git commit -m \"" + commitMessage + "\"" , "Error commiting files." );
6565
},
6666

6767
_pushToCdn: function() {

lib/git.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module.exports = function( Release ) {
33
Release.define({
44
gitLog: function( format ) {
55
var command = "git log " + Release.prevVersion + ".." + Release.newVersion + " " +
6-
"--format='" + format + "'",
6+
"--format=\"" + format + "\"",
77
result = Release.exec({
88
command: command,
99
silent: true

lib/repo.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ Release.define({
180180
}
181181
} else if ( patch === 0 ) {
182182
Release.prevVersion = Release.exec(
183-
"git for-each-ref --count=1 --sort=-authordate --format='%(refname:short)' " +
183+
"git for-each-ref --count=1 --sort=-authordate --format=\"%(refname:short)\" " +
184184
"refs/tags/" + [ major, minor - 1 ].join( "." ) + "*"
185185
).trim();
186186
} else {
@@ -237,14 +237,14 @@ Release.define({
237237
Release.chdir( Release.dir.repo );
238238
console.log( "Committing release artifacts..." );
239239
Release.exec( "git add -f " + paths.join( " " ), "Error adding release artifacts to git." );
240-
Release.exec( "git commit -m '" + Release.newVersion + "'",
240+
Release.exec( "git commit -m \"" + Release.newVersion + "\"",
241241
"Error committing release changes." );
242242
console.log();
243243

244244
console.log( "Tagging release..." );
245245
Release.exec( "git tag " + Release.newVersion,
246246
"Error tagging " + Release.newVersion + "." );
247-
Release.tagTime = Release.exec( "git log -1 --format='%ad'",
247+
Release.tagTime = Release.exec( "git log -1 --format=\"%ad\"",
248248
"Error getting tag timestamp." ).trim();
249249
},
250250

@@ -268,8 +268,8 @@ Release.define({
268268
Release._versionJSON( "package.json", Release.nextVersion );
269269

270270
console.log( "Committing version update..." );
271-
Release.exec( "git commit -am 'Build: Updating the " + Release.branch +
272-
" version to " + Release.nextVersion + ".'",
271+
Release.exec( "git commit -am \"Build: Updating the " + Release.branch +
272+
" version to " + Release.nextVersion + ".\"",
273273
"Error committing package.json." );
274274
},
275275

0 commit comments

Comments
 (0)