Build: Make isTest skip git commits and expose it as --dry-run

Author: gibson042

README.md

@@ -18,6 +18,8 @@ node release.js --remote=jquery/<project-name>
 
 You can do a test run of the release script by using a different remote repository. **It is recommended to perform tests from a fresh clone of the project being released.** The script is smart enough to detect if you're using an official repository and adjust which actions are taken so that undesired actions, such as publishing to npm, don't occur for test runs.
 
+You can also explicitly specify `--dry-run` to skip actions that affect external state.
+
 When working on features of this script, adapt the following to simplify testing a bit, replacing the paths for `project` and `cdn`:
 
 ```bash
@@ -41,7 +43,7 @@ git push -f
 cd -
 
 npm run clean
-node release.js --remote=$project
+node --dry-run release.js --remote=$project
 ```
 
 You need local clones of [fake-project](https://github.com/jquery/fake-project) and [fake-cdn](https://github.com/jquery/fake-cdn) (private, see note above), then update both variables to point to those.

docs/usage.txt

@@ -1,6 +1,9 @@
-Usage: node release.js [--pre-release=version] [--branch=branch] --remote=repo
+Usage: node release.js [--dry-run] [--pre-release=version] [--branch=branch] --remote=repo
 
 OPTIONS
+	--dry-run
+		Executes in test mode, skipping npm publish and CDN push.
+
 	--pre-release=version
 		Creates a pre-release instead of a stable release. Since the
 		version number can't be determined automatically, it must be

lib/bootstrap.js

@@ -41,6 +41,9 @@ Release.define({
 		Release._parseRemote();
 		Release.branch = Release.args.branch || "master";
 		Release.preRelease = Release.args.preRelease || false;
+		if ( Release.args.dryRun || Release.args.isTest ) {
+			Release.isTest = true;
+		}
 
 		if ( Release.preRelease && !semver.valid( Release.preRelease) ) {
 			Release.abort( "Invalid --pre-release argument, not valid semver: " +
@@ -54,7 +57,7 @@ Release.define({
 		console.log();
 
 		if ( Release.isTest ) {
-			console.log( "This is a test release. npm will not be updated." );
+			console.log( "This is a test release. GitHub and npm will not be updated." );
 		} else {
 			console.log( "This is a real release. GitHub and npm will be updated." );
 		}

lib/cdn.js

@@ -66,7 +66,8 @@ module.exports = function( Release ) {
 
 		_pushToCdn: function() {
 			Release.chdir( projectCdn() );
-			Release.exec( "git push", "Error pushing to CDN." );
+			Release.exec( "git push" + (Release.isTest ? " --dry-run" : ""),
+				"Error pushing to CDN." );
 			console.log();
 		}
 	});

lib/npm.js

@@ -68,26 +68,26 @@ module.exports = function( Release ) {
 
 			Release.chdir( Release.dir.repo );
 
-			var name = Release.readPackage().name,
-				npmTags = Release.npmTags(),
-				npmCommand = "npm publish --tag " + npmTags.pop();
+			var npmPublish,
+				newVersion = Release.readPackage().name + "@" + Release.newVersion,
+				safety = Release.isTest ? " --dry-run" : "",
+				npmTags = Release.npmTags();
 
 			if ( Release.isTest ) {
 				console.log( "Actual release would now publish to npm using:" );
 			} else {
 				console.log( "Publishing to npm, running:" );
 			}
 
-			console.log( "  " + chalk.cyan( npmCommand ) );
-			if ( !Release.isTest ) {
-				Release.exec( npmCommand );
-			}
+			npmPublish = "npm publish" + safety + " --tag " + npmTags.pop();
+			console.log( "  " + chalk.cyan( npmPublish ) );
+			Release.exec( npmPublish );
 
 			while ( npmTags.length ) {
-				npmCommand = "npm dist-tag add " + name + "@" + Release.newVersion + " " + npmTags.pop();
-				console.log( "  " + chalk.cyan( npmCommand ) );
+				npmPublish = "npm dist-tag add " + newVersion + " " + npmTags.pop();
+				console.log( "  " + chalk.cyan( npmPublish ) );
 				if ( !Release.isTest ) {
-					Release.exec( npmCommand );
+					Release.exec( npmPublish );
 				}
 			}
 

lib/repo.js

@@ -255,7 +255,8 @@ Release.define({
 	_pushRelease: function() {
 		Release.chdir( Release.dir.repo );
 		console.log( "Pushing release to git repo..." );
-		Release.exec( "git push --tags", "Error pushing tags to git repo." );
+		Release.exec( "git push" + (Release.isTest ? " --dry-run " : "") + " --tags",
+			"Error pushing tags to git repo." );
 	},
 
 	_updateBranchVersion: function() {
@@ -276,7 +277,8 @@ Release.define({
 	_pushBranch: function() {
 		Release.chdir( Release.dir.repo );
 		console.log( "Pushing " + chalk.cyan( Release.branch ) + " to GitHub..." );
-		Release.exec( "git push", "Error pushing to GitHub." );
+		Release.exec( "git push" + (Release.isTest ? " --dry-run " : ""),
+			"Error pushing to GitHub." );
 	}
 });