fix(browsers): ensuring acknowledgement is only necessary for browserstack

- short and quick selenium runs can send all xhr requests before
  the acknowledger can get lined up to listen for them. This was
  the case with jquery-mousewheel, which has been added in the tests.

Author: timmywil

.gitmodules

@@ -7,3 +7,6 @@
 [submodule "test/jquery-ui"]
 	path = test/jquery-ui
 	url = [email protected]:jquery/jquery-ui.git
+[submodule "test/jquery-mousewheel"]
+	path = test/jquery-mousewheel
+	url = [email protected]:jquery/jquery-mousewheel.git

browsers.js

@@ -103,12 +103,16 @@ export async function createBrowserWorker( url, browser, options, restarts = 0 )
 	worker.browser = browser;
 	worker.restarts = restarts;
 	worker.options = options;
-	touchBrowser( browser );
+
 	workers[ fullBrowser ] = worker;
+	touchBrowser( browser );
 
-	// Wait for the worker to show up in the list
-	// before returning it.
-	return ensureAcknowledged( worker );
+	// Wait for at least one response
+	// from the worker before continuing
+	if ( browserstack ) {
+		await ensureAcknowledged( worker );
+	}
+	return worker;
 }
 
 export function touchBrowser( browser ) {

createTestServer.js

@@ -159,6 +159,7 @@ export async function createTestServer( {
 		".txt": "text/plain",
 		".log": "text/plain"
 	};
+
 	use( async( req, res, next ) => {
 
 		// Allow serving anything but node_modules,

run.js

@@ -80,11 +80,12 @@ export async function run( {
 		quiet: true, // Quiet server logs during test runs
 		testUrls,
 		report: async( message ) => {
+			const reportId = message.id;
+			const report = reports[ reportId ];
+			touchBrowser( report.browser );
+
 			switch ( message.type ) {
 				case "testEnd": {
-					const reportId = message.id;
-					const report = reports[ reportId ];
-					touchBrowser( report.browser );
 					const errorMessage = reportTest( message.data, report );
 					pendingErrors[ reportId ] ??= Object.create( null );
 					if ( errorMessage ) {
@@ -107,18 +108,12 @@ export async function run( {
 					break;
 				}
 				case "error": {
-					const reportId = message.id;
-					const report = reports[ reportId ];
-					touchBrowser( report.browser );
 					const errorMessage = reportError( message.data );
 					pendingErrors[ reportId ] ??= Object.create( null );
 					pendingErrors[ reportId ][ message.data.message ] = errorMessage;
 					break;
 				}
 				case "runEnd": {
-					const reportId = message.id;
-					const report = reports[ reportId ];
-					touchBrowser( report.browser );
 					const { failed, total } = reportEnd( message.data, reports[ reportId ] );
 					report.total = total;
 
@@ -144,11 +139,6 @@ export async function run( {
 					// Run the next test
 					return getNextBrowserTest( reportId );
 				}
-				case "ack": {
-					const report = reports[ message.id ];
-					touchBrowser( report.browser );
-					break;
-				}
 				default:
 					console.warn( "Received unknown message type:", message.type );
 			}
@@ -340,16 +330,16 @@ export async function run( {
 		}
 	} finally {
 		console.log();
-		if ( errorMessages.length === 0 ) {
+		const numErrors = errorMessages.length;
+		if ( numErrors === 0 ) {
 			let stop = false;
 			for ( const report of Object.values( reports ) ) {
 				if ( !report.total ) {
 					stop = true;
 					console.error(
 						chalk.red(
-							`No tests were run with URL "${ report.url }" in ${
-								report.fullBrowser
-							} (${ report.id })`
+							`No tests were run with URL "${ report.url }" ` +
+								`in ${ report.fullBrowser } (${ report.id })`
 						)
 					);
 				}
@@ -363,8 +353,9 @@ export async function run( {
 				gracefulExit( 0 );
 			}
 		} else {
-			const len = errorMessages.length;
-			console.error( chalk.red( `${ len } test${ len > 1 ? "s" : "" } failed.` ) );
+			console.error(
+				chalk.red( `${ numErrors } test${ numErrors > 1 ? "s" : "" } failed.` )
+			);
 			console.log(
 				errorMessages.map( ( error, i ) => `\n${ i + 1 }. ${ error }` ).join( "\n" )
 			);