Skip to content

Commit 98fa74a

Browse files
mgolmgol
committed
All: Drop support for IE & some other browsers (but mostly IE)
1 parent 23b79d3 commit 98fa74a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+238
-690
lines changed

‎demos/autocomplete/maxheight.html

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@
1313
/* prevent horizontal scrollbar */
1414
overflow-x: hidden;
1515
}
16-
/* IE 6 doesn't support max-height
17-
* we use height instead, but this forces the menu to always be this tall
18-
*/
19-
* html .ui-autocomplete {
20-
height: 100px;
21-
}
2216
</style>
2317
<script src="../../external/requirejs/require.js"></script>
2418
<script src="../bootstrap.js">

‎demos/tooltip/custom-style.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,6 @@
6060
width: 25px;
6161
height: 25px;
6262
box-shadow: 6px 5px 9px -9px black;
63-
-webkit-transform: rotate(45deg);
64-
-ms-transform: rotate(45deg);
6563
transform: rotate(45deg);
6664
}
6765
.arrow.top:after {

‎tests/lib/qunit-assert-domequal.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -83,17 +83,6 @@ function getElementStyles( elem ) {
8383
key = style[ len ];
8484
camelKey = camelCase( key );
8585

86-
// Support: IE <=11+
87-
// In IE, `option` elements may have different initial `option` colors.
88-
// They may initially all be transparent, but later the selected
89-
// option gets a blue background with white text; ignore it.
90-
if ( document.documentMode && elem.nodeName.toLowerCase() === "option" && (
91-
camelKey === "color" ||
92-
camelKey.indexOf( "Color" ) === camelKey.length - "Color".length
93-
) ) {
94-
continue;
95-
}
96-
9786
if ( typeof style[ key ] === "string" ) {
9887
styles[ camelKey ] = style[ key ];
9988
}

‎tests/lib/vendor/qunit-composite/qunit-composite.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ function addEvent( elem, type, fn ) {
3535
if ( elem.addEventListener ) {
3636
// Standards-based browsers
3737
elem.addEventListener( type, fn, false );
38-
} else if ( elem.attachEvent ) {
39-
// support: IE <9
40-
elem.attachEvent( "on" + type, fn );
4138
}
4239
}
4340

‎tests/unit/autocomplete/events.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,7 @@ $.each( [
7575
assert.ok( menu.is( ":visible" ), "menu is visible after delay" );
7676
element.simulate( "keydown", { keyCode: $.ui.keyCode.DOWN } );
7777
element.simulate( "keydown", { keyCode: $.ui.keyCode.ENTER } );
78-
79-
// Blur must be async for IE to handle it properly
80-
setTimeout( function() {
81-
element.simulate( "blur" );
82-
} );
78+
element.simulate( "blur" );
8379
} );
8480
} );
8581
} );

‎tests/unit/button/core.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ define( [
22
"qunit",
33
"jquery",
44
"lib/helper",
5-
"ui/safe-active-element",
65
"ui/widgets/button"
76
], function( QUnit, $, helper ) {
87
"use strict";
@@ -17,10 +16,10 @@ QUnit.test( "Disabled button loses focus", function( assert ) {
1716
element.trigger( "focus" );
1817
setTimeout( function() {
1918

20-
assert.equal( element[ 0 ], $.ui.safeActiveElement( document ), "Button is focused" );
19+
assert.equal( element[ 0 ], document.activeElement, "Button is focused" );
2120

2221
element.button( "disable" );
23-
assert.notEqual( element[ 0 ], $.ui.safeActiveElement( document ), "Button has had focus removed" );
22+
assert.notEqual( element[ 0 ], document.activeElement, "Button has had focus removed" );
2423
ready();
2524
} );
2625
} );

‎tests/unit/core/core.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ define( [
33
"jquery",
44
"lib/common",
55
"lib/helper",
6-
"ui/form",
76
"ui/labels",
87
"ui/unique-id"
98
], function( QUnit, $, common, helper ) {
@@ -183,7 +182,7 @@ QUnit.test( "Labels", function( assert ) {
183182
QUnit.test( name + this.id.replace( /_/g, " " ), function( assert ) {
184183
var ready = assert.async();
185184
assert.expect( 1 );
186-
var form = input._form();
185+
var form = $( input.prop( "form" ) );
187186

188187
// If input has a form the value should reset to "" if not it should be "changed"
189188
var value = form.length ? "" : "changed";

‎tests/unit/datepicker/core.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -311,9 +311,6 @@ QUnit.test( "customStructure", function( assert ) {
311311
} );
312312
}
313313

314-
// TODO: figure out why this setTimeout is needed in IE,
315-
// it only is necessary when the previous baseStructure tests runs first
316-
// Support: IE
317314
setTimeout( step1 );
318315
} );
319316

‎tests/unit/datepicker/options.js

Lines changed: 116 additions & 133 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ define( [
55
"ui/widgets/datepicker",
66
"ui/i18n/datepicker-fr",
77
"ui/i18n/datepicker-he",
8-
"ui/i18n/datepicker-zh-CN",
9-
"ui/ie"
8+
"ui/i18n/datepicker-zh-CN"
109
], function( QUnit, $, testHelper ) {
1110
"use strict";
1211

@@ -97,147 +96,131 @@ QUnit.test( "change", function( assert ) {
9796
assert.equal( $.datepicker._defaults.showOn, "focus", "Retain default showOn" );
9897
} );
9998

100-
( function() {
101-
var url = window.location.search;
102-
url = decodeURIComponent( url.slice( url.indexOf( "swarmURL=" ) + 9 ) );
99+
QUnit.test( "invocation", function( assert ) {
100+
var ready = assert.async();
101+
var button, image,
102+
body = $( "body" );
103103

104-
// TODO: This test occassionally fails in IE in TestSwarm
105-
if ( $.ui.ie && url && url.indexOf( "http" ) === 0 ) {
106-
return;
107-
}
104+
assert.expect( 29 );
108105

109-
QUnit.test( "invocation", function( assert ) {
110-
var ready = assert.async();
111-
var button, image,
112-
isOldIE = $.ui.ie && ( !document.documentMode || document.documentMode < 9 ),
113-
body = $( "body" );
114-
115-
assert.expect( isOldIE ? 25 : 29 );
116-
117-
function step0() {
118-
var inp = testHelper.initNewInput(),
119-
dp = $( "#ui-datepicker-div" );
120-
121-
button = inp.siblings( "button" );
122-
assert.ok( button.length === 0, "Focus - button absent" );
123-
image = inp.siblings( "img" );
124-
assert.ok( image.length === 0, "Focus - image absent" );
125-
126-
testHelper.onFocus( inp, function() {
127-
assert.ok( dp.is( ":visible" ), "Focus - rendered on focus" );
128-
inp.simulate( "keydown", { keyCode: $.ui.keyCode.ESCAPE } );
129-
assert.ok( !dp.is( ":visible" ), "Focus - hidden on exit" );
130-
step1();
131-
} );
132-
}
106+
function step0() {
107+
var inp = testHelper.initNewInput(),
108+
dp = $( "#ui-datepicker-div" );
133109

134-
function step1() {
110+
button = inp.siblings( "button" );
111+
assert.ok( button.length === 0, "Focus - button absent" );
112+
image = inp.siblings( "img" );
113+
assert.ok( image.length === 0, "Focus - image absent" );
135114

136-
var inp = testHelper.initNewInput(),
137-
dp = $( "#ui-datepicker-div" );
115+
testHelper.onFocus( inp, function() {
116+
assert.ok( dp.is( ":visible" ), "Focus - rendered on focus" );
117+
inp.simulate( "keydown", { keyCode: $.ui.keyCode.ESCAPE } );
118+
assert.ok( !dp.is( ":visible" ), "Focus - hidden on exit" );
119+
step1();
120+
} );
121+
}
138122

139-
testHelper.onFocus( inp, function() {
140-
assert.ok( dp.is( ":visible" ), "Focus - rendered on focus" );
141-
body.simulate( "mousedown", {} );
142-
assert.ok( !dp.is( ":visible" ), "Focus - hidden on external click" );
143-
inp.datepicker( "hide" ).datepicker( "destroy" );
123+
function step1() {
144124

145-
step2();
146-
} );
147-
}
125+
var inp = testHelper.initNewInput(),
126+
dp = $( "#ui-datepicker-div" );
148127

149-
function step2() {
150-
var inp = testHelper.initNewInput( {
151-
showOn: "button",
152-
buttonText: "Popup"
153-
} ),
154-
dp = $( "#ui-datepicker-div" );
155-
156-
assert.ok( !dp.is( ":visible" ), "Button - initially hidden" );
157-
button = inp.siblings( "button" );
158-
image = inp.siblings( "img" );
159-
assert.ok( button.length === 1, "Button - button present" );
160-
assert.ok( image.length === 0, "Button - image absent" );
161-
assert.equal( button.text(), "Popup", "Button - button text" );
162-
163-
testHelper.onFocus( inp, function() {
164-
assert.ok( !dp.is( ":visible" ), "Button - not rendered on focus" );
165-
button.trigger( "click" );
166-
assert.ok( dp.is( ":visible" ), "Button - rendered on button click" );
167-
button.trigger( "click" );
168-
assert.ok( !dp.is( ":visible" ), "Button - hidden on second button click" );
169-
inp.datepicker( "hide" ).datepicker( "destroy" );
170-
171-
step3();
172-
} );
173-
}
128+
testHelper.onFocus( inp, function() {
129+
assert.ok( dp.is( ":visible" ), "Focus - rendered on focus" );
130+
body.simulate( "mousedown", {} );
131+
assert.ok( !dp.is( ":visible" ), "Focus - hidden on external click" );
132+
inp.datepicker( "hide" ).datepicker( "destroy" );
174133

175-
function step3() {
176-
var inp = testHelper.initNewInput( {
177-
showOn: "button",
178-
buttonImageOnly: true,
179-
buttonImage: "images/calendar.gif",
180-
buttonText: "Cal"
181-
} ),
182-
dp = $( "#ui-datepicker-div" );
183-
184-
assert.ok( !dp.is( ":visible" ), "Image button - initially hidden" );
185-
button = inp.siblings( "button" );
186-
assert.ok( button.length === 0, "Image button - button absent" );
187-
image = inp.siblings( "img" );
188-
assert.ok( image.length === 1, "Image button - image present" );
189-
assert.ok( /images\/calendar\.gif$/.test( image.attr( "src" ) ), "Image button - image source" );
190-
assert.equal( image.attr( "title" ), "Cal", "Image button - image text" );
191-
192-
testHelper.onFocus( inp, function() {
193-
assert.ok( !dp.is( ":visible" ), "Image button - not rendered on focus" );
194-
image.trigger( "click" );
195-
assert.ok( dp.is( ":visible" ), "Image button - rendered on image click" );
196-
image.trigger( "click" );
197-
assert.ok( !dp.is( ":visible" ), "Image button - hidden on second image click" );
198-
inp.datepicker( "hide" ).datepicker( "destroy" );
199-
200-
step4();
201-
} );
202-
}
134+
step2();
135+
} );
136+
}
203137

204-
function step4() {
205-
var inp = testHelper.initNewInput( {
206-
showOn: "both",
207-
buttonImage: "images/calendar.gif"
208-
} ),
209-
dp = $( "#ui-datepicker-div" );
210-
211-
assert.ok( !dp.is( ":visible" ), "Both - initially hidden" );
212-
button = inp.siblings( "button" );
213-
assert.ok( button.length === 1, "Both - button present" );
214-
image = inp.siblings( "img" );
215-
assert.ok( image.length === 0, "Both - image absent" );
216-
image = button.children( "img" );
217-
assert.ok( image.length === 1, "Both - button image present" );
218-
219-
// TODO: This test occasionally fails to focus in IE8 in BrowserStack
220-
if ( !isOldIE ) {
221-
testHelper.onFocus( inp, function() {
222-
assert.ok( dp.is( ":visible" ), "Both - rendered on focus" );
223-
body.simulate( "mousedown", {} );
224-
assert.ok( !dp.is( ":visible" ), "Both - hidden on external click" );
225-
button.trigger( "click" );
226-
assert.ok( dp.is( ":visible" ), "Both - rendered on button click" );
227-
button.trigger( "click" );
228-
assert.ok( !dp.is( ":visible" ), "Both - hidden on second button click" );
229-
inp.datepicker( "hide" ).datepicker( "destroy" );
230-
231-
ready();
232-
} );
233-
} else {
234-
ready();
235-
}
236-
}
138+
function step2() {
139+
var inp = testHelper.initNewInput( {
140+
showOn: "button",
141+
buttonText: "Popup"
142+
} ),
143+
dp = $( "#ui-datepicker-div" );
144+
145+
assert.ok( !dp.is( ":visible" ), "Button - initially hidden" );
146+
button = inp.siblings( "button" );
147+
image = inp.siblings( "img" );
148+
assert.ok( button.length === 1, "Button - button present" );
149+
assert.ok( image.length === 0, "Button - image absent" );
150+
assert.equal( button.text(), "Popup", "Button - button text" );
151+
152+
testHelper.onFocus( inp, function() {
153+
assert.ok( !dp.is( ":visible" ), "Button - not rendered on focus" );
154+
button.trigger( "click" );
155+
assert.ok( dp.is( ":visible" ), "Button - rendered on button click" );
156+
button.trigger( "click" );
157+
assert.ok( !dp.is( ":visible" ), "Button - hidden on second button click" );
158+
inp.datepicker( "hide" ).datepicker( "destroy" );
159+
160+
step3();
161+
} );
162+
}
237163

238-
step0();
239-
} );
240-
} )();
164+
function step3() {
165+
var inp = testHelper.initNewInput( {
166+
showOn: "button",
167+
buttonImageOnly: true,
168+
buttonImage: "images/calendar.gif",
169+
buttonText: "Cal"
170+
} ),
171+
dp = $( "#ui-datepicker-div" );
172+
173+
assert.ok( !dp.is( ":visible" ), "Image button - initially hidden" );
174+
button = inp.siblings( "button" );
175+
assert.ok( button.length === 0, "Image button - button absent" );
176+
image = inp.siblings( "img" );
177+
assert.ok( image.length === 1, "Image button - image present" );
178+
assert.ok( /images\/calendar\.gif$/.test( image.attr( "src" ) ), "Image button - image source" );
179+
assert.equal( image.attr( "title" ), "Cal", "Image button - image text" );
180+
181+
testHelper.onFocus( inp, function() {
182+
assert.ok( !dp.is( ":visible" ), "Image button - not rendered on focus" );
183+
image.trigger( "click" );
184+
assert.ok( dp.is( ":visible" ), "Image button - rendered on image click" );
185+
image.trigger( "click" );
186+
assert.ok( !dp.is( ":visible" ), "Image button - hidden on second image click" );
187+
inp.datepicker( "hide" ).datepicker( "destroy" );
188+
189+
step4();
190+
} );
191+
}
192+
193+
function step4() {
194+
var inp = testHelper.initNewInput( {
195+
showOn: "both",
196+
buttonImage: "images/calendar.gif"
197+
} ),
198+
dp = $( "#ui-datepicker-div" );
199+
200+
assert.ok( !dp.is( ":visible" ), "Both - initially hidden" );
201+
button = inp.siblings( "button" );
202+
assert.ok( button.length === 1, "Both - button present" );
203+
image = inp.siblings( "img" );
204+
assert.ok( image.length === 0, "Both - image absent" );
205+
image = button.children( "img" );
206+
assert.ok( image.length === 1, "Both - button image present" );
207+
208+
testHelper.onFocus( inp, function() {
209+
assert.ok( dp.is( ":visible" ), "Both - rendered on focus" );
210+
body.simulate( "mousedown", {} );
211+
assert.ok( !dp.is( ":visible" ), "Both - hidden on external click" );
212+
button.trigger( "click" );
213+
assert.ok( dp.is( ":visible" ), "Both - rendered on button click" );
214+
button.trigger( "click" );
215+
assert.ok( !dp.is( ":visible" ), "Both - hidden on second button click" );
216+
inp.datepicker( "hide" ).datepicker( "destroy" );
217+
218+
ready();
219+
} );
220+
}
221+
222+
step0();
223+
} );
241224

242225
QUnit.test( "otherMonths", function( assert ) {
243226
assert.expect( 8 );

0 commit comments

Comments
 (0)