Skip to content

Commit de20614

Browse files
committed
Calendar: Make select and change event pass the current value
1 parent b49d12d commit de20614

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

tests/unit/calendar/events.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ QUnit.module( "calendar: events", {
1212
} );
1313

1414
QUnit.test( "change", function( assert ) {
15-
assert.expect( 6 );
15+
assert.expect( 8 );
1616

1717
var shouldFire, eventType;
1818

1919
this.element.calendar( {
20-
change: function( event ) {
20+
change: function( event, ui ) {
2121
assert.ok( shouldFire, "change event fired" );
2222
assert.equal(
2323
event.type,
@@ -29,6 +29,7 @@ QUnit.test( "change", function( assert ) {
2929
eventType,
3030
"change originalEvent on calendar button " + eventType
3131
);
32+
assert.equal( $.type( ui.value ), "date", "value is a date object" );
3233
}
3334
} );
3435

@@ -48,14 +49,14 @@ QUnit.test( "change", function( assert ) {
4849
} );
4950

5051
QUnit.test( "select", function( assert ) {
51-
assert.expect( 6 );
52+
assert.expect( 8 );
5253

5354
var ready = assert.async(),
5455
that = this,
5556
message, eventType;
5657

5758
this.element.calendar( {
58-
select: function( event ) {
59+
select: function( event, ui ) {
5960
assert.ok( true, "select event fired " + message );
6061
assert.equal(
6162
event.type,
@@ -67,6 +68,7 @@ QUnit.test( "select", function( assert ) {
6768
eventType,
6869
"select originalEvent " + message
6970
);
71+
assert.equal( $.type( ui.value ), "date", "value is a date object" );
7072
}
7173
} );
7274

ui/widgets/calendar.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,13 @@ return $.widget( "ui.calendar", {
134134
this._updateDayElement( "ui-state-active" );
135135

136136
// Allow datepicker to handle focus
137-
if ( this._trigger( "select", event ) !== false ) {
137+
if ( this._trigger( "select", event, { value: this.options.value } ) !== false ) {
138138
this.activeDescendant.closest( this.grid ).focus();
139139
event.preventDefault();
140140
}
141141

142142
if ( oldValue !== this.options.value.getTime() ) {
143-
this._trigger( "change", event );
143+
this._trigger( "change", event, { value: this.options.value } );
144144
}
145145
},
146146

0 commit comments

Comments
 (0)