.NET 9 & show features in test's displayname

- Updated to .net 9.
- Changed C# language version to 13.0
- Removed Microsoft.CodeAnalysis.NetAnalyzers package and alwaus using the bundled version.
- Updated all library versions.
- Show on/off features in test's displayname

Author: jr01

.github/workflows/dotnet-core.yml

@@ -10,11 +10,10 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-dotnet@v3
+    - uses: actions/checkout@v4
+    - uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: |
-          8.0.100
+        global-json-file: "./global.json"
     - run: dotnet restore
     - run: dotnet build --configuration Release --no-restore
     - run: dotnet test --no-build --configuration Release --verbosity normal

Directory.Build.props

@@ -4,7 +4,7 @@
       <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
     <PropertyGroup>
-        <LangVersion>12.0</LangVersion>
+        <LangVersion>13.0</LangVersion>
         <Nullable>enable</Nullable>
         <ImplicitUsings>enable</ImplicitUsings>
         <GenerateDocumentationFile>true</GenerateDocumentationFile>

Directory.Build.targets

@@ -1,9 +1,5 @@
 <Project>
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.556">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

global.json

@@ -1,6 +1,9 @@
 {
-  "sdk": {
-    "version": "8.0.100",
-    "rollForward": "latestFeature"
-  }
+    "sdk": {
+        "version": "9.0.100",
+        "rollForward": "latestFeature"
+    },
+    "msbuild-sdks": {
+        "MSTest.Sdk": "3.6.3"
+    }
 }

src/Directory.Build.props

@@ -2,7 +2,7 @@
   <Import Project="..\Directory.Build.props" />
 
   <PropertyGroup>
-    <TargetFrameworks>net8.0</TargetFrameworks>
+    <TargetFrameworks>net9.0</TargetFrameworks>
   </PropertyGroup>
 
   <PropertyGroup>

src/FeatureSwitches.MSTest/FeatureSwitches.MSTest.csproj

@@ -3,14 +3,14 @@
   <PropertyGroup>
     <Description>FeatureSwitches MSTest</Description>
     <PackageId>FeatureSwitches.MSTest</PackageId>
-    <Version>8.0.0</Version>
+    <Version>9.0.0</Version>
   </PropertyGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\FeatureSwitches\FeatureSwitches.csproj" />
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="MSTest.TestFramework" Version="3.0.0" />
+    <PackageReference Include="MSTest.TestFramework" Version="3.6.3" />
   </ItemGroup> 
 </Project>

src/FeatureSwitches.MSTest/FeatureTestMethodAttribute.cs

@@ -18,7 +18,9 @@ public sealed class FeatureTestMethodAttribute : TestMethodAttribute
     /// <param name="onOff">A comma separated string of features to vary between on/off.</param>
     /// <param name="on">A comma separated string of features that are always on.</param>
     /// <param name="off">A comma separated string of features that are always off.</param>
-    public FeatureTestMethodAttribute(string? onOff, string? on = null, string? off = null)
+    /// <param name="displayName">The display name.</param>
+    public FeatureTestMethodAttribute(string? onOff, string? on = null, string? off = null, string? displayName = null)
+        : base(displayName)
     {
         this.OnOff = onOff;
         this.On = on;
@@ -50,7 +52,7 @@ public static IReadOnlyList<FeatureDefinition> GetFeatures(TestContext context)
             return features;
         }
 
-        return Array.Empty<FeatureDefinition>();
+        return [];
     }
 
     public override TestResult[] Execute(ITestMethod testMethod)
@@ -89,16 +91,16 @@ static string[] Convert(string? arg)
 
                 onCombinationValues = onCombinationValues.SelectMany(o =>
                     onValues.Select(onValue =>
-                        o.Concat(new List<FeatureDefinition>
-                        {
+                        o.Concat(
+                        [
                                 new()
                                 {
                                     Name = feature,
                                     IsOn = true,
                                     OffValue = offValue,
                                     OnValue = onValue,
                                 },
-                        })));
+                        ])));
             }
 
             foreach (var onCombinationValue in onCombinationValues)
@@ -121,9 +123,23 @@ static string[] Convert(string? arg)
                 }
 
                 var fullMethodName = testMethod.TestClassName + '/' + testMethod.TestMethodName;
-                ExecutingTestFeatures.TryAdd(fullMethodName, featureDefinitions.OrderBy(x => x.Name).ToList());
+                var sortedFeatures = featureDefinitions.OrderBy(x => x.Name).ToList();
+                ExecutingTestFeatures.TryAdd(fullMethodName, sortedFeatures);
 
                 var result = testMethod.Invoke(null);
+
+                static string GetOnOffValue(object? value)
+                {
+                    return value switch
+                    {
+                        bool b => b ? "on" : "off",
+                        _ => value?.ToString() ?? "null",
+                    };
+                }
+
+                var featureSet = string.Join(", ", sortedFeatures.Select(x => $"{x.Name}: {(x.IsOn ? $"{GetOnOffValue(x.OnValue)}" : $"{GetOnOffValue(x.OffValue)}")}"));
+                result.DisplayName = $"{this.DisplayName ?? testMethod.TestMethodName} ({featureSet})";
+
                 results.Add(result);
 
                 ExecutingTestFeatures.TryRemove(fullMethodName, out _);

src/FeatureSwitches.ServiceCollection/FeatureSwitches.ServiceCollection.csproj

@@ -3,11 +3,11 @@
   <PropertyGroup>
     <Description>ServiceCollection extensions for FeatureSwitches</Description>
     <PackageId>FeatureSwitches.ServiceCollection</PackageId>
-    <Version>8.0.0</Version>
+    <Version>9.0.0</Version>
   </PropertyGroup>
 
   <ItemGroup>
-     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
+     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.0.0" />
   </ItemGroup>
 
   <ItemGroup>

src/FeatureSwitches/Definitions/FeatureDefinition.cs

@@ -25,10 +25,10 @@ public sealed class FeatureDefinition
     /// <summary>
     /// Gets a list of filters.
     /// </summary>
-    public IList<FeatureFilterDefinition> Filters { get; init; } = new List<FeatureFilterDefinition>();
+    public IList<FeatureFilterDefinition> Filters { get; init; } = [];
 
     /// <summary>
     /// Gets a list of filter groups.
     /// </summary>
-    public IList<FeatureFilterGroupDefinition> FilterGroups { get; init; } = new List<FeatureFilterGroupDefinition>();
+    public IList<FeatureFilterGroupDefinition> FilterGroups { get; init; } = [];
 }

src/FeatureSwitches/Definitions/InMemoryFeatureDefinitionProvider.cs

@@ -201,7 +201,7 @@ public void LoadFromJson(string json)
     /// <returns>A list of feature definitions.</returns>
     public IList<FeatureDefinition> Save()
     {
-        return this.featureSwitches.Values.ToList();
+        return [.. this.featureSwitches.Values];
     }
 
     /// <summary>