Skip to content

Commit 55a9e4e

Browse files
committed
get rid of useless log message
we don't have this for the other dialects, even though they all behave similarly
1 parent ec75613 commit 55a9e4e

File tree

3 files changed

+0
-23
lines changed

3 files changed

+0
-23
lines changed

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CockroachLegacyDialect.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55
package org.hibernate.community.dialect;
66

7-
import java.lang.invoke.MethodHandles;
87
import java.sql.DatabaseMetaData;
98
import java.sql.ResultSet;
109
import java.sql.SQLException;
@@ -47,7 +46,6 @@
4746
import org.hibernate.exception.spi.SQLExceptionConversionDelegate;
4847
import org.hibernate.exception.spi.TemplatedViolatedConstraintNameExtractor;
4948
import org.hibernate.exception.spi.ViolatedConstraintNameExtractor;
50-
import org.hibernate.internal.CoreMessageLogger;
5149
import org.hibernate.internal.util.JdbcExceptionHelper;
5250
import org.hibernate.internal.util.StringHelper;
5351
import org.hibernate.query.SemanticException;
@@ -76,7 +74,6 @@
7674
import org.hibernate.type.descriptor.sql.spi.DdlTypeRegistry;
7775
import org.hibernate.type.spi.TypeConfiguration;
7876

79-
import org.jboss.logging.Logger;
8077

8178
import jakarta.persistence.GenerationType;
8279
import jakarta.persistence.TemporalType;
@@ -124,7 +121,6 @@
124121
*/
125122
public class CockroachLegacyDialect extends Dialect {
126123

127-
private static final CoreMessageLogger LOG = Logger.getMessageLogger( MethodHandles.lookup(), CoreMessageLogger.class, CockroachLegacyDialect.class.getName() );
128124
// KNOWN LIMITATIONS:
129125
// * no support for java.sql.Clob
130126

@@ -188,11 +184,6 @@ protected static DatabaseVersion parseVersion(String versionString ) {
188184
}
189185
if ( databaseVersion == null ) {
190186
// Recur to the default version of the no-args constructor
191-
LOG.unableToDetermineCockroachDatabaseVersion(
192-
DEFAULT_VERSION.getDatabaseMajorVersion() + "." +
193-
DEFAULT_VERSION.getDatabaseMinorVersion() + "." +
194-
DEFAULT_VERSION.getDatabaseMicroVersion()
195-
);
196187
databaseVersion = DEFAULT_VERSION;
197188
}
198189
return databaseVersion;

hibernate-core/src/main/java/org/hibernate/dialect/CockroachDialect.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*/
55
package org.hibernate.dialect;
66

7-
import java.lang.invoke.MethodHandles;
87
import java.sql.DatabaseMetaData;
98
import java.sql.ResultSet;
109
import java.sql.SQLException;
@@ -48,7 +47,6 @@
4847
import org.hibernate.exception.spi.SQLExceptionConversionDelegate;
4948
import org.hibernate.exception.spi.TemplatedViolatedConstraintNameExtractor;
5049
import org.hibernate.exception.spi.ViolatedConstraintNameExtractor;
51-
import org.hibernate.internal.CoreMessageLogger;
5250
import org.hibernate.internal.util.StringHelper;
5351
import org.hibernate.internal.util.config.ConfigurationHelper;
5452
import org.hibernate.query.SemanticException;
@@ -77,8 +75,6 @@
7775
import org.hibernate.type.descriptor.sql.spi.DdlTypeRegistry;
7876
import org.hibernate.type.spi.TypeConfiguration;
7977

80-
import org.jboss.logging.Logger;
81-
8278
import jakarta.persistence.GenerationType;
8379
import jakarta.persistence.TemporalType;
8480

@@ -128,7 +124,6 @@
128124
*/
129125
public class CockroachDialect extends Dialect {
130126

131-
private static final CoreMessageLogger LOG = Logger.getMessageLogger( MethodHandles.lookup(), CoreMessageLogger.class, CockroachDialect.class.getName() );
132127
// KNOWN LIMITATIONS:
133128
// * no support for java.sql.Clob
134129

@@ -204,11 +199,6 @@ public static DatabaseVersion parseVersion( String versionString ) {
204199
databaseVersion= new SimpleDatabaseVersion( majorVersion, minorVersion, microVersion);
205200
}
206201
if ( databaseVersion == null ) {
207-
LOG.unableToDetermineCockroachDatabaseVersion(
208-
MINIMUM_VERSION.getDatabaseMajorVersion() + "." +
209-
MINIMUM_VERSION.getDatabaseMinorVersion() + "." +
210-
MINIMUM_VERSION.getDatabaseMicroVersion()
211-
);
212202
databaseVersion = MINIMUM_VERSION;
213203
}
214204
return databaseVersion;

hibernate-core/src/main/java/org/hibernate/internal/CoreMessageLogger.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -699,10 +699,6 @@ void cannotResolveNonNullableTransientDependencies(
699699
@Message(value = "The %2$s version for [%s] is no longer supported, hence certain features may not work properly. The minimum supported version is %3$s. Check the community dialects project for available legacy versions.", id = 511)
700700
void unsupportedDatabaseVersion(String databaseName, String actualVersion, String minimumVersion);
701701

702-
@LogMessage(level = WARN)
703-
@Message(value = "The database version version for the Cockroach Dialect could not be determined. The minimum supported version (%s) has been set instead.", id = 512)
704-
void unableToDetermineCockroachDatabaseVersion(String minimumVersion);
705-
706702
@LogMessage(level = DEBUG)
707703
@Message(value = "Unable to create the ReflectionOptimizer for [%s]: %s",
708704
id = 513)

0 commit comments

Comments
 (0)