Skip to content

Commit 5d5ce3f

Browse files
committed
clean up unused instance variables
1 parent 12e17ed commit 5d5ce3f

File tree

2 files changed

+5
-27
lines changed

2 files changed

+5
-27
lines changed

hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/BootModelPreprocessor.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,10 @@
55
package org.hibernate.boot.jaxb.hbm.transform;
66

77
import java.util.HashMap;
8-
import java.util.List;
98
import java.util.Locale;
109
import java.util.Map;
1110

1211
import org.hibernate.MappingException;
13-
import org.hibernate.boot.jaxb.hbm.spi.JaxbHbmHibernateMapping;
14-
import org.hibernate.boot.jaxb.spi.Binding;
1512
import org.hibernate.boot.spi.MetadataImplementor;
1613
import org.hibernate.mapping.Collection;
1714
import org.hibernate.mapping.Component;
@@ -21,33 +18,27 @@
2118
import org.hibernate.mapping.RootClass;
2219
import org.hibernate.mapping.Table;
2320
import org.hibernate.mapping.ToOne;
24-
import org.hibernate.service.ServiceRegistry;
2521

2622
/**
2723
* @author Steve Ebersole
2824
*/
2925
public class BootModelPreprocessor {
3026
private static final Map<String,String> entityByNameMap = new HashMap<>();
3127

32-
static void preprocessBooModel(
33-
List<Binding<JaxbHbmHibernateMapping>> hbmXmlBindings,
34-
MetadataImplementor bootModel,
35-
ServiceRegistry serviceRegistry,
36-
TransformationState transformationState) {
28+
static void preprocessBooModel(MetadataImplementor bootModel, TransformationState transformationState) {
3729
entityByNameMap.clear();
3830

3931
bootModel.getEntityBindings().forEach( (persistentClass) -> {
4032
final Table table = TransformationHelper.determineEntityTable( persistentClass );
4133
final EntityTypeInfo entityTypeInfo = new EntityTypeInfo( table, persistentClass );
4234
transformationState.getEntityInfoByName().put( persistentClass.getEntityName(), entityTypeInfo );
43-
buildPersistentClassPropertyInfos( persistentClass, entityTypeInfo, bootModel, transformationState );
35+
buildPersistentClassPropertyInfos( persistentClass, entityTypeInfo, transformationState );
4436
} );
4537
}
4638

4739
private static void buildPersistentClassPropertyInfos(
4840
PersistentClass persistentClass,
4941
EntityTypeInfo entityTypeInfo,
50-
MetadataImplementor bootModel,
5142
TransformationState transformationState) {
5243
if ( persistentClass.getClassName() != null ) {
5344
final String previous = entityByNameMap.put( persistentClass.getClassName(), persistentClass.getEntityName() );

hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/HbmXmlTransformer.java

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -231,22 +231,15 @@ public static List<Binding<JaxbEntityMappingsImpl>> transform(
231231
final List<Binding<JaxbEntityMappingsImpl>> transformations = XmlPreprocessor.preprocessHbmXml( hbmXmlBindings, transformationState );
232232

233233
// build and perform a pass over the boot model building the rest of the transformation-state
234-
BootModelPreprocessor.preprocessBooModel(
235-
hbmXmlBindings,
236-
bootModel,
237-
serviceRegistry,
238-
transformationState
239-
);
234+
BootModelPreprocessor.preprocessBooModel( bootModel, transformationState );
240235

241236
// now we are ready to fully build the mapping.xml transformations
242237
for ( int i = 0; i < hbmXmlBindings.size(); i++ ) {
243238
final HbmXmlTransformer hbmXmlTransformer = new HbmXmlTransformer(
244239
hbmXmlBindings.get( i ),
245240
transformations.get( i ),
246241
transformationState,
247-
bootModel,
248-
unsupportedFeatureHandling,
249-
serviceRegistry
242+
unsupportedFeatureHandling
250243
);
251244

252245
hbmXmlTransformer.performTransformation();
@@ -260,10 +253,8 @@ public static List<Binding<JaxbEntityMappingsImpl>> transform(
260253
private final Binding<JaxbEntityMappingsImpl> mappingXmlBinding;
261254

262255
private final TransformationState transformationState;
263-
private final MetadataImplementor bootModel;
264256

265257
private final UnsupportedFeatureHandling unsupportedFeatureHandling;
266-
private final ServiceRegistry serviceRegistry;
267258

268259
// todo (7.0) : use transformation-state instead
269260
private final Map<String,JaxbEmbeddableImpl> jaxbEmbeddableByClassName = new HashMap<>();
@@ -274,15 +265,11 @@ private HbmXmlTransformer(
274265
Binding<JaxbHbmHibernateMapping> hbmXmlBinding,
275266
Binding<JaxbEntityMappingsImpl> mappingXmlBinding,
276267
TransformationState transformationState,
277-
MetadataImplementor bootModel,
278-
UnsupportedFeatureHandling unsupportedFeatureHandling,
279-
ServiceRegistry serviceRegistry) {
268+
UnsupportedFeatureHandling unsupportedFeatureHandling) {
280269
this.hbmXmlBinding = hbmXmlBinding;
281270
this.mappingXmlBinding = mappingXmlBinding;
282271
this.transformationState = transformationState;
283-
this.bootModel = bootModel;
284272
this.unsupportedFeatureHandling = unsupportedFeatureHandling;
285-
this.serviceRegistry = serviceRegistry;
286273
}
287274

288275

0 commit comments

Comments
 (0)