HHH-18271 Avoid query validations of cached queries by doing validation eagerly. Cache allowed result types per query interpretation

Author: beikov

hibernate-core/src/main/java/org/hibernate/query/hql/internal/SemanticQueryBuilder.java

@@ -555,6 +555,7 @@ public SqmInsertStatement<R> visitInsertStatement(HqlParser.InsertStatementConte
 				queryExpressionContext.accept( this );
 
 				insertStatement.onConflict( visitConflictClause( ctx.conflictClause() ) );
+				insertStatement.validate( query );
 				return insertStatement;
 			}
 			finally {
@@ -613,6 +614,7 @@ public SqmInsertStatement<R> visitInsertStatement(HqlParser.InsertStatementConte
 
 				insertStatement.values( valuesList );
 				insertStatement.onConflict( visitConflictClause( ctx.conflictClause() ) );
+				insertStatement.validate( query );
 				return insertStatement;
 			}
 			finally {
@@ -684,6 +686,7 @@ public SqmUpdateStatement<R> visitUpdateStatement(HqlParser.UpdateStatementConte
 				updateStatement.applyPredicate( visitWhereClause( whereClauseContext ) );
 			}
 
+			updateStatement.validate( query );
 			return updateStatement;
 		}
 		finally {

hibernate-core/src/main/java/org/hibernate/query/internal/QueryInterpretationCacheDisabledImpl.java

@@ -19,6 +19,7 @@
 import org.hibernate.query.sql.spi.ParameterInterpretation;
 import org.hibernate.query.sqm.internal.DomainParameterXref;
 import org.hibernate.query.sqm.tree.SqmStatement;
+import org.hibernate.query.sqm.tree.select.SqmSelectStatement;
 import org.hibernate.stat.spi.StatisticsImplementor;
 
 /**
@@ -72,7 +73,7 @@ public <R> HqlInterpretation<R> resolveHqlInterpretation(
 		final DomainParameterXref domainParameterXref;
 		final ParameterMetadataImplementor parameterMetadata;
 		if ( sqmStatement.getSqmParameters().isEmpty() ) {
-			domainParameterXref = DomainParameterXref.empty();
+			domainParameterXref = DomainParameterXref.EMPTY;
 			parameterMetadata = ParameterMetadataImpl.EMPTY;
 		}
 		else {
@@ -101,6 +102,12 @@ public ParameterMetadataImplementor getParameterMetadata() {
 			public DomainParameterXref getDomainParameterXref() {
 				return domainParameterXref;
 			}
+
+			@Override
+			public void validateResultType(Class<?> resultType) {
+				assert sqmStatement instanceof SqmSelectStatement<?>;
+				( (SqmSelectStatement<R>) sqmStatement ).validateResultType( resultType );
+			}
 		};
 	}
 

hibernate-core/src/main/java/org/hibernate/query/internal/QueryInterpretationCacheStandardImpl.java

@@ -147,7 +147,7 @@ protected static <R> HqlInterpretation<R> createHqlInterpretation(
 		final DomainParameterXref domainParameterXref;
 
 		if ( sqmStatement.getSqmParameters().isEmpty() ) {
-			domainParameterXref = DomainParameterXref.empty();
+			domainParameterXref = DomainParameterXref.EMPTY;
 			parameterMetadata = ParameterMetadataImpl.EMPTY;
 		}
 		else {