respect @nonnull annotation on @find method parameters

Author: gavinking

tooling/metamodel-generator/src/jakartaData/java/org/hibernate/processor/test/data/eg/Bookshop.java

@@ -1,5 +1,6 @@
 package org.hibernate.processor.test.data.eg;
 
+import jakarta.annotation.Nonnull;
 import jakarta.data.repository.CrudRepository;
 import jakarta.data.repository.Find;
 import jakarta.data.repository.Query;
@@ -16,17 +17,23 @@ public interface Bookshop extends CrudRepository<Book,String> {
     @Transactional
     List<Book> byPublisher(String publisher_name);
 
+    @Find
+    List<Book> byTitle(@Nonnull String title);
+
     @Query("select isbn where title like ?1 order by isbn")
-    String[] ssns(@NotBlank String title);
+	String[] ssns(@NotBlank String title);
 
     @Query("select count(this) where title like ?1 order by isbn")
     long count1(@NotNull String title);
 
     @Query("select count(this) where this.title like ?1 order by this.isbn")
     long count2(String title);
 
+    @Query("select length(text) where title = ?1")
+    int length(@Nonnull String title);
+
     @Query("select count(this)")
-    long countAll();
+	long countAll();
 
     @Query("where isbn in :isbns and type = Book")
     List<Book> books(List<String> isbns);

tooling/metamodel-generator/src/main/java/org/hibernate/processor/annotation/AnnotationMetaEntity.java

@@ -2131,7 +2131,8 @@ private void parameterTypeError(TypeElement entityType, VariableElement param, T
 
 	private boolean finderParameterNullable(TypeElement entity, VariableElement param) {
 		final Element member = memberMatchingPath( entity, parameterName( param ) );
-		return member == null || isNullable(member);
+		return isNullable( param )
+			&& ( member == null || isNullable( member ) );
 	}
 
 	private AccessType getAccessType(TypeElement entity) {
@@ -2984,30 +2985,29 @@ private static boolean isNullable(Element member) {
 					return false;
 				}
 			case FIELD:
+			case PARAMETER:
 				if ( member.asType().getKind().isPrimitive() ) {
 					return false;
 				}
 		}
-		boolean nullable = true;
 		for ( AnnotationMirror mirror : member.getAnnotationMirrors() ) {
 			final TypeElement annotationType = (TypeElement) mirror.getAnnotationType().asElement();
 			final Name name = annotationType.getQualifiedName();
-			if ( name.contentEquals(Constants.ID) ) {
-				nullable = false;
-			}
-			if ( name.contentEquals("jakarta.validation.constraints.NotNull")) {
-				nullable = false;
+			if ( name.contentEquals(Constants.ID)
+				|| name.contentEquals(Constants.NOT_NULL)
+				|| name.contentEquals(Constants.NONNULL) ) {
+				return false;
 			}
-			if ( name.contentEquals(Constants.BASIC)
+			else if ( name.contentEquals(Constants.BASIC)
 					|| name.contentEquals(Constants.MANY_TO_ONE)
 					|| name.contentEquals(Constants.ONE_TO_ONE)) {
-				AnnotationValue optional = getAnnotationValue(mirror, "optional");
+				final AnnotationValue optional = getAnnotationValue(mirror, "optional");
 				if ( optional != null && optional.getValue().equals(FALSE) ) {
-					nullable = false;
+					return false;
 				}
 			}
 		}
-		return nullable;
+		return true;
 	}
 
 	private void checkParameters(

tooling/metamodel-generator/src/main/java/org/hibernate/processor/util/Constants.java

@@ -131,6 +131,8 @@ public final class Constants {
 	public static final String STREAM = "java.util.stream.Stream";
 
 	public static final String NULLABLE = "jakarta.annotation.Nullable";
+	public static final String NONNULL = "jakarta.annotation.Nonnull";
+	public static final String NOT_NULL = "jakarta.validation.constraints.NotNull";
 
 	public static final String PANACHE_ORM_REPOSITORY_BASE = "io.quarkus.hibernate.orm.panache.PanacheRepositoryBase";
 	public static final String PANACHE_ORM_ENTITY_BASE = "io.quarkus.hibernate.orm.panache.PanacheEntityBase";