HHH-18604 Add json_array_append function

beikov · beikov · commit 8dfc2a5a919b · 2024-09-18T18:43:07.000+02:00
diff --git a/documentation/src/main/asciidoc/userguide/chapters/query/hql/QueryLanguage.adoc b/documentation/src/main/asciidoc/userguide/chapters/query/hql/QueryLanguage.adoc
@@ -1642,6 +1642,7 @@ it is necessary to enable the `hibernate.query.hql.json_functions_enabled` confi
 | `json_set()` | Inserts/Replaces a value by JSON path within a JSON document
 | `json_remove()` | Removes a value by JSON path within a JSON document
 | `json_mergepatch()` | Merges JSON documents by performing an https://tools.ietf.org/html/rfc7396[RFC 7396] compliant merge
+| `json_array_append()` | Appends to a JSON array of a JSON document by JSON path
 |===
 
 
@@ -2113,6 +2114,26 @@ include::{json-example-dir-hql}/JsonMergepatchTest.java[tags=hql-json-mergepatch
 
 WARNING: SAP HANA, DB2, SQL Server, H2 and HSQLDB do not support this function. On PostgreSQL, this function is emulated.
 
+[[hql-json-array-append-function]]
+===== `json_array_append()`
+
+Appends a value by JSON path to a JSON array within a JSON document.
+The function takes 3 arguments, the json document, the json path and the value to append.
+
+If the value within the JSON document as identified by the JSON path is not a JSON array,
+it is auto-wrapped into an array.
+When no value exists for a JSON path, the document is not changed.
+
+[[hql-json-array-append-example]]
+====
+[source, java, indent=0]
+----
+include::{json-example-dir-hql}/JsonArrayAppendTest.java[tags=hql-json-array-append-example]
+----
+====
+
+WARNING: SAP HANA, DB2, H2 and HSQLDB do not support this function.
+
 [[hql-user-defined-functions]]
 ==== Native and user-defined functions
 
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CockroachLegacyDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/CockroachLegacyDialect.java
@@ -513,6 +513,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		functionFactory.jsonReplace_postgresql();
 		functionFactory.jsonInsert_postgresql();
 		functionFactory.jsonMergepatch_postgresql();
+		functionFactory.jsonArrayAppend_postgresql();
 
 		// Postgres uses # instead of ^ for XOR
 		functionContributions.getFunctionRegistry().patternDescriptorBuilder( "bitxor", "(?1#?2)" )
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MariaDBLegacyDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MariaDBLegacyDialect.java
@@ -95,6 +95,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 			commonFunctionFactory.jsonQuery_mariadb();
 			commonFunctionFactory.jsonArrayAgg_mariadb();
 			commonFunctionFactory.jsonObjectAgg_mariadb();
+			commonFunctionFactory.jsonArrayAppend_mariadb();
 			if ( getVersion().isSameOrAfter( 10, 3, 3 ) ) {
 				commonFunctionFactory.inverseDistributionOrderedSetAggregates_windowEmulation();
 				functionContributions.getFunctionRegistry().patternDescriptorBuilder( "median", "median(?1) over ()" )
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacyDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacyDialect.java
@@ -665,6 +665,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 			functionFactory.jsonReplace_mysql();
 			functionFactory.jsonInsert_mysql();
 			functionFactory.jsonMergepatch_mysql();
+			functionFactory.jsonArrayAppend_mysql();
 		}
 	}
 
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacyDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/OracleLegacyDialect.java
@@ -322,6 +322,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 			functionFactory.jsonReplace_oracle();
 			functionFactory.jsonInsert_oracle();
 			functionFactory.jsonMergepatch_oracle();
+			functionFactory.jsonArrayAppend_oracle();
 		}
 	}
 
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/PostgreSQLLegacyDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/PostgreSQLLegacyDialect.java
@@ -663,6 +663,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		functionFactory.jsonReplace_postgresql();
 		functionFactory.jsonInsert_postgresql();
 		functionFactory.jsonMergepatch_postgresql();
+		functionFactory.jsonArrayAppend_postgresql();
 
 		if ( getVersion().isSameOrAfter( 9, 4 ) ) {
 			functionFactory.makeDateTimeTimestamp();
diff --git a/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLServerLegacyDialect.java b/hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLServerLegacyDialect.java
@@ -410,6 +410,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 			functionFactory.jsonRemove_sqlserver();
 			functionFactory.jsonReplace_sqlserver();
 			functionFactory.jsonInsert_sqlserver();
+			functionFactory.jsonArrayAppend_sqlserver();
 		}
 		if ( getVersion().isSameOrAfter( 14 ) ) {
 			functionFactory.listagg_stringAggWithinGroup( "varchar(max)" );
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/CockroachDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/CockroachDialect.java
@@ -480,6 +480,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		functionFactory.jsonReplace_postgresql();
 		functionFactory.jsonInsert_postgresql();
 		functionFactory.jsonMergepatch_postgresql();
+		functionFactory.jsonArrayAppend_postgresql();
 
 		// Postgres uses # instead of ^ for XOR
 		functionContributions.getFunctionRegistry().patternDescriptorBuilder( "bitxor", "(?1#?2)" )
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/MariaDBDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/MariaDBDialect.java
@@ -98,6 +98,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		commonFunctionFactory.jsonQuery_mariadb();
 		commonFunctionFactory.jsonArrayAgg_mariadb();
 		commonFunctionFactory.jsonObjectAgg_mariadb();
+		commonFunctionFactory.jsonArrayAppend_mariadb();
 		commonFunctionFactory.inverseDistributionOrderedSetAggregates_windowEmulation();
 		functionContributions.getFunctionRegistry().patternDescriptorBuilder( "median", "median(?1) over ()" )
 				.setInvariantType( functionContributions.getTypeConfiguration().getBasicTypeRegistry().resolve( StandardBasicTypes.DOUBLE ) )
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/MySQLDialect.java
@@ -650,6 +650,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		functionFactory.jsonReplace_mysql();
 		functionFactory.jsonInsert_mysql();
 		functionFactory.jsonMergepatch_mysql();
+		functionFactory.jsonArrayAppend_mysql();
 	}
 
 	@Override
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/OracleDialect.java
@@ -413,6 +413,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		functionFactory.jsonReplace_oracle();
 		functionFactory.jsonInsert_oracle();
 		functionFactory.jsonMergepatch_oracle();
+		functionFactory.jsonArrayAppend_oracle();
 	}
 
 	@Override
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/PostgreSQLDialect.java
@@ -624,6 +624,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 		functionFactory.jsonReplace_postgresql();
 		functionFactory.jsonInsert_postgresql();
 		functionFactory.jsonMergepatch_postgresql();
+		functionFactory.jsonArrayAppend_postgresql();
 
 		functionFactory.makeDateTimeTimestamp();
 		// Note that PostgreSQL doesn't support the OVER clause for ordered set-aggregate functions
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/SQLServerDialect.java b/hibernate-core/src/main/java/org/hibernate/dialect/SQLServerDialect.java
@@ -428,6 +428,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio
 			functionFactory.jsonRemove_sqlserver();
 			functionFactory.jsonReplace_sqlserver();
 			functionFactory.jsonInsert_sqlserver();
+			functionFactory.jsonArrayAppend_sqlserver();
 		}
 		if ( getVersion().isSameOrAfter( 14 ) ) {
 			functionFactory.listagg_stringAggWithinGroup( "varchar(max)" );
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/function/CommonFunctionFactory.java b/hibernate-core/src/main/java/org/hibernate/dialect/function/CommonFunctionFactory.java
@@ -103,6 +103,7 @@
 import org.hibernate.dialect.function.json.JsonQueryFunction;
 import org.hibernate.dialect.function.json.JsonValueFunction;
 import org.hibernate.dialect.function.json.MariaDBJsonArrayAggFunction;
+import org.hibernate.dialect.function.json.MariaDBJsonArrayAppendFunction;
 import org.hibernate.dialect.function.json.MariaDBJsonArrayFunction;
 import org.hibernate.dialect.function.json.MariaDBJsonObjectAggFunction;
 import org.hibernate.dialect.function.json.MariaDBJsonQueryFunction;
@@ -115,6 +116,7 @@
 import org.hibernate.dialect.function.json.MySQLJsonQueryFunction;
 import org.hibernate.dialect.function.json.MySQLJsonValueFunction;
 import org.hibernate.dialect.function.json.OracleJsonArrayAggFunction;
+import org.hibernate.dialect.function.json.OracleJsonArrayAppendFunction;
 import org.hibernate.dialect.function.json.OracleJsonArrayFunction;
 import org.hibernate.dialect.function.json.OracleJsonInsertFunction;
 import org.hibernate.dialect.function.json.OracleJsonMergepatchFunction;
@@ -124,6 +126,7 @@
 import org.hibernate.dialect.function.json.OracleJsonReplaceFunction;
 import org.hibernate.dialect.function.json.OracleJsonSetFunction;
 import org.hibernate.dialect.function.json.PostgreSQLJsonArrayAggFunction;
+import org.hibernate.dialect.function.json.PostgreSQLJsonArrayAppendFunction;
 import org.hibernate.dialect.function.json.PostgreSQLJsonArrayFunction;
 import org.hibernate.dialect.function.json.PostgreSQLJsonExistsFunction;
 import org.hibernate.dialect.function.json.PostgreSQLJsonInsertFunction;
@@ -136,6 +139,7 @@
 import org.hibernate.dialect.function.json.PostgreSQLJsonSetFunction;
 import org.hibernate.dialect.function.json.PostgreSQLJsonValueFunction;
 import org.hibernate.dialect.function.json.SQLServerJsonArrayAggFunction;
+import org.hibernate.dialect.function.json.SQLServerJsonArrayAppendFunction;
 import org.hibernate.dialect.function.json.SQLServerJsonArrayFunction;
 import org.hibernate.dialect.function.json.SQLServerJsonExistsFunction;
 import org.hibernate.dialect.function.json.SQLServerJsonInsertFunction;
@@ -4007,4 +4011,49 @@ public void jsonMergepatch_mysql() {
 	public void jsonMergepatch_oracle() {
 		functionRegistry.register( "json_mergepatch", new OracleJsonMergepatchFunction( typeConfiguration ) );
 	}
+
+	/**
+	 * PostgreSQL json_array_append() function
+	 */
+	public void jsonArrayAppend_postgresql() {
+		functionRegistry.register( "json_array_append", new PostgreSQLJsonArrayAppendFunction( typeConfiguration ) );
+	}
+
+	/**
+	 * MySQL json_array_append() function
+	 */
+	public void jsonArrayAppend_mysql() {
+		functionRegistry.namedDescriptorBuilder( "json_array_append" )
+				.setArgumentsValidator( new ArgumentTypesValidator(
+						StandardArgumentsValidators.exactly( 3 ),
+						FunctionParameterType.IMPLICIT_JSON,
+						FunctionParameterType.STRING,
+						FunctionParameterType.ANY
+				) )
+				.setReturnTypeResolver( StandardFunctionReturnTypeResolvers.invariant(
+						typeConfiguration.getBasicTypeRegistry().resolve( String.class, SqlTypes.JSON )
+				) )
+				.register();
+	}
+
+	/**
+	 * MariaDB json_array_append() function
+	 */
+	public void jsonArrayAppend_mariadb() {
+		functionRegistry.register( "json_array_append", new MariaDBJsonArrayAppendFunction( typeConfiguration ) );
+	}
+
+	/**
+	 * Oracle json_array_append() function
+	 */
+	public void jsonArrayAppend_oracle() {
+		functionRegistry.register( "json_array_append", new OracleJsonArrayAppendFunction( typeConfiguration ) );
+	}
+
+	/**
+	 * SQL server json_array_append() function
+	 */
+	public void jsonArrayAppend_sqlserver() {
+		functionRegistry.register( "json_array_append", new SQLServerJsonArrayAppendFunction( typeConfiguration ) );
+	}
 }
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/function/json/AbstractJsonArrayAppendFunction.java b/hibernate-core/src/main/java/org/hibernate/dialect/function/json/AbstractJsonArrayAppendFunction.java
@@ -0,0 +1,38 @@
+/*
+ * SPDX-License-Identifier: LGPL-2.1-or-later
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.dialect.function.json;
+
+import org.hibernate.query.sqm.function.AbstractSqmSelfRenderingFunctionDescriptor;
+import org.hibernate.query.sqm.function.FunctionKind;
+import org.hibernate.query.sqm.produce.function.ArgumentTypesValidator;
+import org.hibernate.query.sqm.produce.function.FunctionParameterType;
+import org.hibernate.query.sqm.produce.function.StandardArgumentsValidators;
+import org.hibernate.query.sqm.produce.function.StandardFunctionReturnTypeResolvers;
+import org.hibernate.type.SqlTypes;
+import org.hibernate.type.spi.TypeConfiguration;
+
+/**
+ * Standard json_array_append function.
+ */
+public abstract class AbstractJsonArrayAppendFunction extends AbstractSqmSelfRenderingFunctionDescriptor {
+
+	public AbstractJsonArrayAppendFunction(TypeConfiguration typeConfiguration) {
+		super(
+				"json_array_append",
+				FunctionKind.NORMAL,
+				new ArgumentTypesValidator(
+						StandardArgumentsValidators.exactly( 3 ),
+						FunctionParameterType.IMPLICIT_JSON,
+						FunctionParameterType.STRING,
+						FunctionParameterType.ANY
+				),
+				StandardFunctionReturnTypeResolvers.invariant(
+						typeConfiguration.getBasicTypeRegistry().resolve( String.class, SqlTypes.JSON )
+				),
+				null
+		);
+	}
+
+}
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/function/json/MariaDBJsonArrayAppendFunction.java b/hibernate-core/src/main/java/org/hibernate/dialect/function/json/MariaDBJsonArrayAppendFunction.java
@@ -0,0 +1,47 @@
+/*
+ * SPDX-License-Identifier: LGPL-2.1-or-later
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.dialect.function.json;
+
+import java.util.List;
+
+import org.hibernate.query.ReturnableType;
+import org.hibernate.sql.ast.SqlAstTranslator;
+import org.hibernate.sql.ast.spi.SqlAppender;
+import org.hibernate.sql.ast.tree.SqlAstNode;
+import org.hibernate.sql.ast.tree.expression.Expression;
+import org.hibernate.type.spi.TypeConfiguration;
+
+/**
+ * MariaDB json_array_append function.
+ */
+public class MariaDBJsonArrayAppendFunction extends AbstractJsonArrayAppendFunction {
+
+	public MariaDBJsonArrayAppendFunction(TypeConfiguration typeConfiguration) {
+		super( typeConfiguration );
+	}
+
+	@Override
+	public void render(
+			SqlAppender sqlAppender,
+			List<? extends SqlAstNode> arguments,
+			ReturnableType<?> returnType,
+			SqlAstTranslator<?> translator) {
+		final Expression json = (Expression) arguments.get( 0 );
+		final Expression jsonPath = (Expression) arguments.get( 1 );
+		final SqlAstNode value = arguments.get( 2 );
+		sqlAppender.appendSql( "json_replace(" );
+		json.accept( translator );
+		sqlAppender.appendSql( ',' );
+		jsonPath.accept( translator );
+		sqlAppender.appendSql( ",json_merge(json_extract(" );
+		json.accept( translator );
+		sqlAppender.appendSql( ',' );
+		jsonPath.accept( translator );
+		sqlAppender.appendSql( "),json_array(" );
+		value.accept( translator );
+		sqlAppender.appendSql( ")))" );
+
+	}
+}
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/function/json/OracleJsonArrayAppendFunction.java b/hibernate-core/src/main/java/org/hibernate/dialect/function/json/OracleJsonArrayAppendFunction.java
@@ -0,0 +1,59 @@
+/*
+ * SPDX-License-Identifier: LGPL-2.1-or-later
+ * Copyright Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate.dialect.function.json;
+
+import java.util.List;
+
+import org.hibernate.query.ReturnableType;
+import org.hibernate.sql.ast.SqlAstTranslator;
+import org.hibernate.sql.ast.spi.SqlAppender;
+import org.hibernate.sql.ast.tree.SqlAstNode;
+import org.hibernate.sql.ast.tree.expression.Expression;
+import org.hibernate.type.spi.TypeConfiguration;
+
+/**
+ * Oracle json_array_append function.
+ */
+public class OracleJsonArrayAppendFunction extends AbstractJsonArrayAppendFunction {
+
+	public OracleJsonArrayAppendFunction(TypeConfiguration typeConfiguration) {
+		super( typeConfiguration );
+	}
+
+	@Override
+	public void render(
+			SqlAppender sqlAppender,
+			List<? extends SqlAstNode> arguments,
+			ReturnableType<?> returnType,
+			SqlAstTranslator<?> translator) {
+		final Expression json = (Expression) arguments.get( 0 );
+		final String jsonPath = translator.getLiteralValue( (Expression) arguments.get( 1 ) );
+		final SqlAstNode value = arguments.get( 2 );
+		sqlAppender.appendSql( "(select case coalesce(json_value(t.d,'" );
+		for ( int i = 0; i < jsonPath.length(); i++ ) {
+			final char c = jsonPath.charAt( i );
+			if ( c == '\'') {
+				sqlAppender.appendSql( "'" );
+			}
+			sqlAppender.appendSql( c );
+		}
+		sqlAppender.appendSql( ".type()'),'x') when 'x' then t.d when 'array' then json_transform(t.d,append " );
+		sqlAppender.appendSingleQuoteEscapedString( jsonPath );
+		sqlAppender.appendSql( "=t.v) when 'object' then json_transform(t.d,set " );
+		sqlAppender.appendSingleQuoteEscapedString( jsonPath );
+		sqlAppender.appendSql( "=json_array(coalesce(json_query(t.d," );
+		sqlAppender.appendSingleQuoteEscapedString( jsonPath );
+		sqlAppender.appendSql( "),'null') format json,t.v)) else json_transform(t.d,set " );
+		sqlAppender.appendSingleQuoteEscapedString( jsonPath );
+		sqlAppender.appendSql( "=json_array(coalesce(json_value(t.d," );
+		sqlAppender.appendSingleQuoteEscapedString( jsonPath );
+		sqlAppender.appendSql( "),'null') format json,t.v)) end from (select " );
+		json.accept( translator );
+		sqlAppender.appendSql( " d," );
+		value.accept( translator );
+		sqlAppender.appendSql( " v from dual) t)" );
+
+	}
+}
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/function/json/PostgreSQLJsonArrayAppendFunction.java b/hibernate-core/src/main/java/org/hibernate/dialect/function/json/PostgreSQLJsonArrayAppendFunction.java
diff --git a/hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonArrayAppendFunction.java b/hibernate-core/src/main/java/org/hibernate/dialect/function/json/SQLServerJsonArrayAppendFunction.java
diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/function/json/JsonArrayAppendTest.java b/hibernate-core/src/test/java/org/hibernate/orm/test/function/json/JsonArrayAppendTest.java
diff --git a/hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/JsonFunctionTests.java b/hibernate-core/src/test/java/org/hibernate/orm/test/query/hql/JsonFunctionTests.java
diff --git a/hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java b/hibernate-testing/src/main/java/org/hibernate/testing/orm/junit/DialectFeatureChecks.java

Original file line number	Diff line number	Diff line change
`@@ -665,6 +665,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio`
`665`	`665`	`functionFactory.jsonReplace_mysql();`
`666`	`666`	`functionFactory.jsonInsert_mysql();`
`667`	`667`	`functionFactory.jsonMergepatch_mysql();`
	`668`	`+ functionFactory.jsonArrayAppend_mysql();`
`668`	`669`	`}`
`669`	`670`	`}`
`670`	`671`
Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio`
`322`	`322`	`functionFactory.jsonReplace_oracle();`
`323`	`323`	`functionFactory.jsonInsert_oracle();`
`324`	`324`	`functionFactory.jsonMergepatch_oracle();`
	`325`	`+ functionFactory.jsonArrayAppend_oracle();`
`325`	`326`	`}`
`326`	`327`	`}`
`327`	`328`
Original file line number	Diff line number	Diff line change
`@@ -410,6 +410,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio`
`410`	`410`	`functionFactory.jsonRemove_sqlserver();`
`411`	`411`	`functionFactory.jsonReplace_sqlserver();`
`412`	`412`	`functionFactory.jsonInsert_sqlserver();`
	`413`	`+ functionFactory.jsonArrayAppend_sqlserver();`
`413`	`414`	`}`
`414`	`415`	`if ( getVersion().isSameOrAfter( 14 ) ) {`
`415`	`416`	`functionFactory.listagg_stringAggWithinGroup( "varchar(max)" );`
Original file line number	Diff line number	Diff line change
`@@ -650,6 +650,7 @@ public void initializeFunctionRegistry(FunctionContributions functionContributio`
`650`	`650`	`functionFactory.jsonReplace_mysql();`
`651`	`651`	`functionFactory.jsonInsert_mysql();`
`652`	`652`	`functionFactory.jsonMergepatch_mysql();`
	`653`	`+ functionFactory.jsonArrayAppend_mysql();`
`653`	`654`	`}`
`654`	`655`
`655`	`656`	`@Override`