Skip to content

Commit 94515e6

Browse files
committed
cleanup some typing-related compiler warnings
1 parent 5e07b85 commit 94515e6

File tree

5 files changed

+12
-23
lines changed

5 files changed

+12
-23
lines changed

hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/FileXmlSource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ public FileXmlSource(Origin origin, File file) {
2626
}
2727

2828
@Override
29-
public Binding doBind(Binder binder) {
29+
public <T> Binding<T> doBind(Binder<T> binder) {
3030
return doBind( binder, file, getOrigin() );
3131
}
3232

33-
public static Binding doBind(Binder binder, File file, Origin origin) {
33+
public static <T> Binding<T> doBind(Binder<T> binder, File file, Origin origin) {
3434
final FileInputStream fis;
3535
try {
3636
fis = new FileInputStream( file );

hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/InputStreamXmlSource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ public InputStreamXmlSource(Origin origin, InputStream inputStream, boolean auto
3232
}
3333

3434
@Override
35-
public Binding doBind(Binder binder) {
35+
public <T> Binding<T> doBind(Binder<T> binder) {
3636
return doBind( binder, inputStream, getOrigin(), autoClose );
3737
}
3838

39-
public static Binding doBind(Binder binder, InputStream inputStream, Origin origin, boolean autoClose) {
39+
public static <T> Binding<T> doBind(Binder<T> binder, InputStream inputStream, Origin origin, boolean autoClose) {
4040
try {
4141
return binder.bind( inputStream, origin );
4242
}

hibernate-core/src/main/java/org/hibernate/boot/jaxb/internal/UrlXmlSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public UrlXmlSource(Origin origin, URL url) {
2929
}
3030

3131
@Override
32-
public Binding doBind(Binder binder) {
32+
public <T> Binding<T> doBind(Binder<T> binder) {
3333
try {
3434
InputStream stream = url.openStream();
3535
return InputStreamXmlSource.doBind( binder, stream, getOrigin(), true );

hibernate-core/src/main/java/org/hibernate/boot/jaxb/spi/XmlSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ public Origin getOrigin() {
2626
return origin;
2727
}
2828

29-
public abstract Binding doBind(Binder binder);
29+
public abstract <T> Binding<T> doBind(Binder<T> binder);
3030
}

hibernate-core/src/main/java/org/hibernate/boot/spi/XmlMappingBinderAccess.java

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -55,44 +55,36 @@ public MappingBinder getMappingBinder() {
5555
/**
5656
* Create a {@linkplain Binding binding} from a named URL resource
5757
*/
58-
public <X extends JaxbBindableMappingDescriptor> Binding<X> bind(String resource) {
58+
public Binding<JaxbBindableMappingDescriptor> bind(String resource) {
5959
LOG.tracef( "reading mappings from resource : %s", resource );
60-
6160
final Origin origin = new Origin( SourceType.RESOURCE, resource );
6261
final URL url = classLoaderService.locateResource( resource );
6362
if ( url == null ) {
6463
throw new MappingNotFoundException( origin );
6564
}
66-
67-
//noinspection unchecked
6865
return new UrlXmlSource( origin, url ).doBind( getMappingBinder() );
6966
}
7067

7168
/**
7269
* Create a {@linkplain Binding binding} from a File reference
7370
*/
74-
public <X extends JaxbBindableMappingDescriptor> Binding<X> bind(File file) {
71+
public Binding<JaxbBindableMappingDescriptor> bind(File file) {
7572
final Origin origin = new Origin( SourceType.FILE, file.getPath() );
7673
LOG.tracef( "reading mappings from file : %s", origin.getName() );
77-
7874
if ( !file.exists() ) {
7975
throw new MappingNotFoundException( origin );
8076
}
81-
82-
//noinspection unchecked
8377
return new FileXmlSource( origin, file ).doBind( getMappingBinder() );
8478
}
8579

8680
/**
8781
* Create a {@linkplain Binding binding} from an input stream
8882
*/
89-
public <X extends JaxbBindableMappingDescriptor> Binding<X> bind(InputStreamAccess xmlInputStreamAccess) {
83+
public Binding<JaxbBindableMappingDescriptor> bind(InputStreamAccess xmlInputStreamAccess) {
9084
LOG.tracef( "reading mappings from InputStreamAccess : %s", xmlInputStreamAccess.getStreamName() );
91-
9285
final Origin origin = new Origin( SourceType.INPUT_STREAM, xmlInputStreamAccess.getStreamName() );
93-
InputStream xmlInputStream = xmlInputStreamAccess.accessInputStream();
86+
final InputStream xmlInputStream = xmlInputStreamAccess.accessInputStream();
9487
try {
95-
//noinspection unchecked
9688
return new InputStreamXmlSource( origin, xmlInputStream, false ).doBind( mappingBinder );
9789
}
9890
finally {
@@ -108,22 +100,19 @@ public <X extends JaxbBindableMappingDescriptor> Binding<X> bind(InputStreamAcce
108100
/**
109101
* Create a {@linkplain Binding binding} from an input stream
110102
*/
111-
public <X extends JaxbBindableMappingDescriptor> Binding<X> bind(InputStream xmlInputStream) {
103+
public Binding<JaxbBindableMappingDescriptor> bind(InputStream xmlInputStream) {
112104
LOG.trace( "reading mappings from InputStream" );
113105
final Origin origin = new Origin( SourceType.INPUT_STREAM, null );
114-
//noinspection unchecked
115106
return new InputStreamXmlSource( origin, xmlInputStream, false ).doBind( getMappingBinder() );
116107
}
117108

118109
/**
119110
* Create a {@linkplain Binding binding} from a URL
120111
*/
121-
public <X extends JaxbBindableMappingDescriptor> Binding<X> bind(URL url) {
112+
public Binding<JaxbBindableMappingDescriptor> bind(URL url) {
122113
final String urlExternalForm = url.toExternalForm();
123114
LOG.debugf( "Reading mapping document from URL : %s", urlExternalForm );
124-
125115
final Origin origin = new Origin( SourceType.URL, urlExternalForm );
126-
//noinspection unchecked
127116
return new UrlXmlSource( origin, url ).doBind( getMappingBinder() );
128117
}
129118
}

0 commit comments

Comments
 (0)