|
12 | 12 | import org.hibernate.testing.orm.junit.JiraKey;
|
13 | 13 | import org.hibernate.testing.logger.Triggerable;
|
14 | 14 | import org.hibernate.testing.orm.logger.LoggerInspectionExtension;
|
15 |
| -import org.junit.jupiter.api.Assertions; |
16 | 15 | import org.junit.jupiter.api.BeforeEach;
|
17 | 16 | import org.junit.jupiter.api.Test;
|
18 | 17 | import org.junit.jupiter.api.extension.RegisterExtension;
|
@@ -46,35 +45,7 @@ public void setUp() {
|
46 | 45 | @Test
|
47 | 46 | @JiraKey(value = "HHH-15511")
|
48 | 47 | public void testCockroachDialectVersionParsing() {
|
49 |
| - String failMsg = "HHH000511: The database version version for the Cockroach Dialect could not be determined ... should have been logged"; |
50 |
| - |
51 |
| - CockroachDBTestDialect testDialect = new CockroachDBTestDialect( null ); |
52 |
| - Assertions.assertTrue( triggerable.wasTriggered(), failMsg); |
53 |
| - DatabaseVersion dv = testDialect.getVersion(); |
54 |
| - assertNotNull( dv ); |
55 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMajorVersion(), dv.getMajor() ); |
56 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMinorVersion(), dv.getMinor() ); |
57 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMicroVersion(), dv.getMicro() ); |
58 |
| - triggerable.reset(); |
59 |
| - |
60 |
| - testDialect = new CockroachDBTestDialect( "" ); |
61 |
| - Assertions.assertTrue( triggerable.wasTriggered(), failMsg); |
62 |
| - dv = testDialect.getVersion(); |
63 |
| - assertNotNull( dv ); |
64 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMajorVersion(), dv.getMajor() ); |
65 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMinorVersion(), dv.getMinor() ); |
66 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMicroVersion(), dv.getMicro() ); |
67 |
| - triggerable.reset(); |
68 |
| - |
69 |
| - testDialect = new CockroachDBTestDialect( "Some version lacking string" ); |
70 |
| - Assertions.assertTrue( triggerable.wasTriggered(), failMsg); |
71 |
| - dv = testDialect.getVersion(); |
72 |
| - assertNotNull( dv ); |
73 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMajorVersion(), dv.getMajor() ); |
74 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMinorVersion(), dv.getMinor() ); |
75 |
| - assertEquals( testDialect.getMinimumVersion().getDatabaseMicroVersion(), dv.getMicro() ); |
76 |
| - triggerable.reset(); |
77 |
| - |
| 48 | + DatabaseVersion dv; |
78 | 49 | // using a fictitious major version, to avoid minimum version warnings
|
79 | 50 | Dialect dialect = new CockroachDBTestDialect( "CockroachDB CCL v99.2.10 (x86_64-unknown-linux-gnu, built 2022/05/02 17:38:58, go1.16.6)" );
|
80 | 51 |
|
|
0 commit comments