HHH-18500 If superclass is null, class should not be enhanced, simply return empty collection

cigaly · beikov · commit df16ea9694fa · 2024-09-19T18:58:35.000+02:00
diff --git a/hibernate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/PersistentAttributeTransformer.java b/hibernate-core/src/main/java/org/hibernate/bytecode/enhance/internal/bytebuddy/PersistentAttributeTransformer.java
@@ -145,7 +145,10 @@ private static Collection<AnnotatedFieldDescription> collectInheritPersistentFie
 		}
 		TypeDefinition managedCtSuperclass = managedCtClass.getSuperClass();
 
-		if ( enhancementContext.isEntityClass( managedCtSuperclass.asErasure() ) ) {
+		// If managedCtSuperclass is null, managedCtClass can be either interface or module-info.
+		// Interfaces are already filtered-out, and module-info does not have any fields to enhance
+		// so we can safely return empty list.
+		if ( managedCtSuperclass == null || enhancementContext.isEntityClass( managedCtSuperclass.asErasure() ) ) {
 			return Collections.emptyList();
 		}
 		else if ( !enhancementContext.isMappedSuperclassClass( managedCtSuperclass.asErasure() ) ) {

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,10 @@ private static Collection<AnnotatedFieldDescription> collectInheritPersistentFie`
`145`	`145`	`}`
`146`	`146`	`TypeDefinition managedCtSuperclass = managedCtClass.getSuperClass();`
`147`	`147`
`148`		`- if ( enhancementContext.isEntityClass( managedCtSuperclass.asErasure() ) ) {`
	`148`	`+ // If managedCtSuperclass is null, managedCtClass can be either interface or module-info.`
	`149`	`+ // Interfaces are already filtered-out, and module-info does not have any fields to enhance`
	`150`	`+ // so we can safely return empty list.`
	`151`	`+ if ( managedCtSuperclass == null \|\| enhancementContext.isEntityClass( managedCtSuperclass.asErasure() ) ) {`
`149`	`152`	`return Collections.emptyList();`
`150`	`153`	`}`
`151`	`154`	`else if ( !enhancementContext.isMappedSuperclassClass( managedCtSuperclass.asErasure() ) ) {`