Skip to content

Commit e48670c

Browse files
committed
HHH-19260 - Move supportsWithClause() to Dialect
Signed-off-by: Jan Schatteman <[email protected]>
1 parent 1ee18f7 commit e48670c

17 files changed

+42
-57
lines changed

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,4 +1082,9 @@ public boolean supportsRowValueConstructorSyntax() {
10821082
return false;
10831083
}
10841084

1085+
@Override
1086+
public boolean supportsWithClause() {
1087+
return false;
1088+
}
1089+
10851090
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyLegacyDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,4 +1088,9 @@ public boolean supportsRowValueConstructorSyntax() {
10881088
return false;
10891089
}
10901090

1091+
@Override
1092+
public boolean supportsWithClause() {
1093+
return false;
1094+
}
1095+
10911096
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbyLegacySqlAstTranslator.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,6 @@ protected void renderDmlTargetTableExpression(NamedTableReference tableReference
105105
}
106106
}
107107

108-
@Override
109-
protected boolean supportsWithClause() {
110-
return false;
111-
}
112-
113108
@Override
114109
protected void renderExpressionAsClauseItem(Expression expression) {
115110
expression.accept( this );

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DerbySqlAstTranslator.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,6 @@ protected void renderDmlTargetTableExpression(NamedTableReference tableReference
105105
}
106106
}
107107

108-
@Override
109-
protected boolean supportsWithClause() {
110-
return false;
111-
}
112-
113108
@Override
114109
protected void renderExpressionAsClauseItem(Expression expression) {
115110
expression.accept( this );

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MariaDBLegacyDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,4 +313,9 @@ public boolean supportsSimpleQueryGrouping() {
313313
return getVersion().isSameOrAfter( 10, 4 );
314314
}
315315

316+
@Override
317+
public boolean supportsWithClause() {
318+
return getVersion().isSameOrAfter( 10, 2 );
319+
}
320+
316321
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MariaDBLegacySqlAstTranslator.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,6 @@ else if ( qualifierSupport != DmlTargetColumnQualifierSupport.NONE || !getQueryP
177177
}
178178
}
179179

180-
@Override
181-
protected boolean supportsWithClause() {
182-
return dialect.getVersion().isSameOrAfter( 10, 2 );
183-
}
184-
185180
@Override
186181
protected boolean supportsWithClauseInSubquery() {
187182
return false;

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacyDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1529,4 +1529,9 @@ public boolean supportsSimpleQueryGrouping() {
15291529
return getVersion().isSameOrAfter( 8 );
15301530
}
15311531

1532+
@Override
1533+
public boolean supportsWithClause() {
1534+
return getVersion().isSameOrAfter( 8 );
1535+
}
1536+
15321537
}

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/MySQLLegacySqlAstTranslator.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,6 @@ protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
374374
return false;
375375
}
376376

377-
@Override
378-
protected boolean supportsWithClause() {
379-
return getDialect().getVersion().isSameOrAfter( 8 );
380-
}
381-
382377
@Override
383378
public MySQLLegacyDialect getDialect() {
384379
return (MySQLLegacyDialect) DialectDelegateWrapper.extractRealDialect( super.getDialect() );

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseASELegacySqlAstTranslator.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,6 @@ protected void visitConflictClause(ConflictClause conflictClause) {
129129
}
130130
}
131131

132-
@Override
133-
protected boolean supportsWithClause() {
134-
return false;
135-
}
136-
137132
// Sybase ASE does not allow CASE expressions where all result arms contain plain parameters.
138133
// At least one result arm must provide some type context for inference,
139134
// so we cast the first result arm if we encounter this condition

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SybaseLegacyDialect.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -535,4 +535,9 @@ public boolean supportsRowValueConstructorSyntax() {
535535
return false;
536536
}
537537

538+
@Override
539+
public boolean supportsWithClause() {
540+
return false;
541+
}
542+
538543
}

0 commit comments

Comments
 (0)