HHH-18271 Optimizations related to caching and statement execution

* Acquire ResultSet eagerly in JdbcValuesResultSetImpl to allow better inlining of hot next() method
* Precompute cache related metadata in JdbcValuesMapping
* Don't copy data returned from cache, since it's never mutated
* Improve QueryParameterBindings building and binding
* Get rid of LinkedIdentityHashMap and reduce allocations
* Get rid of some megamorphic call sites

Author: beikov

hibernate-core/src/main/java/org/hibernate/cache/internal/QueryResultsCacheImpl.java

@@ -116,7 +116,8 @@ public List<?> get(
 			L2CACHE_LOGGER.debug( "Returning cached query results" );
 		}
 
-		return deepCopy( cacheItem.results );
+		// No need to copy results, since consumers will never mutate
+		return cacheItem.results;
 	}
 
 	@Override

hibernate-core/src/main/java/org/hibernate/engine/jdbc/internal/StatementPreparerImpl.java

@@ -24,6 +24,8 @@
 import org.hibernate.resource.jdbc.spi.JdbcSessionOwner;
 import org.hibernate.resource.jdbc.spi.LogicalConnectionImplementor;
 
+import org.checkerframework.checker.nullness.qual.Nullable;
+
 /**
  * Standard implementation of {@link StatementPreparer}.
  *
@@ -129,33 +131,28 @@ public PreparedStatement doPrepare() throws SQLException {
 	@Override
 	public PreparedStatement prepareQueryStatement(
 			String sql,
-			final boolean isCallable,
-			final ScrollMode scrollMode) {
+			boolean isCallable,
+			@Nullable ScrollMode scrollMode) {
+		final int resultSetType;
 		if ( scrollMode != null && !scrollMode.equals( ScrollMode.FORWARD_ONLY ) ) {
 			if ( ! settings().isScrollableResultSetsEnabled() ) {
 				throw new AssertionFailure("scrollable result sets are not enabled");
 			}
-			final PreparedStatement ps = new QueryStatementPreparationTemplate( sql ) {
-				public PreparedStatement doPrepare() throws SQLException {
-						return isCallable
-								? connection().prepareCall( sql, scrollMode.toResultSetType(), ResultSet.CONCUR_READ_ONLY )
-								: connection().prepareStatement( sql, scrollMode.toResultSetType(), ResultSet.CONCUR_READ_ONLY );
-				}
-			}.prepareStatement();
-			jdbcCoordinator.registerLastQuery( ps );
-			return ps;
+			resultSetType = scrollMode.toResultSetType();
 		}
 		else {
-			final PreparedStatement ps = new QueryStatementPreparationTemplate( sql ) {
-				public PreparedStatement doPrepare() throws SQLException {
-						return isCallable
-								? connection().prepareCall( sql )
-								: connection().prepareStatement( sql );
-				}
-			}.prepareStatement();
-			jdbcCoordinator.registerLastQuery( ps );
-			return ps;
+			resultSetType = ResultSet.TYPE_FORWARD_ONLY;
 		}
+
+		final PreparedStatement ps = new QueryStatementPreparationTemplate( sql ) {
+			public PreparedStatement doPrepare() throws SQLException {
+					return isCallable
+							? connection().prepareCall( sql, resultSetType, ResultSet.CONCUR_READ_ONLY )
+							: connection().prepareStatement( sql, resultSetType, ResultSet.CONCUR_READ_ONLY );
+			}
+		}.prepareStatement();
+		jdbcCoordinator.registerLastQuery( ps );
+		return ps;
 	}
 
 	private abstract class StatementPreparationTemplate {

hibernate-core/src/main/java/org/hibernate/engine/jdbc/spi/StatementPreparer.java

@@ -11,6 +11,8 @@
 
 import org.hibernate.ScrollMode;
 
+import org.checkerframework.checker.nullness.qual.Nullable;
+
 /**
  * Interface to the object that prepares JDBC {@link Statement}s and {@link PreparedStatement}s
  * on behalf of a {@link JdbcCoordinator}.
@@ -89,5 +91,5 @@ public interface StatementPreparer {
 	 *
 	 * @return the prepared statement
 	 */
-	PreparedStatement prepareQueryStatement(String sql, boolean isCallable, ScrollMode scrollMode);
+	PreparedStatement prepareQueryStatement(String sql, boolean isCallable, @Nullable ScrollMode scrollMode);
 }

hibernate-core/src/main/java/org/hibernate/engine/spi/LoadQueryInfluencers.java

@@ -8,10 +8,10 @@
 
 import java.io.Serializable;
 import java.util.Collections;
-import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
+import java.util.TreeMap;
 import java.util.function.Supplier;
 
 import org.hibernate.Filter;
@@ -52,7 +52,8 @@ public class LoadQueryInfluencers implements Serializable {
 	private @Nullable HashSet<String> enabledFetchProfileNames;
 
 	//Lazily initialized!
-	private @Nullable HashMap<String,Filter> enabledFilters;
+	//Note that ordering is important for cache keys
+	private @Nullable TreeMap<String,Filter> enabledFilters;
 
 	private boolean subselectFetchEnabled;
 
@@ -77,7 +78,7 @@ public LoadQueryInfluencers(SessionFactoryImplementor sessionFactory, SessionCre
 		for (FilterDefinition filterDefinition : sessionFactory.getAutoEnabledFilters()) {
 			FilterImpl filter = new FilterImpl( filterDefinition );
 			if ( enabledFilters == null ) {
-				enabledFilters = new HashMap<>();
+				enabledFilters = new TreeMap<>();
 			}
 			enabledFilters.put( filterDefinition.getFilterName(), filter );
 		}
@@ -157,7 +158,7 @@ public boolean hasEnabledFilters() {
 	}
 
 	public Map<String,Filter> getEnabledFilters() {
-		final HashMap<String, Filter> enabledFilters = this.enabledFilters;
+		final TreeMap<String, Filter> enabledFilters = this.enabledFilters;
 		if ( enabledFilters == null ) {
 			return Collections.emptyMap();
 		}
@@ -196,7 +197,7 @@ public Set<String> getEnabledFilterNames() {
 	public Filter enableFilter(String filterName) {
 		FilterImpl filter = new FilterImpl( sessionFactory.getFilterDefinition( filterName ) );
 		if ( enabledFilters == null ) {
-			this.enabledFilters = new HashMap<>();
+			this.enabledFilters = new TreeMap<>();
 		}
 		enabledFilters.put( filterName, filter );
 		return filter;

hibernate-core/src/main/java/org/hibernate/internal/FilterImpl.java

@@ -9,8 +9,9 @@
 import java.io.Serializable;
 import java.util.Arrays;
 import java.util.Collection;
-import java.util.HashMap;
+import java.util.Collections;
 import java.util.Map;
+import java.util.TreeMap;
 import java.util.function.Supplier;
 
 import org.hibernate.Filter;
@@ -19,6 +20,8 @@
 import org.hibernate.engine.spi.SessionFactoryImplementor;
 import org.hibernate.metamodel.mapping.JdbcMapping;
 
+import org.checkerframework.checker.nullness.qual.Nullable;
+
 /**
  * Implementation of FilterImpl.  FilterImpl implements the user's
  * view into enabled dynamic filters, allowing them to set filter parameter values.
@@ -30,7 +33,9 @@ public class FilterImpl implements Filter, Serializable {
 
 	private transient FilterDefinition definition;
 	private final String filterName;
-	private final Map<String,Object> parameters = new HashMap<>();
+	//Lazily initialized!
+	//Note that ordering is important for cache keys
+	private @Nullable TreeMap<String,Object> parameters;
 	private final boolean autoEnabled;
 	private final boolean applyToLoadByKey;
 
@@ -85,7 +90,7 @@ public boolean isAppliedToLoadByKey() {
 	}
 
 	public Map<String,?> getParameters() {
-		return parameters;
+		return parameters == null ? Collections.emptyMap() : Collections.unmodifiableMap( parameters );
 	}
 
 	/**
@@ -108,6 +113,9 @@ public Filter setParameter(String name, Object value) throws IllegalArgumentExce
 		if ( argument != null && !type.getJavaTypeDescriptor().isInstance( argument ) ) {
 			throw new IllegalArgumentException( "Incorrect type for parameter [" + name + "]" );
 		}
+		if ( parameters == null ) {
+			parameters = new TreeMap<>();
+		}
 		parameters.put( name, argument );
 		return this;
 	}
@@ -135,6 +143,9 @@ public Filter setParameterList(String name, Collection<?> values) throws Hiberna
 				throw new HibernateException( "Incorrect type for parameter [" + name + "]" );
 			}
 		}
+		if ( parameters == null ) {
+			parameters = new TreeMap<>();
+		}
 		parameters.put( name, values );
 		return this;
 	}
@@ -158,7 +169,7 @@ public Filter setParameterList(String name, Object[] values) throws IllegalArgum
 	 * @return The value of the named parameter.
 	 */
 	public Object getParameter(String name) {
-		return parameters.get( name );
+		return parameters == null ? null : parameters.get( name );
 	}
 
 	public Supplier<?> getParameterResolver(String name) {
@@ -189,6 +200,6 @@ private boolean hasResolver(String parameterName) {
 	}
 
 	private boolean hasArgument(String parameterName) {
-		return parameters.containsKey(parameterName);
+		return parameters != null && parameters.containsKey(parameterName);
 	}
 }

hibernate-core/src/main/java/org/hibernate/internal/util/collections/LinkedIdentityHashMap.java

@@ -13,16 +13,18 @@
 import java.util.Set;
 import java.util.function.Consumer;
 import java.util.function.Predicate;
-import java.util.stream.Collectors;
 import jakarta.persistence.Parameter;
 
+import org.hibernate.engine.spi.SessionFactoryImplementor;
 import org.hibernate.engine.spi.SharedSessionContractImplementor;
 import org.hibernate.procedure.spi.NamedCallableQueryMemento;
 import org.hibernate.procedure.spi.ParameterStrategy;
 import org.hibernate.query.QueryParameter;
+import org.hibernate.query.internal.QueryParameterBindingsImpl;
 import org.hibernate.query.procedure.ProcedureParameter;
 import org.hibernate.procedure.spi.ProcedureParameterImplementor;
 import org.hibernate.query.spi.ProcedureParameterMetadataImplementor;
+import org.hibernate.query.spi.QueryParameterBindings;
 import org.hibernate.query.spi.QueryParameterImplementor;
 
 /**
@@ -68,6 +70,11 @@ else if ( parameter.getPosition() != null ) {
 		parameters.add( parameter );
 	}
 
+	@Override
+	public QueryParameterBindings createBindings(SessionFactoryImplementor sessionFactory) {
+		return QueryParameterBindingsImpl.from( this, sessionFactory );
+	}
+
 	@Override
 	public void visitParameters(Consumer<QueryParameterImplementor<?>> consumer) {
 		if ( parameters != null ) {