warning cleanups in Dialects

Author: gavinking

hibernate-core/src/main/java/org/hibernate/dialect/AbstractTransactSQLDialect.java

@@ -60,36 +60,25 @@ public AbstractTransactSQLDialect(DialectResolutionInfo info) {
 	protected String columnType(int sqlTypeCode) {
 		// note that 'real' is double precision on SQL Server, single precision on Sybase
 		// but 'float' is single precision on Sybase, double precision on SQL Server
-		switch ( sqlTypeCode ) {
-			case BOOLEAN:
-				return "bit";
-
-			case TINYINT:
-				//'tinyint' is an unsigned type in Sybase and
-				//SQL Server, holding values in the range 0-255
-				//see HHH-6779
-				return "smallint";
-			case INTEGER:
-				//it's called 'int' not 'integer'
-				return "int";
-
-			case DATE:
-			case TIME:
-			case TIMESTAMP:
-			case TIME_WITH_TIMEZONE:
-			case TIMESTAMP_WITH_TIMEZONE:
-				return "datetime";
-
-			case BLOB:
-				return "image";
-			case CLOB:
-				return "text";
-			case NCLOB:
-				return "ntext";
-
-			default:
-				return super.columnType( sqlTypeCode );
-		}
+		return switch (sqlTypeCode) {
+			case BOOLEAN -> "bit";
+
+			// 'tinyint' is an unsigned type in Sybase and
+			// SQL Server, holding values in the range 0-255
+			// see HHH-6779
+			case TINYINT -> "smallint";
+
+			//it's called 'int' not 'integer'
+			case INTEGER -> "int";
+
+			case DATE, TIME, TIMESTAMP, TIME_WITH_TIMEZONE, TIMESTAMP_WITH_TIMEZONE -> "datetime";
+
+			case BLOB -> "image";
+			case CLOB -> "text";
+			case NCLOB -> "ntext";
+
+			default -> super.columnType( sqlTypeCode );
+		};
 	}
 
 	@Override
@@ -173,20 +162,17 @@ public String trimPattern(TrimSpec specification, boolean isWhitespace) {
 	}
 
 	public static String replaceLtrimRtrim(TrimSpec specification, boolean isWhitespace) {
-		switch ( specification ) {
-			case LEADING:
-				return isWhitespace
-						? "ltrim(?1)"
-						: "substring(?1,patindex('%[^'+?2+']%',?1),len(?1+'x')-1-patindex('%[^'+?2+']%',?1)+1)";
-			case TRAILING:
-				return isWhitespace
-						? "rtrim(?1)"
-						: "substring(?1,1,len(?1+'x')-1-patindex('%[^'+?2+']%',reverse(?1))+1)";
-			default:
-				return isWhitespace
-						? "ltrim(rtrim(?1))"
-						: "substring(?1,patindex('%[^'+?2+']%',?1),len(?1+'x')-1-patindex('%[^'+?2+']%',?1)-patindex('%[^'+?2+']%',reverse(?1))+2)";
-		}
+		return switch (specification) {
+			case LEADING -> isWhitespace
+					? "ltrim(?1)"
+					: "substring(?1,patindex('%[^'+?2+']%',?1),len(?1+'x')-1-patindex('%[^'+?2+']%',?1)+1)";
+			case TRAILING -> isWhitespace
+					? "rtrim(?1)"
+					: "substring(?1,1,len(?1+'x')-1-patindex('%[^'+?2+']%',reverse(?1))+1)";
+			default -> isWhitespace
+					? "ltrim(rtrim(?1))"
+					: "substring(?1,patindex('%[^'+?2+']%',?1),len(?1+'x')-1-patindex('%[^'+?2+']%',?1)-patindex('%[^'+?2+']%',reverse(?1))+2)";
+		};
 	}
 
 	@Override