General: Use clean WordPress version in is_wp_version_compatible().

Update `is_wp_version_compatible()` to use `wp_get_wp_version()` introduced in [58813] to ensure the value of `$wp_version` has not been modified by a theme or plugin.

Props costdev, mukesh27, Cybr, sergeybiryukov.
Fixes #61781.



git-svn-id: https://develop.svn.wordpress.org/trunk@58843 602fd350-edb4-49c9-b593-d223f7449a82

Author: peterwilsoncc

src/wp-includes/functions.php

@@ -8833,13 +8833,21 @@ function wp_get_wp_version() {
  *
  * @since 5.2.0
  *
- * @global string $wp_version The WordPress version string.
+ * @global string $_wp_tests_wp_version The WordPress version string. Used only in Core tests.
  *
  * @param string $required Minimum required WordPress version.
  * @return bool True if required version is compatible or empty, false if not.
  */
 function is_wp_version_compatible( $required ) {
-	global $wp_version;
+	if (
+		defined( 'WP_RUN_CORE_TESTS' )
+		&& WP_RUN_CORE_TESTS
+		&& isset( $GLOBALS['_wp_tests_wp_version'] )
+	) {
+		$wp_version = $GLOBALS['_wp_tests_wp_version'];
+	} else {
+		$wp_version = wp_get_wp_version();
+	}
 
 	// Strip off any -alpha, -RC, -beta, -src suffixes.
 	list( $version ) = explode( '-', $wp_version );

tests/phpunit/tests/functions/isWpVersionCompatible.php

@@ -8,12 +8,45 @@
  * @covers ::is_wp_version_compatible
  */
 class Tests_Functions_IsWpVersionCompatible extends WP_UnitTestCase {
+	/**
+	 * The current WordPress version.
+	 *
+	 * @var string
+	 */
+	private static $wp_version;
+
+	/**
+	 * Sets the test WordPress version property and global before any tests run.
+	 */
+	public static function set_up_before_class() {
+		parent::set_up_before_class();
+		self::$wp_version                = wp_get_wp_version();
+		$GLOBALS['_wp_tests_wp_version'] = self::$wp_version;
+	}
+
+	/**
+	 * Resets the test WordPress version global after each test runs.
+	 */
+	public function tear_down() {
+		$GLOBALS['_wp_tests_wp_version'] = self::$wp_version;
+		parent::tear_down();
+	}
+
+	/**
+	 * Unsets the test WordPress version global after all tests run.
+	 */
+	public static function tear_down_after_class() {
+		unset( $GLOBALS['_wp_tests_wp_version'] );
+		parent::tear_down_after_class();
+	}
+
 	/**
 	 * Tests is_wp_version_compatible().
 	 *
 	 * @dataProvider data_is_wp_version_compatible
 	 *
 	 * @ticket 54257
+	 * @ticket 61781
 	 *
 	 * @param mixed $required The minimum required WordPress version.
 	 * @param bool  $expected The expected result.
@@ -28,8 +61,7 @@ public function test_is_wp_version_compatible( $required, $expected ) {
 	 * @return array[]
 	 */
 	public function data_is_wp_version_compatible() {
-		global $wp_version;
-
+		$wp_version     = wp_get_wp_version();
 		$version_parts  = explode( '.', $wp_version );
 		$lower_version  = $version_parts;
 		$higher_version = $version_parts;
@@ -104,22 +136,15 @@ public function data_is_wp_version_compatible() {
 	 * @dataProvider data_is_wp_version_compatible_should_gracefully_handle_trailing_point_zero_version_numbers
 	 *
 	 * @ticket 59448
+	 * @ticket 61781
 	 *
 	 * @param mixed  $required The minimum required WordPress version.
 	 * @param string $wp       The value for the $wp_version global variable.
 	 * @param bool   $expected The expected result.
 	 */
 	public function test_is_wp_version_compatible_should_gracefully_handle_trailing_point_zero_version_numbers( $required, $wp, $expected ) {
-		global $wp_version;
-		$original_version = $wp_version;
-		$wp_version       = $wp;
-
-		$actual = is_wp_version_compatible( $required );
-
-		// Reset the version before the assertion in case of failure.
-		$wp_version = $original_version;
-
-		$this->assertSame( $expected, $actual, 'The expected result was not returned.' );
+		$GLOBALS['_wp_tests_wp_version'] = $wp;
+		$this->assertSame( $expected, is_wp_version_compatible( $required ), 'The expected result was not returned.' );
 	}
 
 	/**
@@ -183,22 +208,15 @@ public function data_is_wp_version_compatible_should_gracefully_handle_trailing_
 	 * @dataProvider data_is_wp_version_compatible_with_development_versions
 	 *
 	 * @ticket 54257
+	 * @ticket 61781
 	 *
 	 * @param string $required  The minimum required WordPress version.
 	 * @param string $wp        The value for the $wp_version global variable.
 	 * @param bool   $expected  The expected result.
 	 */
 	public function test_is_wp_version_compatible_with_development_versions( $required, $wp, $expected ) {
-		global $wp_version;
-
-		$original_version = $wp_version;
-		$wp_version       = $wp;
-		$actual           = is_wp_version_compatible( $required );
-
-		// Reset the version before the assertion in case of failure.
-		$wp_version = $original_version;
-
-		$this->assertSame( $expected, $actual );
+		$GLOBALS['_wp_tests_wp_version'] = $wp;
+		$this->assertSame( $expected, is_wp_version_compatible( $required ) );
 	}
 
 	/**
@@ -207,10 +225,8 @@ public function test_is_wp_version_compatible_with_development_versions( $requir
 	 * @return array[]
 	 */
 	public function data_is_wp_version_compatible_with_development_versions() {
-		global $wp_version;
-
 		// For consistent results, remove possible suffixes.
-		list( $version ) = explode( '-', $wp_version );
+		list( $version ) = explode( '-', wp_get_wp_version() );
 
 		$version_parts  = explode( '.', $version );
 		$lower_version  = $version_parts;