Skip to content

Commit 5b2a6ae

Browse files
committed
Themes: Revert appearance tools theme support.
The appearance tools theme support(merged in [55067]) includes block gap, a feature that was not intended for themes without a theme.json. Until it has been determined if the feature can and should be enabled in these themes, and has been successfully tested, the appearance tools theme support should be reverted. Reverts [55067]. Props poena, Mamaduka, audrasjb. Fixes #57649. git-svn-id: https://develop.svn.wordpress.org/trunk@55273 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 67f101e commit 5b2a6ae

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

src/wp-includes/class-wp-theme-json-resolver.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -314,11 +314,6 @@ public static function get_theme_data( $deprecated = array(), $options = array()
314314

315315
// Classic themes without a theme.json don't support global duotone.
316316
$theme_support_data['settings']['color']['defaultDuotone'] = false;
317-
318-
// Allow themes to enable appearance tools via theme_support.
319-
if ( current_theme_supports( 'appearance-tools' ) ) {
320-
$theme_support_data['settings']['appearanceTools'] = true;
321-
}
322317
}
323318
$with_theme_supports = new WP_Theme_JSON( $theme_support_data );
324319
$with_theme_supports->merge( static::$theme );

tests/phpunit/tests/theme/wpThemeJsonResolver.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -433,9 +433,6 @@ public function data_get_core_data() {
433433

434434
/**
435435
* @ticket 54336
436-
* @ticket 56467
437-
*
438-
* @covers ::add_theme_support
439436
*/
440437
public function test_add_theme_supports_are_loaded_for_themes_without_theme_json() {
441438
switch_theme( 'default' );
@@ -458,18 +455,15 @@ public function test_add_theme_supports_are_loaded_for_themes_without_theme_json
458455
);
459456
add_theme_support( 'editor-color-palette', $color_palette );
460457
add_theme_support( 'custom-line-height' );
461-
add_theme_support( 'appearance-tools' );
462458

463459
$settings = WP_Theme_JSON_Resolver::get_theme_data()->get_settings();
464460

465461
remove_theme_support( 'custom-line-height' );
466462
remove_theme_support( 'editor-color-palette' );
467-
remove_theme_support( 'appearance-tools' );
468463

469464
$this->assertFalse( wp_theme_has_theme_json() );
470465
$this->assertTrue( $settings['typography']['lineHeight'] );
471466
$this->assertSame( $color_palette, $settings['color']['palette']['theme'] );
472-
$this->assertTrue( $settings['border']['color'], 'Support for appearance-tools was not added.' );
473467
}
474468

475469
/**

0 commit comments

Comments
 (0)