Skip to content

Commit 6406dba

Browse files
Tests: Use correct comparison in do_enclose() tests.
As per the PHP manual: > If the `component` parameter is omitted, an associative array is returned. > If the `component` parameter is specified, `parse_url()` returns a string (or an int, in the case of `PHP_URL_PORT`) instead of an array. If the requested component doesn't exist within the given URL, `null` will be returned. Reference: [https://www.php.net/manual/en/function.parse-url.php#refsect1-function.parse-url-returnvalues PHP Manual: parse_url(): Return Values] In this case, `parse_url()` is called with the `PHP_URL_PATH` as `$component`, but the returned value is subsequently checked against `false`. In other words, this condition would previously always result in `true` and would lead to `null` potentially being passed to the PHP native `pathinfo()` function which expects a string. On PHP 8.1, this would result in a test failure with a `pathinfo(): Passing null to parameter #1 ($path) of type string is deprecated` error. Reference: [https://www.php.net/manual/en/function.pathinfo.php PHP Manual: pathinfo()] Follow-up to [46175]. Props jrf. See #53635. git-svn-id: https://develop.svn.wordpress.org/trunk@51606 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 2985e90 commit 6406dba

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/phpunit/tests/functions/doEnclose.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ public function fake_http_request( $false, $arguments, $url ) {
280280

281281
$path = parse_url( $url, PHP_URL_PATH );
282282

283-
if ( false !== $path ) {
283+
if ( null !== $path ) {
284284
$extension = pathinfo( $path, PATHINFO_EXTENSION );
285285
if ( isset( $fake_headers[ $extension ] ) ) {
286286
return $fake_headers[ $extension ];

0 commit comments

Comments
 (0)