Skip to content

Commit 6d7430c

Browse files
SergeyBiryukovSergeyBiryukov
committed
I18N: Mark screen reader strings as such with translator comments.
This aims to provide better context for translators and make it easier to determine that some strings contain hidden accessibility text and are not displayed in the UI. Props kebbet, mercime, pavelevap, ocean90, swissspidy, Chouby, jipmoors, afercia, desrosj, costdev, audrasjb, SergeyBiryukov. Fixes #29748. git-svn-id: https://develop.svn.wordpress.org/trunk@55276 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 86dc3ff commit 6d7430c

File tree

132 files changed

+1558
-328
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

132 files changed

+1558
-328
lines changed

‎src/wp-admin/customize.php

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,12 @@
207207
<span class="preview"><?php _e( 'Preview' ); ?></span>
208208
</button>
209209
<a class="customize-controls-close" href="<?php echo esc_url( $wp_customize->get_return_url() ); ?>">
210-
<span class="screen-reader-text"><?php _e( 'Close the Customizer and go back to the previous page' ); ?></span>
210+
<span class="screen-reader-text">
211+
<?php
212+
/* translators: Hidden accessibility text. */
213+
_e( 'Close the Customizer and go back to the previous page' );
214+
?>
215+
</span>
211216
</a>
212217
</div>
213218

@@ -230,7 +235,12 @@
230235
printf( __( 'You are customizing %s' ), '<strong class="panel-title site-title">' . get_bloginfo( 'name', 'display' ) . '</strong>' );
231236
?>
232237
</span>
233-
<button type="button" class="customize-help-toggle dashicons dashicons-editor-help" aria-expanded="false"><span class="screen-reader-text"><?php _e( 'Help' ); ?></span></button>
238+
<button type="button" class="customize-help-toggle dashicons dashicons-editor-help" aria-expanded="false"><span class="screen-reader-text">
239+
<?php
240+
/* translators: Hidden accessibility text. */
241+
_e( 'Help' );
242+
?>
243+
</span></button>
234244
</div>
235245
<div class="customize-panel-description">
236246
<p>

‎src/wp-admin/edit-form-comment.php

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,12 @@
4747
<div class="inside">
4848
<h2 class="edit-comment-author"><?php _e( 'Author' ); ?></h2>
4949
<fieldset>
50-
<legend class="screen-reader-text"><?php _e( 'Comment Author' ); ?></legend>
50+
<legend class="screen-reader-text">
51+
<?php
52+
/* translators: Hidden accessibility text. */
53+
_e( 'Comment Author' );
54+
?>
55+
</legend>
5156
<table class="form-table editcomment" role="presentation">
5257
<tbody>
5358
<tr>
@@ -73,8 +78,13 @@
7378
</div>
7479

7580
<div id="postdiv" class="postarea">
81+
<label for="content" class="screen-reader-text">
82+
<?php
83+
/* translators: Hidden accessibility text. */
84+
_e( 'Comment' );
85+
?>
86+
</label>
7687
<?php
77-
echo '<label for="content" class="screen-reader-text">' . __( 'Comment' ) . '</label>';
7888
$quicktags_settings = array( 'buttons' => 'strong,em,link,block,del,ins,img,ul,ol,li,code,close' );
7989
wp_editor(
8090
$comment->comment_content,
@@ -117,7 +127,12 @@
117127
</span>
118128

119129
<fieldset id="comment-status-radio">
120-
<legend class="screen-reader-text"><?php _e( 'Comment status' ); ?></legend>
130+
<legend class="screen-reader-text">
131+
<?php
132+
/* translators: Hidden accessibility text. */
133+
_e( 'Comment status' );
134+
?>
135+
</legend>
121136
<label><input type="radio"<?php checked( $comment->comment_approved, '1' ); ?> name="comment_status" value="1" /><?php _ex( 'Approved', 'comment status' ); ?></label><br />
122137
<label><input type="radio"<?php checked( $comment->comment_approved, '0' ); ?> name="comment_status" value="0" /><?php _ex( 'Pending', 'comment status' ); ?></label><br />
123138
<label><input type="radio"<?php checked( $comment->comment_approved, 'spam' ); ?> name="comment_status" value="spam" /><?php _ex( 'Spam', 'comment status' ); ?></label>
@@ -141,9 +156,19 @@
141156
printf( __( 'Submitted on: %s' ), '<b>' . $submitted . '</b>' );
142157
?>
143158
</span>
144-
<a href="#edit_timestamp" class="edit-timestamp hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text"><?php _e( 'Edit date and time' ); ?></span></a>
159+
<a href="#edit_timestamp" class="edit-timestamp hide-if-no-js"><span aria-hidden="true"><?php _e( 'Edit' ); ?></span> <span class="screen-reader-text">
160+
<?php
161+
/* translators: Hidden accessibility text. */
162+
_e( 'Edit date and time' );
163+
?>
164+
</span></a>
145165
<fieldset id='timestampdiv' class='hide-if-js'>
146-
<legend class="screen-reader-text"><?php _e( 'Date and time' ); ?></legend>
166+
<legend class="screen-reader-text">
167+
<?php
168+
/* translators: Hidden accessibility text. */
169+
_e( 'Date and time' );
170+
?>
171+
</legend>
147172
<?php
148173
/**
149174
* @global string $action

‎src/wp-admin/export.php

Lines changed: 24 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,12 @@ function export_date_options( $post_type = 'post' ) {
177177
<h2><?php _e( 'Choose what to export' ); ?></h2>
178178
<form method="get" id="export-filters">
179179
<fieldset>
180-
<legend class="screen-reader-text"><?php _e( 'Content to export' ); ?></legend>
180+
<legend class="screen-reader-text">
181+
<?php
182+
/* translators: Hidden accessibility text. */
183+
_e( 'Content to export' );
184+
?>
185+
</legend>
181186
<input type="hidden" name="download" value="true" />
182187
<p><label><input type="radio" name="content" value="all" checked="checked" aria-describedby="all-content-desc" /> <?php _e( 'All content' ); ?></label></p>
183188
<p class="description" id="all-content-desc"><?php _e( 'This will contain all of your posts, pages, comments, custom fields, terms, navigation menus, and custom posts.' ); ?></p>
@@ -207,7 +212,12 @@ function export_date_options( $post_type = 'post' ) {
207212
</li>
208213
<li>
209214
<fieldset>
210-
<legend class="screen-reader-text"><?php _e( 'Date range:' ); ?></legend>
215+
<legend class="screen-reader-text">
216+
<?php
217+
/* translators: Hidden accessibility text. */
218+
_e( 'Date range:' )
219+
?>
220+
</legend>
211221
<label for="post-start-date" class="label-responsive"><?php _e( 'Start date:' ); ?></label>
212222
<select name="post_start_date" id="post-start-date">
213223
<option value="0"><?php _e( '&mdash; Select &mdash;' ); ?></option>
@@ -254,7 +264,12 @@ function export_date_options( $post_type = 'post' ) {
254264
</li>
255265
<li>
256266
<fieldset>
257-
<legend class="screen-reader-text"><?php _e( 'Date range:' ); ?></legend>
267+
<legend class="screen-reader-text">
268+
<?php
269+
/* translators: Hidden accessibility text. */
270+
_e( 'Date range:' );
271+
?>
272+
</legend>
258273
<label for="page-start-date" class="label-responsive"><?php _e( 'Start date:' ); ?></label>
259274
<select name="page_start_date" id="page-start-date">
260275
<option value="0"><?php _e( '&mdash; Select &mdash;' ); ?></option>
@@ -294,7 +309,12 @@ function export_date_options( $post_type = 'post' ) {
294309
<ul id="attachment-filters" class="export-filters">
295310
<li>
296311
<fieldset>
297-
<legend class="screen-reader-text"><?php _e( 'Date range:' ); ?></legend>
312+
<legend class="screen-reader-text">
313+
<?php
314+
/* translators: Hidden accessibility text. */
315+
_e( 'Date range:' );
316+
?>
317+
</legend>
298318
<label for="attachment-start-date" class="label-responsive"><?php _e( 'Start date:' ); ?></label>
299319
<select name="attachment_start_date" id="attachment-start-date">
300320
<option value="0"><?php _e( '&mdash; Select &mdash;' ); ?></option>

‎src/wp-admin/includes/class-custom-background.php

Lines changed: 30 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,12 @@ public function admin_page() {
413413
?>
414414
<tr>
415415
<th scope="row"><?php _e( 'Image Position' ); ?></th>
416-
<td><fieldset><legend class="screen-reader-text"><span><?php _e( 'Image Position' ); ?></span></legend>
416+
<td><fieldset><legend class="screen-reader-text"><span>
417+
<?php
418+
/* translators: Hidden accessibility text. */
419+
_e( 'Image Position' );
420+
?>
421+
</span></legend>
417422
<div class="background-position-control">
418423
<?php foreach ( $background_position_options as $group ) : ?>
419424
<div class="button-group">
@@ -432,7 +437,12 @@ public function admin_page() {
432437

433438
<tr>
434439
<th scope="row"><label for="background-size"><?php _e( 'Image Size' ); ?></label></th>
435-
<td><fieldset><legend class="screen-reader-text"><span><?php _e( 'Image Size' ); ?></span></legend>
440+
<td><fieldset><legend class="screen-reader-text"><span>
441+
<?php
442+
/* translators: Hidden accessibility text. */
443+
_e( 'Image Size' );
444+
?>
445+
</span></legend>
436446
<select id="background-size" name="background-size">
437447
<option value="auto"<?php selected( 'auto', get_theme_mod( 'background_size', get_theme_support( 'custom-background', 'default-size' ) ) ); ?>><?php _ex( 'Original', 'Original Size' ); ?></option>
438448
<option value="contain"<?php selected( 'contain', get_theme_mod( 'background_size', get_theme_support( 'custom-background', 'default-size' ) ) ); ?>><?php _e( 'Fit to Screen' ); ?></option>
@@ -443,23 +453,38 @@ public function admin_page() {
443453

444454
<tr>
445455
<th scope="row"><?php _ex( 'Repeat', 'Background Repeat' ); ?></th>
446-
<td><fieldset><legend class="screen-reader-text"><span><?php _ex( 'Repeat', 'Background Repeat' ); ?></span></legend>
456+
<td><fieldset><legend class="screen-reader-text"><span>
457+
<?php
458+
/* translators: Hidden accessibility text. */
459+
_ex( 'Repeat', 'Background Repeat' );
460+
?>
461+
</span></legend>
447462
<input name="background-repeat" type="hidden" value="no-repeat">
448463
<label><input type="checkbox" name="background-repeat" value="repeat"<?php checked( 'repeat', get_theme_mod( 'background_repeat', get_theme_support( 'custom-background', 'default-repeat' ) ) ); ?>> <?php _e( 'Repeat Background Image' ); ?></label>
449464
</fieldset></td>
450465
</tr>
451466

452467
<tr>
453468
<th scope="row"><?php _ex( 'Scroll', 'Background Scroll' ); ?></th>
454-
<td><fieldset><legend class="screen-reader-text"><span><?php _ex( 'Scroll', 'Background Scroll' ); ?></span></legend>
469+
<td><fieldset><legend class="screen-reader-text"><span>
470+
<?php
471+
/* translators: Hidden accessibility text. */
472+
_ex( 'Scroll', 'Background Scroll' );
473+
?>
474+
</span></legend>
455475
<input name="background-attachment" type="hidden" value="fixed">
456476
<label><input name="background-attachment" type="checkbox" value="scroll" <?php checked( 'scroll', get_theme_mod( 'background_attachment', get_theme_support( 'custom-background', 'default-attachment' ) ) ); ?>> <?php _e( 'Scroll with Page' ); ?></label>
457477
</fieldset></td>
458478
</tr>
459479
<?php endif; // get_background_image() ?>
460480
<tr>
461481
<th scope="row"><?php _e( 'Background Color' ); ?></th>
462-
<td><fieldset><legend class="screen-reader-text"><span><?php _e( 'Background Color' ); ?></span></legend>
482+
<td><fieldset><legend class="screen-reader-text"><span>
483+
<?php
484+
/* translators: Hidden accessibility text. */
485+
_e( 'Background Color' );
486+
?>
487+
</span></legend>
463488
<?php
464489
$default_color = '';
465490
if ( current_theme_supports( 'custom-background', 'default-color' ) ) {

‎src/wp-admin/includes/class-theme-installer-skin.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public function after() {
129129
'<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
130130
esc_url( $customize_url ),
131131
__( 'Live Preview' ),
132-
/* translators: %s: Theme name. */
132+
/* translators: Hidden accessibility text. %s: Theme name. */
133133
sprintf( __( 'Live Preview &#8220;%s&#8221;' ), $name )
134134
);
135135
}
@@ -139,7 +139,7 @@ public function after() {
139139
'<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
140140
esc_url( $activate_link ),
141141
__( 'Activate' ),
142-
/* translators: %s: Theme name. */
142+
/* translators: Hidden accessibility text. %s: Theme name. */
143143
sprintf( _x( 'Activate &#8220;%s&#8221;', 'theme' ), $name )
144144
);
145145

‎src/wp-admin/includes/class-theme-upgrader-skin.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public function after() {
9090
'<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
9191
esc_url( $customize_url ),
9292
__( 'Customize' ),
93-
/* translators: %s: Theme name. */
93+
/* translators: Hidden accessibility text. %s: Theme name. */
9494
sprintf( __( 'Customize &#8220;%s&#8221;' ), $name )
9595
);
9696
}
@@ -101,7 +101,7 @@ public function after() {
101101
'<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
102102
esc_url( $customize_url ),
103103
__( 'Live Preview' ),
104-
/* translators: %s: Theme name. */
104+
/* translators: Hidden accessibility text. %s: Theme name. */
105105
sprintf( __( 'Live Preview &#8220;%s&#8221;' ), $name )
106106
);
107107
}
@@ -111,7 +111,7 @@ public function after() {
111111
'<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
112112
esc_url( $activate_link ),
113113
__( 'Activate' ),
114-
/* translators: %s: Theme name. */
114+
/* translators: Hidden accessibility text. %s: Theme name. */
115115
sprintf( _x( 'Activate &#8220;%s&#8221;', 'theme' ), $name )
116116
);
117117
}

‎src/wp-admin/includes/class-walker-nav-menu-edit.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ public function start_el( &$output, $data_object, $depth = 0, $args = null, $cur
182182
$item_id,
183183
esc_url( $edit_url ),
184184
esc_attr__( 'Edit menu item' ),
185+
/* translators: Hidden accessibility text. */
185186
__( 'Edit' )
186187
);
187188
?>

‎src/wp-admin/includes/class-wp-application-passwords-list-table.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,10 @@ public function print_js_template_row() {
253253
}
254254

255255
if ( $is_primary ) {
256-
echo '<button type="button" class="toggle-row"><span class="screen-reader-text">' . __( 'Show more details' ) . '</span></button>';
256+
echo '<button type="button" class="toggle-row"><span class="screen-reader-text">' .
257+
/* translators: Hidden accessibility text. */
258+
__( 'Show more details' ) .
259+
'</span></button>';
257260
}
258261

259262
echo '</td>';

‎src/wp-admin/includes/class-wp-comments-list-table.php

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,11 @@ protected function comment_type_dropdown( $comment_type ) {
506506
);
507507

508508
if ( $comment_types && is_array( $comment_types ) ) {
509-
printf( '<label class="screen-reader-text" for="filter-by-comment-type">%s</label>', __( 'Filter by comment type' ) );
509+
printf(
510+
'<label class="screen-reader-text" for="filter-by-comment-type">%s</label>',
511+
/* translators: Hidden accessibility text. */
512+
__( 'Filter by comment type' )
513+
);
510514

511515
echo '<select id="filter-by-comment-type" name="comment_type">';
512516

@@ -862,7 +866,10 @@ protected function handle_row_actions( $item, $column_name, $primary ) {
862866

863867
$output .= '</div>';
864868

865-
$output .= '<button type="button" class="toggle-row"><span class="screen-reader-text">' . __( 'Show more details' ) . '</span></button>';
869+
$output .= '<button type="button" class="toggle-row"><span class="screen-reader-text">' .
870+
/* translators: Hidden accessibility text. */
871+
__( 'Show more details' ) .
872+
'</span></button>';
866873

867874
return $output;
868875
}
@@ -878,7 +885,12 @@ public function column_cb( $item ) {
878885

879886
if ( $this->user_can ) {
880887
?>
881-
<label class="screen-reader-text" for="cb-select-<?php echo $comment->comment_ID; ?>"><?php _e( 'Select comment' ); ?></label>
888+
<label class="screen-reader-text" for="cb-select-<?php echo $comment->comment_ID; ?>">
889+
<?php
890+
/* translators: Hidden accessibility text. */
891+
_e( 'Select comment' );
892+
?>
893+
</label>
882894
<input id="cb-select-<?php echo $comment->comment_ID; ?>" type="checkbox" name="delete_comments[]" value="<?php echo $comment->comment_ID; ?>" />
883895
<?php
884896
}

‎src/wp-admin/includes/class-wp-links-list-table.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ public function column_cb( $item ) {
176176
?>
177177
<label class="screen-reader-text" for="cb-select-<?php echo $link->link_id; ?>">
178178
<?php
179-
/* translators: %s: Link name. */
179+
/* translators: Hidden accessibility text. %s: Link name. */
180180
printf( __( 'Select %s' ), $link->link_name );
181181
?>
182182
</label>

0 commit comments

Comments
 (0)