Skip to content

Commit 9b5ef13

Browse files
committed
Options/General page: minor tweak to support deprecated timezones
Underneath the time zone selector on the Options/General page, a small snippet of info about the selected time zone is displayed. This information would be missing if the timezone would be set to a deprecated timezone value, even though PHP is perfectly capable of generating that information, including for deprecated timezones. By passing the `DateTimeZone::ALL_WITH_BC` constant as the `$timezoneGroup` parameter to the PHP native `timezone_identifiers_list()` function, a timezone name list is retrieved containing both current and deprecated timezone names, preventing the condition from failing when the current timezone is a deprecated one. See the extensive write-up about this in Trac#56468. Also see: https://www.php.net/manual/en/datetimezone.listidentifiers.php As this is an admin/output page, no tests are available or can be set up without jumping through a lot of hoops.
1 parent 172abc0 commit 9b5ef13

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/wp-admin/options-general.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@
285285
?>
286286
<br />
287287
<?php
288-
if ( in_array( $tzstring, timezone_identifiers_list(), true ) ) {
288+
if ( in_array( $tzstring, timezone_identifiers_list( DateTimeZone::ALL_WITH_BC ), true ) ) {
289289
$transitions = timezone_transitions_get( timezone_open( $tzstring ), time() );
290290

291291
// 0 index is the state at current time, 1 index is the next transition, if any.

0 commit comments

Comments
 (0)