Skip to content

Commit e7ac821

Browse files
REST API: Rename the $creating parameter of rest_after_save_widget action to $update.
This brings some consistency with similar actions for posts, e.g. `save_post` or `wp_insert_post`. Follow-up to [51068], [51069]. See #53317. git-svn-id: https://develop.svn.wordpress.org/trunk@51071 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 794a136 commit e7ac821

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,9 @@ public function update_item( $request ) {
213213
* Fires after a sidebar is updated via the REST API.
214214
*
215215
* @since 5.8.0
216-
* @param array $sidebar The updated sidebar.
217-
* @param WP_REST_Request $request Request object.
216+
*
217+
* @param array $sidebar The updated sidebar.
218+
* @param WP_REST_Request $request Request object.
218219
*/
219220
do_action( 'rest_save_sidebar', $sidebar, $request );
220221

src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,7 @@ public function delete_item( $request ) {
360360
* Fires after a widget is deleted via the REST API.
361361
*
362362
* @since 5.8.0
363+
*
363364
* @param string $widget_id ID of the widget marked for deletion.
364365
* @param string $sidebar_id ID of the sidebar the widget was deleted from.
365366
* @param WP_REST_Response $response The response data.
@@ -413,14 +414,14 @@ protected function save_widget( $request, $sidebar_id ) {
413414
$id_base = $parsed_id['id_base'];
414415
$number = isset( $parsed_id['number'] ) ? $parsed_id['number'] : null;
415416
$widget_object = $wp_widget_factory->get_widget_object( $id_base );
416-
$creating = false;
417+
$update = true;
417418
} elseif ( $request['id_base'] ) {
418419
// Saving a new widget.
419420
$id_base = $request['id_base'];
420421
$widget_object = $wp_widget_factory->get_widget_object( $id_base );
421422
$number = $widget_object ? next_widget_id_number( $id_base ) : null;
422423
$id = $widget_object ? $id_base . '-' . $number : $id_base;
423-
$creating = true;
424+
$update = false;
424425
} else {
425426
return new WP_Error(
426427
'rest_invalid_widget',
@@ -520,12 +521,13 @@ protected function save_widget( $request, $sidebar_id ) {
520521
* Fires after a widget is created or updated via the REST API.
521522
*
522523
* @since 5.8.0
524+
*
523525
* @param string $id ID of the widget being saved.
524526
* @param string $sidebar_id ID of the sidebar containing the widget being saved.
525527
* @param WP_REST_Request $request Request object.
526-
* @param bool $creating True when creating a widget, false when updating.
528+
* @param bool $update Whether this is an existing widget being updated.
527529
*/
528-
do_action( 'rest_after_save_widget', $id, $sidebar_id, $request, $creating );
530+
do_action( 'rest_after_save_widget', $id, $sidebar_id, $request, $update );
529531

530532
return $id;
531533
}

0 commit comments

Comments
 (0)