Skip to content

Commit fa2c313

Browse files
Tests: Use more appropriate assertions in get_themes() tests.
This replaces instances of `assertTrue( is_dir( ... ) )` with `assertDirectoryExists()` to use native PHPUnit functionality. The `assertDirectoryExists()` method was introduced in PHPUnit 5.6. As the minimum supported PHPUnit version has been raised to PHPUnit 5.7.21, it can now be used. Follow-up to [51543], [51574], [51579]. Props jrf. See #53363. git-svn-id: https://develop.svn.wordpress.org/trunk@51580 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 213bbf7 commit fa2c313

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/phpunit/tests/theme.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ function test_get_themes_contents() {
158158
$this->assertFileIsReadable( $dir . $file );
159159
}
160160

161-
$this->assertTrue( is_dir( $dir . $theme['Template Dir'] ) );
162-
$this->assertTrue( is_dir( $dir . $theme['Stylesheet Dir'] ) );
161+
$this->assertDirectoryExists( $dir . $theme['Template Dir'] );
162+
$this->assertDirectoryExists( $dir . $theme['Stylesheet Dir'] );
163163

164164
$this->assertSame( 'publish', $theme['Status'] );
165165

0 commit comments

Comments
 (0)