You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jrkerns In trying to troubleshoot some site specific settings I would like to override for the Catphan analysis I have been finding ct.py extremely hard to navigate. I would propose refactoring it to accomplish 2 things:
Internal module names for each model match the manual, i.e. CTP732 vs CTP404
All references using the existing classes in ct.py should work, which means leaving a few alias classes lying around.
I have a new branch on my fork where I've started the work, but would appreciate your input into this idea before I continue.
As my idea exists in my head I could see:
ct.py containing mostly settings, interfaces, and aliases, probably with a lot of comments
specific configuration files for each phantom, with documented links and hierarchies
if modules are shared between phantom models the oldest model will contain all shared implementations with newer models containing alias classes
perhaps vendor or phantom class base classes, i.e. CatPhan or ACR CT
I know this would be quite a significant change, with potentially either a lot of breaking changes or quite a few alias classes. What are your thoughts?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
@jrkerns In trying to troubleshoot some site specific settings I would like to override for the Catphan analysis I have been finding ct.py extremely hard to navigate. I would propose refactoring it to accomplish 2 things:
I have a new branch on my fork where I've started the work, but would appreciate your input into this idea before I continue.
As my idea exists in my head I could see:
I know this would be quite a significant change, with potentially either a lot of breaking changes or quite a few alias classes. What are your thoughts?
My Branch
Beta Was this translation helpful? Give feedback.
All reactions