-
Notifications
You must be signed in to change notification settings - Fork 57
Open
Description
Right now, compiler.cmake introduces the following warnings:
jrl-cmakemodules/compiler.cmake
Lines 18 to 36 in 2ede15d
| macro(_SETUP_PROJECT_WARNINGS) | |
| # -Wmissing-declarations is disabled for now as older GCC version does not | |
| # support it but CMake doest not check for the flag acceptance correctly. | |
| set( | |
| GNU_FLAGS | |
| -pedantic | |
| -Wno-long-long | |
| -Wall | |
| -Wextra | |
| -Wcast-align | |
| -Wcast-qual | |
| -Wformat | |
| -Wwrite-strings | |
| -Wconversion | |
| ) | |
| if(NOT DEFINED CXX_DISABLE_WERROR) | |
| list(APPEND GNU_FLAGS -Werror) | |
| endif(NOT DEFINED CXX_DISABLE_WERROR) |
In particular, -pedantic and -Wall introduce quite a lot of warnings. For interacting with some third-party header-only C/C++ libraries like magic_enum, -Wmissing-field-initializers and -Wconversion on GCC can get really spammy and annoying.
Another thing is that these flags are set globally, instead of on a per-target basis.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels