Merge pull request #243 from leonvogt/fix-dirty-tracking-for-boolean-attributes

Fix dirty tracking for boolean attributes

Author: jrochkind

lib/attr_json/record.rb

@@ -65,7 +65,7 @@ def attr_json_sync_to_rails_attributes
             attr_name     = attribute_def.name
             value         = container_value[attribute_def.store_key]
 
-            if value
+            unless value.nil?
               # TODO, can we just make this use the setter?
               write_attribute(attr_name, value)
 

spec/record/rails_attribute_dirty_spec.rb

@@ -29,6 +29,7 @@
       self.table_name = "products"
       attr_json :str, :string
       attr_json :int, :integer
+      attr_json :bool, :boolean
       # just to make our changes more sane, set no default
       attr_json :str_array, :string, array: true, default: AttrJson::AttributeDefinition::NO_DEFAULT_PROVIDED
       attr_json :embedded, model_class_type
@@ -180,6 +181,20 @@
         expect(obj.will_save_change_to_str?).to be true
       end
     end
+
+    describe "boolean attribute dirty tracking" do
+      it "does not report a change when assigning false to false" do
+        instance.bool = false
+        instance.save!
+        instance.reload
+        expect(instance.bool).to be false
+        expect(instance.changes.empty?).to be true
+
+        instance.assign_attributes({ str: "new", bool: false })
+        expect(instance.bool_changed?).to be false
+        expect(instance.str_changed?).to be true
+      end
+    end
   end
 
   describe "array" do