Using thread_local for all builds

See discussion at: emscripten-core/emscripten#22772

Author: jrouwe

CMakeLists.txt

@@ -59,12 +59,10 @@ if (ENABLE_MULTI_THREADING)
 		-s PTHREAD_POOL_SIZE=16)
 	set(CMAKE_CXX_FLAGS "-pthread -s SHARED_MEMORY")
 	set(OUTPUT_BASE_NAME "${OUTPUT_FOLDER}jolt-physics.multithread")
-	set(WEBIDL_PARAMS "--thread_safe")
 else()
 	set(MULTI_THREADED_FLAG "")
 	set(ENVIRONMENT_FLAG "-s ENVIRONMENT='web,node'")
 	set(OUTPUT_BASE_NAME "${OUTPUT_FOLDER}jolt-physics")
-	set(WEBIDL_PARAMS "")
 endif()
 
 # Enable SIMD flags
@@ -201,7 +199,7 @@ add_custom_command(
 	OUTPUT glue.cpp glue.js jolt.idl
 	BYPRODUCTS parser.out WebIDLGrammar.pkl
 	COMMAND cat ${JOLT_IDL_FILE} > jolt.idl
-	COMMAND ${PYTHON} ${WEBIDL_BINDER_SCRIPT} jolt.idl glue ${WEBIDL_PARAMS}
+	COMMAND ${PYTHON} ${WEBIDL_BINDER_SCRIPT} jolt.idl glue
 	DEPENDS ${JOLT_IDL_FILE}
 	COMMENT "Generating JoltPhysics.js bindings"
 	VERBATIM)

tools/webidl_binder.py

@@ -59,8 +59,6 @@ def getExtendedAttribute(self, _name):
 parser = argparse.ArgumentParser()
 parser.add_argument('--wasm64', action='store_true', default=False,
                     help='Build for wasm64')
-parser.add_argument('--thread_safe', action='store_true', default=False,
-                    help='Emit temporaries as "static thread_local" to avoid race conditions')
 parser.add_argument('infile')
 parser.add_argument('outfile')
 options = parser.parse_args()
@@ -390,7 +388,7 @@ def type_to_cdec(raw):
 
 def render_function(class_name, func_name, sigs, return_type, non_pointer,
                     copy, operator, constructor, is_static, func_scope,
-                    call_content=None, const=False, array_attribute=False, thread_safe=False):
+                    call_content=None, const=False, array_attribute=False):
   legacy_mode = CHECKS not in ['ALL', 'FAST']
   all_checks = CHECKS == 'ALL'
 
@@ -626,13 +624,10 @@ def make_call_args(i):
     basic_return = 'return ' if constructor or return_type != 'Void' else ''
     return_prefix = basic_return
     return_postfix = ''
-    storage_attribute = ''
     if non_pointer:
       return_prefix += '&'
-    if thread_safe:
-      storage_attribute = 'thread_local '
     if copy:
-      pre += '  static %s%s temp;\n' % (storage_attribute, type_to_c(return_type, non_pointing=True))
+      pre += '  static thread_local %s temp;\n' % type_to_c(return_type, non_pointing=True)
       return_prefix += '(temp = '
       return_postfix += ', &temp)'
 
@@ -770,8 +765,7 @@ def add_bounds_check_impl():
                     constructor,
                     is_static=m.isStatic(),
                     func_scope=m.parentScope.identifier.name,
-                    const=m.getExtendedAttribute('Const'),
-                    thread_safe=options.thread_safe)
+                    const=m.getExtendedAttribute('Const'))
     mid_js += ['\n']
     if constructor:
       mid_js += build_constructor(name)
@@ -813,8 +807,7 @@ def add_bounds_check_impl():
                     func_scope=interface,
                     call_content=get_call_content,
                     const=m.getExtendedAttribute('Const'),
-                    array_attribute=m.type.isArray(),
-                    thread_safe=options.thread_safe)
+                    array_attribute=m.type.isArray())
 
     if m.readonly:
       mid_js += [r'''
@@ -836,8 +829,7 @@ def add_bounds_check_impl():
                       func_scope=interface,
                       call_content=set_call_content,
                       const=m.getExtendedAttribute('Const'),
-                      array_attribute=m.type.isArray(),
-                      thread_safe=options.thread_safe)
+                      array_attribute=m.type.isArray())
       mid_js += [r'''
 /** @suppress {checkTypes} */
 Object.defineProperty(%s.prototype, '%s', { get: %s.prototype.%s, set: %s.prototype.%s });
@@ -855,8 +847,7 @@ def add_bounds_check_impl():
                     False,
                     False,
                     func_scope=interface,
-                    call_content='delete self',
-                    thread_safe=options.thread_safe)
+                    call_content='delete self')
 
   # Emit C++ class implementation that calls into JS implementation