Resolve codenarc issues, tweak test names

Author: michaelwoodson

jruby-gradle-base-plugin/src/main/groovy/com/github/jrubygradle/internal/GemVersion.groovy

@@ -169,27 +169,13 @@ class GemVersion {
             return 1
         }
 
-        def aaObject
-        def bbObject
-
         if (aDigits[index].isInteger() && bDigits[index].isInteger()) {
             // compare them as number
-            aaObject = aDigits[index] as int
-            bbObject = bDigits[index] as int
+            aDigits[index] as int <=> bDigits[index] as int
         }
         else {
             // compare them as string
-            aaObject = aDigits[index]
-            bbObject = bDigits[index]
-        }
-        if (aaObject < bbObject) {
-            -1
-        }
-        else if (aaObject > bbObject) {
-            1
-        }
-        else {
-            0
+            aDigits[index] <=> bDigits[index]
         }
     }
 

jruby-gradle-base-plugin/src/test/groovy/com/github/jrubygradle/internal/GemVersionSpec.groovy

@@ -179,23 +179,23 @@ class GemVersionSpec extends Specification {
         subject.intersect('[1.2.4, 1.2.4]').conflict() == true
     }
 
-    def "passes non-integer version ranges with no conflicts"() {
+    def "finds no conflicts in non-integer version ranges"() {
         given:
         GemVersion subject = new GemVersion('[1.2.bar, 1.2.foo]')
 
         expect:
         !subject.conflict()
     }
 
-    def "fails non-integer version ranges with conflicts"() {
+    def "finds conflicts in non-integer version ranges"() {
         given:
         GemVersion subject = new GemVersion('[1.2.foo, 1.2.bar]')
 
         expect:
         subject.conflict()
     }
 
-    def "it does not throw an exception for a '+' version"() {
+    def "does not throw an exception for a '+' version"() {
         when:
         new GemVersion('+').conflict()