Skip to content

Commit 6bab580

Browse files
committed
Deprecation message should use log.warn (#366)
1 parent 7bedfb5 commit 6bab580

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

base-plugin/src/main/groovy/com/github/jrubygradle/JRubyExec.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ class JRubyExec extends JavaExec implements JRubyAwareTask, JRubyExecSpec {
285285
}
286286

287287
private void deprecated(String message) {
288-
logger.info "Deprecated method in task ${name}: ${message}"
288+
logger.warn "Deprecated method in task ${name}: ${message}"
289289
}
290290

291291
private final JRubyPluginExtension jruby

base-plugin/src/main/groovy/com/github/jrubygradle/JRubyPluginExtension.groovy

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -81,16 +81,6 @@ class JRubyPluginExtension extends AbstractCombinedProjectTaskExtension {
8181
this.jrubyVersion = v
8282
}
8383

84-
// void setDefaultVersion(String newDefaultVersion) {
85-
// defaultVersion = newDefaultVersion
86-
// defaultVersionCallbacks.each { Closure callback -> callback.call(defaultVersion) }
87-
// execVersionCallbacks.each { Closure callback ->
88-
// if (!isExecVersionModified) {
89-
// callback.call(defaultVersion)
90-
// }
91-
// }
92-
// }
93-
9484
/**
9585
*
9686
* @deprecated Use{@link #getJrubyVersion}
@@ -207,7 +197,7 @@ class JRubyPluginExtension extends AbstractCombinedProjectTaskExtension {
207197
/** Sets the GEM configuration.
208198
*
209199
* @param c Configuration instance, Character sequence as configuration name, or a {@code Provider<Configuration}.
210-
*/
200+
*/
211201
void setGemConfiguration(final Object c) {
212202
switch (c) {
213203
case Configuration:
@@ -234,7 +224,7 @@ class JRubyPluginExtension extends AbstractCombinedProjectTaskExtension {
234224
/** Declarative way of setting the GEM configuration.
235225
*
236226
* @param c Configuration instance, Character sequence as configuration name, or a {@code Provider<Configuration}.
237-
*/
227+
*/
238228
void gemConfiguration(final Object c) {
239229
setGemConfiguration(c)
240230
}

0 commit comments

Comments
 (0)