Skip to content

Commit 8f78249

Browse files
committed
Add Guillaume Grossetie to author credits
1 parent 836837c commit 8f78249

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

base-plugin/src/integTest/groovy/com/github/jrubygradle/JRubyPrepareGemsIntegrationSpec.groovy

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ import spock.lang.Issue
3030

3131
/**
3232
* @author Schalk W. Cronjé.
33+
* @author Guillaume Grossetie
3334
*/
34-
@IgnoreIf({System.getProperty('TESTS_ARE_OFFLINE')})
35+
@IgnoreIf({ IntegrationSpecification.OFFLINE })
3536
class JRubyPrepareGemsIntegrationSpec extends IntegrationSpecification {
3637

3738
static final String DEFAULT_TASK_NAME = 'jrubyPrepare'
@@ -54,7 +55,6 @@ class JRubyPrepareGemsIntegrationSpec extends IntegrationSpecification {
5455
new File(projectDir, "gems/slim-${slimVersion}").exists()
5556
}
5657

57-
@IgnoreIf({ IntegrationSpecification.OFFLINE })
5858
void "Check if rack version gets resolved"() {
5959
setup:
6060
withPreamble """repositories.ruby.gems()
@@ -76,7 +76,6 @@ class JRubyPrepareGemsIntegrationSpec extends IntegrationSpecification {
7676
new File(projectDir, "gems/rack-1.6.12").exists()
7777
}
7878

79-
@IgnoreIf({ IntegrationSpecification.OFFLINE })
8079
void "Check if selenium-webdriver version gets resolved"() {
8180
setup:
8281
withPreamble """repositories.ruby.gems()
@@ -97,7 +96,6 @@ class JRubyPrepareGemsIntegrationSpec extends IntegrationSpecification {
9796
new File(projectDir, "gems/selenium-webdriver-3.142.6").exists()
9897
}
9998

100-
@IgnoreIf({ IntegrationSpecification.OFFLINE })
10199
void "Check that GEM dependencies are locked"() {
102100
setup:
103101
File lockFile = new File(projectDir, 'gradle/dependency-locks/gems.lockfile')
@@ -139,7 +137,6 @@ rubygems:tilt:2.0.9
139137
new File(projectDir, "gems/rack-1.6.10").exists()
140138
}
141139

142-
@IgnoreIf({ IntegrationSpecification.OFFLINE })
143140
void "Check if prerelease gem gets resolved"() {
144141
setup:
145142
withDefaultRepositories()
@@ -156,7 +153,6 @@ rubygems:tilt:2.0.9
156153
}
157154

158155
@Issue('https://github.com/jruby-gradle/jruby-gradle-plugin/issues/341')
159-
@IgnoreIf({ IntegrationSpecification.OFFLINE })
160156
void "Make an install-time gem dependency available"() {
161157
setup:
162158
withRubyGemsRepository()

core-plugin/src/main/groovy/com/github/jrubygradle/api/core/JRubyExecSpec.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
/**
22
* Copyright (c) 2014-2019, R. Tyler Croy <[email protected]>,
3-
* Schalk Cronje <[email protected]>, Christian Meier, Lookout, Inc.
4-
*
3+
* Schalk Cronje <[email protected]>, Christian Meier, Lookout, Inc.
4+
* <p>
55
* Permission is hereby granted, free of charge, to any person obtaining
66
* a copy of this software and associated documentation files (the
77
* "Software"), to deal in the Software without restriction, including
88
* without limitation the rights to use, copy, modify, merge, publish,
99
* distribute, sublicense, and/or sell copies of the Software, and to
1010
* permit persons to whom the Software is furnished to do so, subject to
1111
* the following conditions:
12-
*
12+
* <p>
1313
* The above copyright notice and this permission notice shall be
1414
* included in all copies or substantial portions of the Software.
15-
*
15+
* <p>
1616
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
1717
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
1818
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND

core-plugin/src/main/groovy/com/github/jrubygradle/api/gems/GemVersion.groovy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ import static com.github.jrubygradle.api.gems.GemVersion.Boundary.OPEN_ENDED
6262
*
6363
* @author Christian Meier
6464
* @author Schalk W. Cronjé
65+
* @author Guillaume Grossetie
6566
*
6667
* @since 2.0 (Moved here from base plugin where it existed since 0.4.0)
6768
*/

0 commit comments

Comments
 (0)