Skip to content

Commit 9ab8182

Browse files
author
R. Tyler Croy
committed
Rename jruby.gemrepo_url to jruby.defaultGemRepo before anybody notices
1 parent 8a71ac2 commit 9ab8182

File tree

5 files changed

+12
-4
lines changed

5 files changed

+12
-4
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
## v2.1.1
4+
5+
* Removed `jruby.gemrepo_url` extension point (*hopefully*) before anybody
6+
started using it. Renamed to `jruby.defaultGemRepo` to line up better with
7+
changes that will come in to support [multiple rubygem
8+
repos](https://github.com/rtyler/jruby-gradle-plugin/issues/13)
9+
310
## v2.1.0
411

512
* [#18](https://github.com/rtyler/jruby-gradle-plugin/issues/18) allow

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ You can then use that custom Gem repository with:
186186
apply plugin: 'com.lookout.jruby'
187187
188188
// Set our custom Gem repository
189-
jruby.gemrepo_url = 'http://localhost:8989/releases'
189+
jruby.defaultGemRepo = 'http://localhost:8989/releases'
190190
191191
dependencies {
192192
gems group: 'com.lookout', name: 'custom-gem', version: '1.0.+'

src/main/groovy/com/lookout/jruby/JRubyPlugin.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class JRubyPlugin implements Plugin<Project> {
1616
maven {
1717
// The url is in a closure to ensure that we can overwrite this
1818
// at runtime and have the right value come through.
19-
url { project.jruby.gemrepo_url }
19+
url { project.jruby.defaultGemRepo }
2020
}
2121

2222
// Required to pull in our warbler-bootstrap dependency

src/main/groovy/com/lookout/jruby/JRubyPluginExtension.groovy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ import org.gradle.api.Project
44

55
class JRubyPluginExtension {
66
// More details here: <http://rubygems-proxy.torquebox.org/>
7-
String gemrepo_url = "http://rubygems-proxy.torquebox.org/releases"
7+
String defaultGemRepo = 'http://rubygems-proxy.torquebox.org/releases'
8+
String gemrepo_url = defaultGemRepo
89
String gemInstallDir = 'vendor'
910
String defaultVersion = '1.7.13'
1011
String execVersion = defaultVersion

src/test/groovy/com/lookout/jruby/JRubyPluginTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class JRubyPluginTest {
5353
@Test
5454
public void jrubyPluginCustomGemRepoUrl() {
5555
def url = 'http://junit.maven/releases'
56-
project.jruby.gemrepo_url = url
56+
project.jruby.defaultGemRepo = url
5757
assertTrue(hasRepositoryUrl(project, url))
5858
}
5959

0 commit comments

Comments
 (0)