Skip to content

Commit 9c426d7

Browse files
committed
Clean up build.gradle after restructured unit- and integration tests
1 parent 42566fe commit 9c426d7

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

base-plugin/build.gradle

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -85,22 +85,18 @@ dependencies {
8585
}
8686

8787
test {
88-
systemProperties TESTROOT : new File(buildDir,'tmp/test/unittests').absolutePath
89-
systemProperties TEST_GEM_DIR : new File(projectDir,'src/integTest/resources/gems').absolutePath
90-
systemProperties 'logback.configurationFile' : new File(projectDir,'src/test/resources/logback-test.xml').absolutePath
91-
9288
if (gradle.startParameter.isOffline()) {
9389
systemProperties 'TESTS_ARE_OFFLINE' : '1'
9490
}
9591
}
9692

9793
generateTestConfig {
9894
testProperties mavenrepo: file('src/integTest/mavenrepo').absolutePath,
99-
flatrepo: flatRepoDir.absolutePath,
100-
bcprovVersion: bcprovVersion,
101-
olderJRubyVersion: olderJRubyVersion,
102-
slimVersion: slimVersion,
103-
leafyVersion: leafyVersion
95+
flatrepo: flatRepoDir.absolutePath,
96+
bcprovVersion: bcprovVersion,
97+
olderJRubyVersion: olderJRubyVersion,
98+
slimVersion: slimVersion,
99+
leafyVersion: leafyVersion
104100
}
105101

106102
task copyIntegrationTestJRuby (type:Copy) {
@@ -109,21 +105,12 @@ task copyIntegrationTestJRuby (type:Copy) {
109105
}
110106

111107
integrationTest {
112-
systemProperties TESTROOT : new File(buildDir,'tmp/integrationTest/root').absolutePath
113-
systemProperties CACHEDIR : new File(buildDir,'tmp/integrationTest/cache').absolutePath
114-
systemProperties FLATREPO : new File(buildDir,'tmp/integrationTest/flatRepo').absolutePath
115-
systemProperties TEST_SCRIPT_DIR : new File(projectDir,'src/integTest/resources/scripts').absolutePath
116-
systemProperties 'logback.configurationFile' : new File(projectDir,'src/integTest/resources/logback-test.xml').absolutePath
117-
118108
if(gradle.startParameter.isOffline()) {
119109
systemProperties 'TESTS_ARE_OFFLINE' : '1'
120110
}
121-
122111
dependsOn copyIntegrationTestJRuby
123112
}
124113

125-
126-
127114
task installGroovyDoc (type : Copy) {
128115
from ({new File(buildDir,'docs/groovydoc')}) {
129116
include '**'

base-plugin/src/test/groovy/com/github/jrubygradle/internal/JRubyExecUtilsSpec.groovy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
package com.github.jrubygradle.internal
22

33
import org.gradle.api.InvalidUserDataException
4+
import org.ysb33r.grolifant.api.OperatingSystem
45
import spock.lang.*
56

67
import static com.github.jrubygradle.internal.JRubyExecUtils.buildArgs
78

89
class JRubyExecUtilsSpec extends Specification {
9-
static final boolean IS_WINDOWS = System.getProperty('os.name').toLowerCase().startsWith('windows')
10+
static final boolean IS_WINDOWS = OperatingSystem.current().isWindows()
1011

1112
void "The version string in a jruby jar filename must be extracted correctly"() {
1213

0 commit comments

Comments
 (0)